Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/756096/?format=api
{ "id": 756096, "url": "http://patchwork.ozlabs.org/api/patches/756096/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170427175911.15477-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170427175911.15477-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2017-04-27T17:59:11", "name": "igb: make a few local functions static", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f37ac9f2872c95a9a3649e0e87087369e7b539b5", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170427175911.15477-1-colin.king@canonical.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/756096/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/756096/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wDPpc5JrNz9sN8\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 28 Apr 2017 03:59:20 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0EEBD8A9E3;\n\tThu, 27 Apr 2017 17:59:19 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id conA-KgvuYRf; Thu, 27 Apr 2017 17:59:17 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8DB798A9EC;\n\tThu, 27 Apr 2017 17:59:17 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 778B51C275D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Apr 2017 17:59:16 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6ED5782794\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Apr 2017 17:59:16 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ERlsEVfBFEQv for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Apr 2017 17:59:15 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id ADC4A82DEC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Apr 2017 17:59:15 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1d3nh9-0000qA-T3; Thu, 27 Apr 2017 17:59:11 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Thu, 27 Apr 2017 18:59:11 +0100", "Message-Id": "<20170427175911.15477-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.11.0", "MIME-Version": "1.0", "Cc": "kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] igb: make a few local functions static", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nclean up a few sparse warnings, these following\nfunctions can be made static:\n\ndrivers/net/ethernet/intel/igb/igb_main.c: warning: symbol\n 'igb_add_mac_filter' was not declared. Should it be static?\ndrivers/net/ethernet/intel/igb/igb_main.c: warning: symbol\n 'igb_del_mac_filter' was not declared. Should it be static?\ndrivers/net/ethernet/intel/igb/igb_main.c: warning: symbol\n 'igb_set_vf_mac_filter' was not declared. Should it be static?\n\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 1cf74aa4ebd9..b0021819b9d0 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -6457,8 +6457,8 @@ static void igb_set_default_mac_filter(struct igb_adapter *adapter)\n \tigb_rar_set_index(adapter, 0);\n }\n \n-int igb_add_mac_filter(struct igb_adapter *adapter, const u8 *addr,\n-\t\t const u8 queue)\n+static int igb_add_mac_filter(struct igb_adapter *adapter, const u8 *addr,\n+\t\t\t const u8 queue)\n {\n \tstruct e1000_hw *hw = &adapter->hw;\n \tint rar_entries = hw->mac.rar_entry_count -\n@@ -6487,8 +6487,8 @@ int igb_add_mac_filter(struct igb_adapter *adapter, const u8 *addr,\n \treturn -ENOSPC;\n }\n \n-int igb_del_mac_filter(struct igb_adapter *adapter, const u8 *addr,\n-\t\t const u8 queue)\n+static int igb_del_mac_filter(struct igb_adapter *adapter, const u8 *addr,\n+\t\t\t const u8 queue)\n {\n \tstruct e1000_hw *hw = &adapter->hw;\n \tint rar_entries = hw->mac.rar_entry_count -\n@@ -6540,8 +6540,8 @@ static int igb_uc_unsync(struct net_device *netdev, const unsigned char *addr)\n \treturn 0;\n }\n \n-int igb_set_vf_mac_filter(struct igb_adapter *adapter, const int vf,\n-\t\t\t const u32 info, const u8 *addr)\n+static int igb_set_vf_mac_filter(struct igb_adapter *adapter, const int vf,\n+\t\t\t\t const u32 info, const u8 *addr)\n {\n \tstruct pci_dev *pdev = adapter->pdev;\n \tstruct vf_data_storage *vf_data = &adapter->vf_data[vf];\n", "prefixes": [] }