Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/752521/?format=api
{ "id": 752521, "url": "http://patchwork.ozlabs.org/api/patches/752521/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170419132559.20459-10-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170419132559.20459-10-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-04-19T13:25:59", "name": "[next,S71,10/10] i40evf: allocate queues before we setup the interrupts and q_vectors", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d4230ad98ecfa21dc702d4285fb5febfe3903eec", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170419132559.20459-10-alice.michael@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/752521/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/752521/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3w7Zr12h24z9s3s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 20 Apr 2017 07:28:49 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5E7DC8A311;\n\tWed, 19 Apr 2017 21:28:47 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2guvCvvf4yHw; Wed, 19 Apr 2017 21:28:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id ED75A8A26C;\n\tWed, 19 Apr 2017 21:28:44 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6CA5C1C08FF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Apr 2017 21:28:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5F9F48A311\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Apr 2017 21:28:43 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HoewifSzIJed for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Apr 2017 21:28:42 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id C6A748A26C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Apr 2017 21:28:42 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Apr 2017 14:28:42 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga003.jf.intel.com with ESMTP; 19 Apr 2017 14:28:42 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.37,222,1488873600\"; d=\"scan'208\";a=\"958903577\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 19 Apr 2017 09:25:59 -0400", "Message-Id": "<20170419132559.20459-10-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170419132559.20459-1-alice.michael@intel.com>", "References": "<20170419132559.20459-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S71 10/10] i40evf: allocate queues\n\tbefore we setup the interrupts and q_vectors", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nThis matches the ordering of how we free stuff during reset and remove.\nIt also makes logical sense because we set the interrupts based on the\nnumber of queues. Currently this doesn't really matter in practice.\nHowever a future patch moves the assignment of num_active_queues into\ni40evf_alloc_queues, which is required by\ni40evf_set_interrupt_capability.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 89035ee..445a97a 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -1508,6 +1508,13 @@ int i40evf_init_interrupt_scheme(struct i40evf_adapter *adapter)\n {\n \tint err;\n \n+\terr = i40evf_alloc_queues(adapter);\n+\tif (err) {\n+\t\tdev_err(&adapter->pdev->dev,\n+\t\t\t\"Unable to allocate memory for queues\\n\");\n+\t\tgoto err_alloc_queues;\n+\t}\n+\n \trtnl_lock();\n \terr = i40evf_set_interrupt_capability(adapter);\n \trtnl_unlock();\n@@ -1524,23 +1531,16 @@ int i40evf_init_interrupt_scheme(struct i40evf_adapter *adapter)\n \t\tgoto err_alloc_q_vectors;\n \t}\n \n-\terr = i40evf_alloc_queues(adapter);\n-\tif (err) {\n-\t\tdev_err(&adapter->pdev->dev,\n-\t\t\t\"Unable to allocate memory for queues\\n\");\n-\t\tgoto err_alloc_queues;\n-\t}\n-\n \tdev_info(&adapter->pdev->dev, \"Multiqueue %s: Queue pair count = %u\",\n \t\t (adapter->num_active_queues > 1) ? \"Enabled\" : \"Disabled\",\n \t\t adapter->num_active_queues);\n \n \treturn 0;\n-err_alloc_queues:\n-\ti40evf_free_q_vectors(adapter);\n err_alloc_q_vectors:\n \ti40evf_reset_interrupt_capability(adapter);\n err_set_interrupt:\n+\ti40evf_free_queues(adapter);\n+err_alloc_queues:\n \treturn err;\n }\n \n", "prefixes": [ "next", "S71", "10/10" ] }