Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/752520/?format=api
{ "id": 752520, "url": "http://patchwork.ozlabs.org/api/patches/752520/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170419132559.20459-7-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170419132559.20459-7-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-04-19T13:25:56", "name": "[next,S71,07/10] i40evf: remove needless min_t() on num_online_cpus()*2", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c7f99433de46954ff2f179605a95d79687933f4a", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170419132559.20459-7-alice.michael@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/752520/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/752520/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3w7Zr01m2gz9s3s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 20 Apr 2017 07:28:48 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C4F628A264;\n\tWed, 19 Apr 2017 21:28:46 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ReuW+Gu4JFyb; Wed, 19 Apr 2017 21:28:45 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 69ADE8A31D;\n\tWed, 19 Apr 2017 21:28:45 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 716711C276A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Apr 2017 21:28:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4A5D730D8F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Apr 2017 21:28:43 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FvGwECqVdy0y for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Apr 2017 21:28:42 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 990A830D5F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Apr 2017 21:28:42 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Apr 2017 14:28:42 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga003.jf.intel.com with ESMTP; 19 Apr 2017 14:28:41 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.37,222,1488873600\"; d=\"scan'208\";a=\"958903567\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 19 Apr 2017 09:25:56 -0400", "Message-Id": "<20170419132559.20459-7-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170419132559.20459-1-alice.michael@intel.com>", "References": "<20170419132559.20459-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S71 07/10] i40evf: remove needless\n\tmin_t() on num_online_cpus()*2", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nWe already set pairs to the value of adapter->num_active_queues. This\nvalue is limited by vsi_res->num_queue_pairs and num_online_cpus(). This\nmeans that pairs by definition is already smaller than\nnum_online_cpus()*2, so we don't even need to bother with this check.\n\nLets just remove it and update the comment.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 8e6276d8..89035ee 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -1271,13 +1271,13 @@ static int i40evf_set_interrupt_capability(struct i40evf_adapter *adapter)\n \t}\n \tpairs = adapter->num_active_queues;\n \n-\t/* It's easy to be greedy for MSI-X vectors, but it really\n-\t * doesn't do us much good if we have a lot more vectors\n-\t * than CPU's. So let's be conservative and only ask for\n-\t * (roughly) twice the number of vectors as there are CPU's.\n+\t/* It's easy to be greedy for MSI-X vectors, but it really doesn't do\n+\t * us much good if we have more vectors than CPUs. However, we already\n+\t * limit the total number of queues by the number of CPUs so we do not\n+\t * need any further limiting here.\n \t */\n-\tv_budget = min_t(int, pairs, (int)(num_online_cpus() * 2)) + NONQ_VECS;\n-\tv_budget = min_t(int, v_budget, (int)adapter->vf_res->max_vectors);\n+\tv_budget = min_t(int, pairs + NONQ_VECS,\n+\t\t\t (int)adapter->vf_res->max_vectors);\n \n \tadapter->msix_entries = kcalloc(v_budget,\n \t\t\t\t\tsizeof(struct msix_entry), GFP_KERNEL);\n", "prefixes": [ "next", "S71", "07/10" ] }