Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/752382/?format=api
{ "id": 752382, "url": "http://patchwork.ozlabs.org/api/patches/752382/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170419173008.3648215-1-arnd@arndb.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170419173008.3648215-1-arnd@arndb.de>", "list_archive_url": null, "date": "2017-04-19T17:29:48", "name": "[net-next] i40evf: hide unused variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5c98697682b56a73bbd28a77a01f944aab2438d5", "submitter": { "id": 30, "url": "http://patchwork.ozlabs.org/api/people/30/?format=api", "name": "Arnd Bergmann", "email": "arnd@arndb.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170419173008.3648215-1-arnd@arndb.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/752382/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/752382/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3w7TY40YXHz9s65\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 20 Apr 2017 03:30:31 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2F394895C3;\n\tWed, 19 Apr 2017 17:30:30 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id eKHg1QoepggC; Wed, 19 Apr 2017 17:30:28 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 71D76895C2;\n\tWed, 19 Apr 2017 17:30:28 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6003C1C2E64\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Apr 2017 17:30:26 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5A9658879F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Apr 2017 17:30:26 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id oMwN7R_5ZtQo for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Apr 2017 17:30:25 +0000 (UTC)", "from mout.kundenserver.de (mout.kundenserver.de [212.227.126.131])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 276BC88797\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Apr 2017 17:30:24 +0000 (UTC)", "from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de\n\t(mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id\n\t0M31zr-1c865A2WQB-00ssZ5; Wed, 19 Apr 2017 19:30:07 +0200" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Arnd Bergmann <arnd@arndb.de>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Wed, 19 Apr 2017 19:29:48 +0200", "Message-Id": "<20170419173008.3648215-1-arnd@arndb.de>", "X-Mailer": "git-send-email 2.9.0", "X-Provags-ID": "V03:K0:mKs7x5V382aCHTecCCrXtm+5NmEgI1aCZZv9DljSkYr29qGt1uX\n\t8Sjg7uqtnK9mWuIwpnW8SrCWy9VP+hGysEi9D41fT6jvYpFmUyuhn3S7jdLqpGLTynKyPp6\n\t4oREE+Gz4qXWpekig/YaMFwOPvssLApexEnk/e32EJoGn8+SyntNes4k9X4LGJylHFqaXKD\n\tJ8xjP7b3NUy87QAYx0TCg==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:3zM+753HjrE=:0uylRmf/K/yR5Gm0EpdtPU\n\tTwZjjy/whvvnBMNsxy+f8xJMNzci5l3+749lJitA91yqMw6Rn1F49BCpRpPwBlFGJ3PFIimJ/\n\t6Rq+R7tczrQrjbT5kD07F2/W0cZyTgXEerLf9lF4esk3RWZ5eH13GKMpaCgseb3zeDuWd93I0\n\tD30rnMs88iaywz6ePlWwmrn4XrqE5HVDRXHZW2kqmprfxzxOgnZaB6gskFmCEcmUtk3VEQRdz\n\tUq9j8S888yj2tgO54atYQoqDGRrxfoNf/Bfo4EtJuo0P/wRuZcwHriE10bqUthRkmeNzpCw/Q\n\t0I6t6iwH8ThEOrhk0zmfGtyJngpCu7MsG/Z/16PTreznNuAXKg+Z1h+5HL7oGIpPdntD/4WYY\n\tCfpogiQlhYmpR/nARxk+xo17F+YzD44T3pOQO4e50bz0Fuyby7Mue2MRWXxn9h4jDGm9gvZJ9\n\tme87uiK0G7UKy0kWD60TQR/D7iuPAxJNKQyiwoiKXp/4snYS2oFyGr+/kCLWQ/RVaDCJ0F+E4\n\t14HtRRJXgxo3BcKRSxBwAP2Siwt5+vsinUgQzxsMKVg0loGGG//XY+roii2XjnckZLCUcML0K\n\tgo4ZCjxJenh01UwBFO2MBzWx8hasvk9xSoioORrfFjbRGSewCH8psQQnQL2sXRkDlC0Vnyswd\n\t2E8KxwUXwaXcaQzW9xxJ4DK6o821WC1dycTQvsnigniwd1PLj8K4g3lCyd8UkmdOmAYQ=", "Cc": "Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org,\n\tJoe Perches <joe@perches.com>, netdev@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org", "Subject": "[Intel-wired-lan] [PATCH net-next] i40evf: hide unused variable", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "On architectures with larger pages, we get a warning about an unused variable:\n\ndrivers/net/ethernet/intel/i40evf/i40evf_main.c: In function 'i40evf_configure_rx':\ndrivers/net/ethernet/intel/i40evf/i40evf_main.c:690:21: error: unused variable 'netdev' [-Werror=unused-variable]\n\nThis moves the declaration into the #ifdef to avoid the warning.\n\nFixes: dab86afdbbd1 (\"i40e/i40evf: Change the way we limit the maximum frame size for Rx\")\nSigned-off-by: Arnd Bergmann <arnd@arndb.de>\n---\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 12a930e879af..1bb13c864edd 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -687,13 +687,14 @@ static void i40evf_configure_tx(struct i40evf_adapter *adapter)\n static void i40evf_configure_rx(struct i40evf_adapter *adapter)\n {\n \tunsigned int rx_buf_len = I40E_RXBUFFER_2048;\n-\tstruct net_device *netdev = adapter->netdev;\n \tstruct i40e_hw *hw = &adapter->hw;\n \tint i;\n \n \t/* Legacy Rx will always default to a 2048 buffer size. */\n #if (PAGE_SIZE < 8192)\n \tif (!(adapter->flags & I40EVF_FLAG_LEGACY_RX)) {\n+\t\tstruct net_device *netdev = adapter->netdev;\n+\n \t\t/* For jumbo frames on systems with 4K pages we have to use\n \t\t * an order 1 page, so we might as well increase the size\n \t\t * of our Rx buffer to make better use of the available space\n", "prefixes": [ "net-next" ] }