Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/750493/?format=api
{ "id": 750493, "url": "http://patchwork.ozlabs.org/api/patches/750493/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170413142607.7364-2-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170413142607.7364-2-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2017-04-13T14:26:06", "name": "[v2,2/3] ixgbevf: Fix errors in retrieving RETA and RSS from PF", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a91c51b433dbb4962ab99e183caab15a5cd44ea0", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170413142607.7364-2-anthony.l.nguyen@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/750493/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/750493/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3w3lFh27Vxz9sN9\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 14 Apr 2017 01:34:16 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8FCAA89CC6;\n\tThu, 13 Apr 2017 15:34:14 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Xw7CniZRJ14L; Thu, 13 Apr 2017 15:34:13 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DD4B389CC8;\n\tThu, 13 Apr 2017 15:34:12 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 14AC61C0BC4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 13 Apr 2017 15:34:11 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 093BF30D64\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 13 Apr 2017 15:34:11 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id QL4U7TTtQRrL for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 13 Apr 2017 15:34:10 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 2E1EE30D63\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 13 Apr 2017 15:34:10 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Apr 2017 08:33:57 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.152.56])\n\tby fmsmga001.fm.intel.com with ESMTP; 13 Apr 2017 08:33:56 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.37,195,1488873600\"; d=\"scan'208\";\n\ta=\"1135071586\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 13 Apr 2017 07:26:06 -0700", "Message-Id": "<20170413142607.7364-2-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170413142607.7364-1-anthony.l.nguyen@intel.com>", "References": "<20170413142607.7364-1-anthony.l.nguyen@intel.com>", "Subject": "[Intel-wired-lan] [PATCH v2 2/3] ixgbevf: Fix errors in retrieving\n\tRETA and RSS from PF", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Mailbox support for getting RETA and RSS is available for only 82599 and\nx540; a previous patch reversed the logic and these adapters were\nreturning not supported.\n\nAlso, the NACK check in ixgbevf_get_rss_key_locked() was checking for the\ncommand IXGBE_VF_GET_RETA instead of IXGBE_VF_GET_RSS_KEY.\n\nThis patch corrects both issues by correcting the logic and checking for\nthe right command.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ixgbevf/vf.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c\nindex 8a5db9d..b6d0c01 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/vf.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/vf.c\n@@ -333,7 +333,7 @@ int ixgbevf_get_reta_locked(struct ixgbe_hw *hw, u32 *reta, int num_rx_queues)\n \tswitch (hw->api_version) {\n \tcase ixgbe_mbox_api_13:\n \tcase ixgbe_mbox_api_12:\n-\t\tif (hw->mac.type >= ixgbe_mac_X550_vf)\n+\t\tif (hw->mac.type < ixgbe_mac_X550_vf)\n \t\t\tbreak;\n \tdefault:\n \t\treturn -EOPNOTSUPP;\n@@ -399,7 +399,7 @@ int ixgbevf_get_rss_key_locked(struct ixgbe_hw *hw, u8 *rss_key)\n \tswitch (hw->api_version) {\n \tcase ixgbe_mbox_api_13:\n \tcase ixgbe_mbox_api_12:\n-\t\tif (hw->mac.type >= ixgbe_mac_X550_vf)\n+\t\tif (hw->mac.type < ixgbe_mac_X550_vf)\n \t\t\tbreak;\n \tdefault:\n \t\treturn -EOPNOTSUPP;\n@@ -419,7 +419,7 @@ int ixgbevf_get_rss_key_locked(struct ixgbe_hw *hw, u8 *rss_key)\n \tmsgbuf[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n \t/* If the operation has been refused by a PF return -EPERM */\n-\tif (msgbuf[0] == (IXGBE_VF_GET_RETA | IXGBE_VT_MSGTYPE_NACK))\n+\tif (msgbuf[0] == (IXGBE_VF_GET_RSS_KEY | IXGBE_VT_MSGTYPE_NACK))\n \t\treturn -EPERM;\n \n \t/* If we didn't get an ACK there must have been\n", "prefixes": [ "v2", "2/3" ] }