Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 749,
    "url": "http://patchwork.ozlabs.org/api/patches/749/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1221947278-16715-6-git-send-email-ilpo.jarvinen@helsinki.fi/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1221947278-16715-6-git-send-email-ilpo.jarvinen@helsinki.fi>",
    "list_archive_url": null,
    "date": "2008-09-20T21:47:48",
    "name": "[PATCHv2,net-next,05/15] tcp: Kill precaution that's very likely obsolete",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "713b3277790b3916018f5b012e993aa2f2fea804",
    "submitter": {
        "id": 255,
        "url": "http://patchwork.ozlabs.org/api/people/255/?format=api",
        "name": "Ilpo Järvinen",
        "email": "ilpo.jarvinen@helsinki.fi"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1221947278-16715-6-git-send-email-ilpo.jarvinen@helsinki.fi/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/749/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/749/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 8CF6CDDE1B\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSun, 21 Sep 2008 07:48:47 +1000 (EST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754017AbYITVs3 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSat, 20 Sep 2008 17:48:29 -0400",
            "(majordomo@vger.kernel.org) by vger.kernel.org id S1752533AbYITVsN\n\t(ORCPT <rfc822; netdev-outgoing>); Sat, 20 Sep 2008 17:48:13 -0400",
            "from courier.cs.helsinki.fi ([128.214.9.1]:39570 \"EHLO\n\tmail.cs.helsinki.fi\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751595AbYITVsD (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sat, 20 Sep 2008 17:48:03 -0400",
            "from wrl-59.cs.helsinki.fi (wrl-59.cs.helsinki.fi\n\t[128.214.166.179])\n\t(AUTH: PLAIN cs-relay, TLS: TLSv1/SSLv3,256bits,AES256-SHA)\n\tby mail.cs.helsinki.fi with esmtp; Sun, 21 Sep 2008 00:47:59 +0300\n\tid 0005BEE0.48D56F8F.00005090",
            "by wrl-59.cs.helsinki.fi (Postfix, from userid 50795)\n\tid B110CA00A6; Sun, 21 Sep 2008 00:47:58 +0300 (EEST)"
        ],
        "From": "\"=?ISO-8859-1?Q?Ilpo_J=E4rvinen?=\" <ilpo.jarvinen@helsinki.fi>",
        "To": "David Miller <davem@davemloft.net>",
        "Cc": "netdev@vger.kernel.org,\n\t\"=?utf-8?q?Ilpo=20J=E4rvinen?=\" <ilpo.jarvinen@helsinki.fi>",
        "Subject": "[PATCHv2 net-next 05/15] tcp: Kill precaution that's very likely\n\tobsolete",
        "Date": "Sun, 21 Sep 2008 00:47:48 +0300",
        "Message-Id": "<1221947278-16715-6-git-send-email-ilpo.jarvinen@helsinki.fi>",
        "X-Mailer": "git-send-email 1.5.4.2.156.ge3c5",
        "In-Reply-To": "<1221947278-16715-5-git-send-email-ilpo.jarvinen@helsinki.fi>",
        "References": "<1221947278-16715-1-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221947278-16715-2-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221947278-16715-3-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221947278-16715-4-git-send-email-ilpo.jarvinen@helsinki.fi>\n\t<1221947278-16715-5-git-send-email-ilpo.jarvinen@helsinki.fi>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=ISO-8859-1",
        "Content-Transfer-Encoding": "8bit",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "I suspect it might have been related to the changed amount\nof lost skbs, which was counted by retransmit_cnt_hint that\ngot changed.\n\nThe place for this clearing was very illogical anyway,\nit should have been after the LOST-bit clearing loop to\nmake any sense.\n\nSigned-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>\n---\n net/ipv4/tcp_input.c |    4 ----\n 1 files changed, 0 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c\nindex d271cc8..28e93f1 100644\n--- a/net/ipv4/tcp_input.c\n+++ b/net/ipv4/tcp_input.c\n@@ -2385,10 +2385,6 @@ static void tcp_undo_cwr(struct sock *sk, const int undo)\n \t}\n \ttcp_moderate_cwnd(tp);\n \ttp->snd_cwnd_stamp = tcp_time_stamp;\n-\n-\t/* There is something screwy going on with the retrans hints after\n-\t   an undo */\n-\ttcp_clear_all_retrans_hints(tp);\n }\n \n static inline int tcp_may_undo(struct tcp_sock *tp)\n",
    "prefixes": [
        "PATCHv2",
        "net-next",
        "05/15"
    ]
}