Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/747500/?format=api
{ "id": 747500, "url": "http://patchwork.ozlabs.org/api/patches/747500/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170405115103.67374-5-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170405115103.67374-5-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-04-05T11:50:57", "name": "[next,S66,v2,05/11] i40e: allow look-up of MAC address from Open Firmware or IDPROM", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "114beb00e588be03eecb2f80e57299e7a0ce2afb", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170405115103.67374-5-alice.michael@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/747500/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/747500/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vyxNx1TTLz9s8Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Apr 2017 05:53:53 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BA03B862D7;\n\tWed, 5 Apr 2017 19:53:51 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8jvQCpHUOyUs; Wed, 5 Apr 2017 19:53:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 655548632C;\n\tWed, 5 Apr 2017 19:53:45 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id E05521C0100\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Apr 2017 19:53:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DD4BD885F2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Apr 2017 19:53:44 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OihUxCyp8b+V for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Apr 2017 19:53:44 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 52F60885F5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Apr 2017 19:53:44 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Apr 2017 12:53:44 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga003.jf.intel.com with ESMTP; 05 Apr 2017 12:53:44 -0700" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"u0RpoRZb\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=intel;\n\tt=1491422024; x=1522958024;\n\th=from:to:cc:subject:date:message-id:in-reply-to: references;\n\tbh=MrFYI10VMjGGgsyoj/qcNq0zTNK4hrQFOGP/T82x6rI=;\n\tb=u0RpoRZbJzfdeGUkF+4cU4dqSUjEEwgRvuU9fWTBllovmWFnNJyYnhrr\n\tGNciMeTHvVxOjoFIuHn4sYP4fm47VQ==;", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.37,280,1488873600\"; d=\"scan'208\";a=\"952301575\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 5 Apr 2017 07:50:57 -0400", "Message-Id": "<20170405115103.67374-5-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170405115103.67374-1-alice.michael@intel.com>", "References": "<20170405115103.67374-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next S66 v2 05/11] i40e: allow look-up of MAC\n\taddress from Open Firmware or IDPROM", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nLook up the MAC address from the eth_get_platform_mac_address() function\nfirst before checking what the firmware provides. We already handle the\ncase of re-writing the MAC-VLAN filter, so there is no need to add extra\ncode for this. However, update the comment where we do this to indicate\nthat it does impact the Open Firmware MAC address case.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nChange-ID: I73e59fbe0b0e7e6f3ee9f5170d0bd3a4d5faf4db\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 29 ++++++++++++++++-------------\n 1 file changed, 16 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 1422809..bae5628 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -9317,10 +9317,15 @@ static int i40e_config_netdev(struct i40e_vsi *vsi)\n \tif (vsi->type == I40E_VSI_MAIN) {\n \t\tSET_NETDEV_DEV(netdev, &pf->pdev->dev);\n \t\tether_addr_copy(mac_addr, hw->mac.perm_addr);\n-\t\t/* The following steps are necessary to properly keep track of\n-\t\t * MAC-VLAN filters loaded into firmware - first we remove\n-\t\t * filter that is automatically generated by firmware and then\n-\t\t * add new filter both to the driver hash table and firmware.\n+\t\t/* The following steps are necessary for two reasons. First,\n+\t\t * some older NVM configurations load a default MAC-VLAN\n+\t\t * filter that will accept any tagged packet, and we want to\n+\t\t * replace this with a normal filter. Additionally, it is\n+\t\t * possible our MAC address was provided by the platform using\n+\t\t * Open Firmware or similar.\n+\t\t *\n+\t\t * Thus, we need to remove the default filter and install one\n+\t\t * specific to the MAC address.\n \t\t */\n \t\ti40e_rm_default_mac_filter(vsi, mac_addr);\n \t\tspin_lock_bh(&vsi->mac_filter_hash_lock);\n@@ -10825,20 +10830,18 @@ static void i40e_print_features(struct i40e_pf *pf)\n \n /**\n * i40e_get_platform_mac_addr - get platform-specific MAC address\n- *\n * @pdev: PCI device information struct\n * @pf: board private structure\n *\n- * Look up the MAC address in Open Firmware on systems that support it,\n- * and use IDPROM on SPARC if no OF address is found. On return, the\n- * I40E_FLAG_PF_MAC will be wset in pf->flags if a platform-specific value\n- * has been selected.\n+ * Look up the MAC address for the device. First we'll try\n+ * eth_platform_get_mac_address, which will check Open Firmware, or arch\n+ * specific fallback. Otherwise, we'll default to the stored value in\n+ * firmware.\n **/\n static void i40e_get_platform_mac_addr(struct pci_dev *pdev, struct i40e_pf *pf)\n {\n-\tpf->flags &= ~I40E_FLAG_PF_MAC;\n-\tif (!eth_platform_get_mac_address(&pdev->dev, pf->hw.mac.addr))\n-\t\tpf->flags |= I40E_FLAG_PF_MAC;\n+\tif (eth_platform_get_mac_address(&pdev->dev, pf->hw.mac.addr))\n+\t\ti40e_get_mac_addr(&pf->hw, pf->hw.mac.addr);\n }\n \n /**\n@@ -11057,9 +11060,9 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t\ti40e_aq_stop_lldp(hw, true, NULL);\n \t}\n \n-\ti40e_get_mac_addr(hw, hw->mac.addr);\n \t/* allow a platform config to override the HW addr */\n \ti40e_get_platform_mac_addr(pdev, pf);\n+\n \tif (!is_valid_ether_addr(hw->mac.addr)) {\n \t\tdev_info(&pdev->dev, \"invalid MAC address %pM\\n\", hw->mac.addr);\n \t\terr = -EIO;\n", "prefixes": [ "next", "S66", "v2", "05/11" ] }