Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/746931/?format=api
{ "id": 746931, "url": "http://patchwork.ozlabs.org/api/patches/746931/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1491334816-27356-1-git-send-email-mitch.a.williams@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1491334816-27356-1-git-send-email-mitch.a.williams@intel.com>", "list_archive_url": null, "date": "2017-04-04T19:40:16", "name": "i40e: only register client on iWarp-capable devices", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ce1c8f8dc1af51effffeca3ebf67d1ac065dbca1", "submitter": { "id": 967, "url": "http://patchwork.ozlabs.org/api/people/967/?format=api", "name": "Mitch Williams", "email": "mitch.a.williams@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1491334816-27356-1-git-send-email-mitch.a.williams@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/746931/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/746931/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vyK8R11Mrz9s81\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 5 Apr 2017 05:40:54 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5DE6F86939;\n\tTue, 4 Apr 2017 19:40:53 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ig8J6hDPJR77; Tue, 4 Apr 2017 19:40:52 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1FFE38688F;\n\tTue, 4 Apr 2017 19:40:52 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id D9FF21C2A69\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 4 Apr 2017 19:40:50 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id CACBC27E18\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 4 Apr 2017 19:40:50 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id GzGJCqKWXVWH for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 4 Apr 2017 19:40:50 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby silver.osuosl.org (Postfix) with ESMTPS id E2BF322FC3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 4 Apr 2017 19:40:49 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Apr 2017 12:40:49 -0700", "from nsmiller-mobl1.amr.corp.intel.com (HELO\n\tmawilli1-desk.amr.corp.intel.com) ([10.254.4.147])\n\tby fmsmga001.fm.intel.com with ESMTP; 04 Apr 2017 12:40:49 -0700" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"XtzeQ49A\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=intel;\n\tt=1491334849; x=1522870849;\n\th=from:to:cc:subject:date:message-id;\n\tbh=xJN1J9tND+tnom1ME6U7EDd5C1DCzyAAXo0zzIKB48M=;\n\tb=XtzeQ49AYg56ejaWCSO5UgYgIP9C5jZwGPo/FxHxv7Z4ATJE6I1q0cdF\n\tYqe6Ti8mFy5HiyQpUhIAE4/ChSIE7A==;", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.36,275,1486454400\"; d=\"scan'208\";\n\ta=\"1130940446\"", "From": "Mitch Williams <mitch.a.williams@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 4 Apr 2017 12:40:16 -0700", "Message-Id": "<1491334816-27356-1-git-send-email-mitch.a.williams@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Cc": "netdev@vger.kernel.org, sassmann@kpanic.de", "Subject": "[Intel-wired-lan] [PATCH] i40e: only register client on\n\tiWarp-capable devices", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The client interface is only intended for use on devices that support\niWarp). Only register with the client if this is the case.\n\nThis fixes a panic when loading i40iw on X710 devices.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nReported-by: Stefan Assmann <sassmann@kpanic.de>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 19 +++++++++++--------\n 1 file changed, 11 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 87d99fa..5e0e44e 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -11828,10 +11828,12 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t\t round_jiffies(jiffies + pf->service_timer_period));\n \n \t/* add this PF to client device list and launch a client service task */\n-\terr = i40e_lan_add_device(pf);\n-\tif (err)\n-\t\tdev_info(&pdev->dev, \"Failed to add PF to client API service list: %d\\n\",\n-\t\t\t err);\n+\tif (pf->flags & I40E_FLAG_IWARP_ENABLED) {\n+\t\terr = i40e_lan_add_device(pf);\n+\t\tif (err)\n+\t\t\tdev_info(&pdev->dev, \"Failed to add PF to client API service list: %d\\n\",\n+\t\t\t\t err);\n+\t}\n \n #define PCI_SPEED_SIZE 8\n #define PCI_WIDTH_SIZE 8\n@@ -12013,10 +12015,11 @@ static void i40e_remove(struct pci_dev *pdev)\n \t\ti40e_vsi_release(pf->vsi[pf->lan_vsi]);\n \n \t/* remove attached clients */\n-\tret_code = i40e_lan_del_device(pf);\n-\tif (ret_code) {\n-\t\tdev_warn(&pdev->dev, \"Failed to delete client device: %d\\n\",\n-\t\t\t ret_code);\n+\tif (pf->flags & I40E_FLAG_IWARP_ENABLED) {\n+\t\tret_code = i40e_lan_del_device(pf);\n+\t\tif (ret_code)\n+\t\t\tdev_warn(&pdev->dev, \"Failed to delete client device: %d\\n\",\n+\t\t\t\t ret_code);\n \t}\n \n \t/* shutdown and destroy the HMC */\n", "prefixes": [] }