Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/745125/?format=api
{ "id": 745125, "url": "http://patchwork.ozlabs.org/api/patches/745125/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170330074608.52108-3-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170330074608.52108-3-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2017-03-30T07:46:08", "name": "[next,S65,3/3,v2] i40e: close client on remove and shutdown", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "61e516ad326e512943e71ddd9eb212f532585d6a", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170330074608.52108-3-jeffrey.t.kirsher@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/745125/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/745125/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vtxXJ3r0rz9s4s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 30 Mar 2017 18:46:24 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 179848788C;\n\tThu, 30 Mar 2017 07:46:23 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SpOwm3tiDOJM; Thu, 30 Mar 2017 07:46:21 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BA9C187FA5;\n\tThu, 30 Mar 2017 07:46:21 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 251491C26F4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 30 Mar 2017 07:46:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 282E98788C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 30 Mar 2017 07:46:18 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PBVCx2+L8z5Y for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 30 Mar 2017 07:46:15 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id D6AE084BFA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 30 Mar 2017 07:46:14 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga105.fm.intel.com with ESMTP; 30 Mar 2017 00:46:14 -0700", "from nesmith-mobl1.amr.corp.intel.com (HELO\n\tjtkirshe-DESK.amr.corp.intel.com.com) ([10.254.126.28])\n\tby fmsmga004.fm.intel.com with ESMTP; 30 Mar 2017 00:46:14 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.36,245,1486454400\"; d=\"scan'208\";a=\"241944489\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 30 Mar 2017 00:46:08 -0700", "Message-Id": "<20170330074608.52108-3-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.12.0", "In-Reply-To": "<20170330074608.52108-1-jeffrey.t.kirsher@intel.com>", "References": "<20170330074608.52108-1-jeffrey.t.kirsher@intel.com>", "Subject": "[Intel-wired-lan] [next S65 3/3 v2] i40e: close client on remove\n\tand shutdown", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nWhen the driver is removed or shut down, close any attached clients\n(i.e. i40iw). This prevents a panic seen sometimes on forced driver\nremoval or system shutdown when iWarp is running.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nChange-ID: I4f6161e5a73ffbb2fd5883567b007310302bfcb5\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex cb087d546a0a..da22850897c2 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -11392,6 +11392,11 @@ static void i40e_remove(struct pci_dev *pdev)\n \tif (pf->service_task.func)\n \t\tcancel_work_sync(&pf->service_task);\n \n+\t/* Client close must be called explicitly here because the timer\n+\t * has been stopped.\n+\t */\n+\ti40e_notify_client_of_netdev_close(pf->vsi[pf->lan_vsi], false);\n+\n \tif (pf->flags & I40E_FLAG_SRIOV_ENABLED) {\n \t\ti40e_free_vfs(pf);\n \t\tpf->flags &= ~I40E_FLAG_SRIOV_ENABLED;\n@@ -11632,6 +11637,11 @@ static void i40e_shutdown(struct pci_dev *pdev)\n \tcancel_work_sync(&pf->service_task);\n \ti40e_fdir_teardown(pf);\n \n+\t/* Client close must be called explicitly here because the timer\n+\t * has been stopped.\n+\t */\n+\ti40e_notify_client_of_netdev_close(pf->vsi[pf->lan_vsi], false);\n+\n \tif (pf->wol_en && (pf->flags & I40E_FLAG_WOL_MC_MAGIC_PKT_WAKE))\n \t\ti40e_enable_mc_magic_wake(pf);\n \n", "prefixes": [ "next", "S65", "3/3", "v2" ] }