Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/745014/?format=api
{ "id": 745014, "url": "http://patchwork.ozlabs.org/api/patches/745014/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1490833375-2788-4-git-send-email-sridhar.samudrala@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1490833375-2788-4-git-send-email-sridhar.samudrala@intel.com>", "list_archive_url": null, "date": "2017-03-30T00:22:51", "name": "[next-queue,v6,3/7] i40e: Sync link state between PF/VFs and Port representor netdevs", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "6e01563b8c54efdef6f625bd90b5dfc4a5915261", "submitter": { "id": 65219, "url": "http://patchwork.ozlabs.org/api/people/65219/?format=api", "name": "Samudrala, Sridhar", "email": "sridhar.samudrala@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1490833375-2788-4-git-send-email-sridhar.samudrala@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/745014/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/745014/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vtlhr2TLCz9s77\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 30 Mar 2017 11:23:08 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id AC3C12EE85;\n\tThu, 30 Mar 2017 00:23:06 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nJmJQ3bSOGSz; Thu, 30 Mar 2017 00:23:03 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8EF082EEFB;\n\tThu, 30 Mar 2017 00:23:00 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 11F691CE8BC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 30 Mar 2017 00:22:58 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0D6BD8902A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 30 Mar 2017 00:22:58 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qyPMEmWmJSLt for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 30 Mar 2017 00:22:56 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id D02948902F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 30 Mar 2017 00:22:56 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga105.jf.intel.com with ESMTP; 29 Mar 2017 17:22:56 -0700", "from arch-p28.jf.intel.com ([10.166.187.27])\n\tby orsmga003.jf.intel.com with ESMTP; 29 Mar 2017 17:22:55 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.36,244,1486454400\"; d=\"scan'208\";a=\"949601321\"", "From": "Sridhar Samudrala <sridhar.samudrala@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n\talexander.h.duyck@intel.com, anjali.singhai@intel.com,\n\tjakub.kicinski@netronome.com, gerlitz.or@gmail.com, jiri@resnulli.us, \n\tsridhar.samudrala@intel.com", "Date": "Wed, 29 Mar 2017 17:22:51 -0700", "Message-Id": "<1490833375-2788-4-git-send-email-sridhar.samudrala@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1490833375-2788-1-git-send-email-sridhar.samudrala@intel.com>", "References": "<1490833375-2788-1-git-send-email-sridhar.samudrala@intel.com>", "Subject": "[Intel-wired-lan] [next-queue v6 PATCH 3/7] i40e: Sync link state\n\tbetween PF/VFs and Port representor netdevs", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "This patch enables\n- reflecting the link state of port netdev based on PF/VF admin state &\n link state of PF/VF based on admin state of the associated port netdev.\n- bringing up/down the VF port netdev sends a notification to update VF\n link state.\n- bringing up/down the VF will cause the link state update of VF port\n netdev.\n- enable/disable VF link state via ndo_set_vf_link_state will update the\n admin state of associated VF port netdev.\n- bringing up/down the PF port netdev updates the link state of PF based on\n the hw link info.\n- bringing up/down the PF will update the link state of PF port netdev.\n\nPF: p4p1, VFs: p4p1_0,p4p1_1 PF Port netdev: p4p1-pf\nVF Port netdevs:p4p1-vf0, p4p1-vf1\n# rmmod i40e; modprobe i40e\n# devlink dev eswitch set pci/0000:42:00.0 mode switchdev\n# echo 2 > /sys/class/net/p4p1/device/sriov_numvfs\n\n# ip link set p4p1 up\n# ip link show p4p1-pf\n29: p4p1-pf: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT qlen 1000\n link/ether 02:25:9e:c6:a7:3f brd ff:ff:ff:ff:ff:ff\n\n/* p4p1-pf DOWN -> p4p1 NO-CARRIER */\n# ip link show p4p1\n27: p4p1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state DOWN mode DEFAULT qlen 1000\n link/ether 3c:fd:fe:a3:18:f8 brd ff:ff:ff:ff:ff:ff\n\n# ip link set p4p1-pf up\n# ip link show p4p1-pf\n29: p4p1-pf: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT qlen 1000\n link/ether 02:25:9e:c6:a7:3f brd ff:ff:ff:ff:ff:ff\n\n/* p4p1-pf UP -> p4p1 CARRIER ON */\n# ip link show p4p1\n27: p4p1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT qlen 1000\n link/ether 3c:fd:fe:a3:18:f8 brd ff:ff:ff:ff:ff:ff\n\n# ip link set p4p1-vf0 up\n# ip link set p4p1_0 up\n\n/* p4p1_0 UP -> p4p1-vf0 CARRIER ON */\n# ip link show p4p1-vf0\n30: p4p1-vf0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT qlen 1000\n link/ether d2:7c:19:e6:e2:ef brd ff:ff:ff:ff:ff:ff\n\n/* p4p1-vf0 UP -> p4p1_0 CARRIER ON */\n# ip link show p4p1_0\n32: p4p1_0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT qlen 1000\n link/ether ba:29:a3:bb:a0:d5 brd ff:ff:ff:ff:ff:ff\n\n# ip link set p4p1_1 up\n\n/* p4p1-vf1 DOWN -> p4p1_1 NO-CARRIER */\n# ip link show p4p1_1\n33: p4p1_1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state DOWN mode DEFAULT qlen 1000\n link/ether 3e:fd:68:79:91:02 brd ff:ff:ff:ff:ff:ff\n\n# ip link set p4p1_1 down\n# ip link set p4p1-vf1 up\n\n/* p4p1_1 DOWN -> p4p1-vf1 NO-CARRIER */\n# ip link show p4p1-vf1\n31: p4p1-vf1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc pfifo_fast state DOWN mode DEFAULT qlen 1000\n link/ether e2:a0:20:20:c8:b4 brd ff:ff:ff:ff:ff:ff\n\n# ip link set p4p1-vf0 down\n\n/* p4p1-vf0 DOWN -> p4p1_0 NO-CARRIER */\n# ip link show p4p1_0\n32: p4p1_0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state DOWN mode DEFAULT qlen 1000\n link/ether 52:36:3d:37:1e:73 brd ff:ff:ff:ff:ff:ff\n\n# ip -d link show p4p1\n27: p4p1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop portid 6805ca27268 state DOWN mode DEFAULT group default qlen 1000\n link/ether 68:05:ca:2e:72:68 brd ff:ff:ff:ff:ff:ff promiscuity 0 addrgenmode eui64\n vf 0 MAC 00:00:00:00:00:00, spoof checking on, link-state disable, trust off\n vf 1 MAC 00:00:00:00:00:00, spoof checking on, link-state enable, trust off\n\nSigned-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 106 ++++++++++++++++++++-\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 21 +++-\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h | 1 +\n 3 files changed, 122 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex e441e39..683aa20 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -5316,7 +5316,8 @@ static int i40e_up_complete(struct i40e_vsi *vsi)\n \ti40e_vsi_enable_irq(vsi);\n \n \tif ((pf->hw.phy.link_info.link_info & I40E_AQ_LINK_UP) &&\n-\t (vsi->netdev)) {\n+\t (vsi->netdev) && (!pf->port_netdev ||\n+\t\t\t (pf->port_netdev->flags & IFF_UP))) {\n \t\ti40e_print_link_message(vsi, true);\n \t\tnetif_tx_start_all_queues(vsi->netdev);\n \t\tnetif_carrier_on(vsi->netdev);\n@@ -5518,6 +5519,9 @@ int i40e_open(struct net_device *netdev)\n \n \tudp_tunnel_get_rx_info(netdev);\n \n+\tif (pf->port_netdev)\n+\t\tnetif_carrier_on(pf->port_netdev);\n+\n \treturn 0;\n }\n \n@@ -5667,9 +5671,13 @@ int i40e_close(struct net_device *netdev)\n {\n \tstruct i40e_netdev_priv *np = netdev_priv(netdev);\n \tstruct i40e_vsi *vsi = np->vsi;\n+\tstruct i40e_pf *pf = vsi->back;\n \n \ti40e_vsi_close(vsi);\n \n+\tif (pf->port_netdev)\n+\t\tnetif_carrier_off(pf->port_netdev);\n+\n \treturn 0;\n }\n \n@@ -6181,10 +6189,15 @@ static void i40e_vsi_link_event(struct i40e_vsi *vsi, bool link_up)\n \n \tswitch (vsi->type) {\n \tcase I40E_VSI_MAIN:\n+\t{\n+\t\tstruct i40e_pf *pf = vsi->back;\n+\t\tstruct net_device *port_netdev = pf->port_netdev;\n+\n \t\tif (!vsi->netdev || !vsi->netdev_registered)\n \t\t\tbreak;\n \n-\t\tif (link_up) {\n+\t\tif (link_up && (!port_netdev ||\n+\t\t\t\t(port_netdev->flags & IFF_UP))) {\n \t\t\tnetif_carrier_on(vsi->netdev);\n \t\t\tnetif_tx_wake_all_queues(vsi->netdev);\n \t\t} else {\n@@ -6192,7 +6205,7 @@ static void i40e_vsi_link_event(struct i40e_vsi *vsi, bool link_up)\n \t\t\tnetif_tx_stop_all_queues(vsi->netdev);\n \t\t}\n \t\tbreak;\n-\n+\t}\n \tcase I40E_VSI_SRIOV:\n \tcase I40E_VSI_VMDQ2:\n \tcase I40E_VSI_CTRL:\n@@ -10914,7 +10927,35 @@ static int i40e_devlink_eswitch_mode_set(struct devlink *devlink, u16 mode)\n **/\n static int i40e_port_netdev_open(struct net_device *dev)\n {\n-\treturn 0;\n+\tstruct i40e_port_netdev_priv *priv = netdev_priv(dev);\n+\tstruct i40e_pf *pf;\n+\tstruct i40e_vf *vf;\n+\tstruct i40e_vsi *vsi;\n+\tint err = 0;\n+\n+\tswitch (priv->type) {\n+\tcase I40E_PORT_NETDEV_VF:\n+\t\tvf = (struct i40e_vf *)priv->f;\n+\t\tvf->link_forced = true;\n+\t\tvf->link_up = true;\n+\t\ti40e_vc_notify_vf_link_state(vf);\n+\t\tbreak;\n+\tcase I40E_PORT_NETDEV_PF:\n+\t\tpf = (struct i40e_pf *)priv->f;\n+\t\tvsi = pf->vsi[pf->lan_vsi];\n+\t\tif (pf->hw.phy.link_info.link_info & I40E_AQ_LINK_UP) {\n+\t\t\tnetif_carrier_on(vsi->netdev);\n+\t\t\tnetif_tx_start_all_queues(vsi->netdev);\n+\t\t} else {\n+\t\t\terr = -ENETDOWN;\n+\t\t}\n+\t\tbreak;\n+\tdefault:\n+\t\terr = -EINVAL;\n+\t\tbreak;\n+\t}\n+\n+\treturn err;\n }\n \n /**\n@@ -10925,7 +10966,31 @@ static int i40e_port_netdev_open(struct net_device *dev)\n **/\n static int i40e_port_netdev_stop(struct net_device *dev)\n {\n-\treturn 0;\n+\tstruct i40e_port_netdev_priv *priv = netdev_priv(dev);\n+\tstruct i40e_pf *pf;\n+\tstruct i40e_vf *vf;\n+\tstruct i40e_vsi *vsi;\n+\tint err = 0;\n+\n+\tswitch (priv->type) {\n+\tcase I40E_PORT_NETDEV_VF:\n+\t\tvf = (struct i40e_vf *)priv->f;\n+\t\tvf->link_forced = true;\n+\t\tvf->link_up = false;\n+\t\ti40e_vc_notify_vf_link_state(vf);\n+\t\tbreak;\n+\tcase I40E_PORT_NETDEV_PF:\n+\t\tpf = (struct i40e_pf *)priv->f;\n+\t\tvsi = pf->vsi[pf->lan_vsi];\n+\t\tnetif_carrier_off(vsi->netdev);\n+\t\tnetif_tx_stop_all_queues(vsi->netdev);\n+\t\tbreak;\n+\tdefault:\n+\t\terr = -EINVAL;\n+\t\tbreak;\n+\t}\n+\n+\treturn err;\n }\n \n static const struct net_device_ops i40e_port_netdev_ops = {\n@@ -11013,6 +11078,26 @@ int i40e_alloc_port_netdev(void *f, enum i40e_port_netdev_type type)\n \t\t ((type == I40E_PORT_NETDEV_PF) ? \"PF\" : \"VF\"),\n \t\t port_netdev->name);\n \n+\tswitch (type) {\n+\tcase I40E_PORT_NETDEV_PF:\n+\t\t/* Reset PF link as we are changing the mode to 'switchdev'.\n+\t\t * Port netdev needs to be brought up to enable VF link.\n+\t\t */\n+\t\tnetif_carrier_off(vsi->netdev);\n+\t\tnetif_tx_stop_all_queues(vsi->netdev);\n+\t\tif (pf->hw.phy.link_info.link_info & I40E_AQ_LINK_UP)\n+\t\t\tnetif_carrier_on(port_netdev);\n+\t\tbreak;\n+\tcase I40E_PORT_NETDEV_VF:\n+\t\t/* Reset VF link as we are changing the mode to 'switchdev'.\n+\t\t * Port netdev needs to be brought up to enable VF link.\n+\t\t */\n+\t\tvf->link_forced = true;\n+\t\tvf->link_up = false;\n+\t\ti40e_vc_notify_vf_link_state(vf);\n+\t\tbreak;\n+\t}\n+\n \treturn 0;\n }\n \n@@ -11027,10 +11112,12 @@ void i40e_free_port_netdev(void *f, enum i40e_port_netdev_type type)\n {\n \tstruct i40e_pf *pf;\n \tstruct i40e_vf *vf;\n+\tstruct i40e_vsi *vsi;\n \n \tswitch (type) {\n \tcase I40E_PORT_NETDEV_PF:\n \t\tpf = (struct i40e_pf *)f;\n+\t\tvsi = pf->vsi[pf->lan_vsi];\n \n \t\tif (!pf->port_netdev)\n \t\t\treturn;\n@@ -11039,6 +11126,11 @@ void i40e_free_port_netdev(void *f, enum i40e_port_netdev_type type)\n \t\tunregister_netdev(pf->port_netdev);\n \t\tfree_netdev(pf->port_netdev);\n \t\tpf->port_netdev = NULL;\n+\t\t/* In legacy mode, PF link is not controlled by Port netdev */\n+\t\tif (pf->hw.phy.link_info.link_info & I40E_AQ_LINK_UP) {\n+\t\t\tnetif_carrier_on(vsi->netdev);\n+\t\t\tnetif_tx_start_all_queues(vsi->netdev);\n+\t\t}\n \t\tbreak;\n \tcase I40E_PORT_NETDEV_VF:\n \t\tvf = (struct i40e_vf *)f;\n@@ -11051,6 +11143,10 @@ void i40e_free_port_netdev(void *f, enum i40e_port_netdev_type type)\n \t\tunregister_netdev(vf->port_netdev);\n \t\tfree_netdev(vf->port_netdev);\n \t\tvf->port_netdev = NULL;\n+\n+\t\t/* In legacy mode, VF link is not controlled by Port netdev */\n+\t\tvf->link_forced = false;\n+\t\ti40e_vc_notify_vf_link_state(vf);\n \t\tbreak;\n \tdefault:\n \t\tbreak;\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex e89f4c4..7c2e7b0 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -68,7 +68,7 @@ static void i40e_vc_vf_broadcast(struct i40e_pf *pf,\n *\n * send a link status message to a single VF\n **/\n-static void i40e_vc_notify_vf_link_state(struct i40e_vf *vf)\n+void i40e_vc_notify_vf_link_state(struct i40e_vf *vf)\n {\n \tstruct i40e_virtchnl_pf_event pfe;\n \tstruct i40e_pf *pf = vf->pf;\n@@ -1805,6 +1805,10 @@ static int i40e_vc_enable_queues_msg(struct i40e_vf *vf, u8 *msg, u16 msglen)\n \n \tif (i40e_vsi_start_rings(pf->vsi[vf->lan_vsi_idx]))\n \t\taq_ret = I40E_ERR_TIMEOUT;\n+\n+\tif ((aq_ret == 0) && vf->port_netdev)\n+\t\tnetif_carrier_on(vf->port_netdev);\n+\n error_param:\n \t/* send the response to the VF */\n \treturn i40e_vc_send_resp_to_vf(vf, I40E_VIRTCHNL_OP_ENABLE_QUEUES,\n@@ -1844,6 +1848,9 @@ static int i40e_vc_disable_queues_msg(struct i40e_vf *vf, u8 *msg, u16 msglen)\n \n \ti40e_vsi_stop_rings(pf->vsi[vf->lan_vsi_idx]);\n \n+\tif ((aq_ret == 0) && vf->port_netdev)\n+\t\tnetif_carrier_off(vf->port_netdev);\n+\n error_param:\n \t/* send the response to the VF */\n \treturn i40e_vc_send_resp_to_vf(vf, I40E_VIRTCHNL_OP_DISABLE_QUEUES,\n@@ -3080,6 +3087,7 @@ int i40e_ndo_set_vf_link_state(struct net_device *netdev, int vf_id, int link)\n \tstruct i40e_pf *pf = np->vsi->back;\n \tstruct i40e_virtchnl_pf_event pfe;\n \tstruct i40e_hw *hw = &pf->hw;\n+\tstruct net_device *port_netdev;\n \tstruct i40e_vf *vf;\n \tint abs_vf_id;\n \tint ret = 0;\n@@ -3121,6 +3129,17 @@ int i40e_ndo_set_vf_link_state(struct net_device *netdev, int vf_id, int link)\n \t\tret = -EINVAL;\n \t\tgoto error_out;\n \t}\n+\n+\tport_netdev = vf->port_netdev;\n+\tif (port_netdev) {\n+\t\tunsigned int flags = port_netdev->flags;\n+\n+\t\tif (vf->link_up)\n+\t\t\tdev_change_flags(port_netdev, flags | IFF_UP);\n+\t\telse\n+\t\t\tdev_change_flags(port_netdev, flags & ~IFF_UP);\n+\t}\n+\n \t/* Notify the VF of its new link state */\n \ti40e_aq_send_msg_to_vf(hw, abs_vf_id, I40E_VIRTCHNL_OP_EVENT,\n \t\t\t 0, (u8 *)&pfe, sizeof(pfe), NULL);\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h\nindex b24d0c6..3e1f8f6 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h\n@@ -146,5 +146,6 @@ int i40e_ndo_get_vf_config(struct net_device *netdev,\n \n void i40e_vc_notify_link_state(struct i40e_pf *pf);\n void i40e_vc_notify_reset(struct i40e_pf *pf);\n+void i40e_vc_notify_vf_link_state(struct i40e_vf *vf);\n \n #endif /* _I40E_VIRTCHNL_PF_H_ */\n", "prefixes": [ "next-queue", "v6", "3/7" ] }