Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/744339/?format=api
{ "id": 744339, "url": "http://patchwork.ozlabs.org/api/patches/744339/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1490714052-18902-3-git-send-email-clombard@linux.vnet.ibm.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<1490714052-18902-3-git-send-email-clombard@linux.vnet.ibm.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/1490714052-18902-3-git-send-email-clombard@linux.vnet.ibm.com/", "date": "2017-03-28T15:14:07", "name": "[V3,2/7] cxl: Remove unused values in bare-metal environment.", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "2d1f55d1e28d24c3a6079925e05628ebbf7ed274", "submitter": { "id": 67351, "url": "http://patchwork.ozlabs.org/api/people/67351/?format=api", "name": "Christophe Lombard", "email": "clombard@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1490714052-18902-3-git-send-email-clombard@linux.vnet.ibm.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/744339/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/744339/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vsvfM5Dvgz9s2P\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 29 Mar 2017 02:18:03 +1100 (AEDT)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3vsvfM49tWzDqc4\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 29 Mar 2017 02:18:03 +1100 (AEDT)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3vsvbX4393zDqY6\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tWed, 29 Mar 2017 02:14:55 +1100 (AEDT)", "from pps.filterd (m0098404.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id\n\tv2SFE3rs023945\n\tfor <linuxppc-dev@lists.ozlabs.org>; Tue, 28 Mar 2017 11:14:48 -0400", "from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 29ft6f8fa0-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <linuxppc-dev@lists.ozlabs.org>; Tue, 28 Mar 2017 11:14:48 -0400", "from localhost\n\tby e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <linuxppc-dev@lists.ozlabs.org> from\n\t<clombard@linux.vnet.ibm.com>; Tue, 28 Mar 2017 16:14:45 +0100", "from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196)\n\tby e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 28 Mar 2017 16:14:43 +0100", "from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com\n\t[9.149.105.232])\n\tby b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v2SFEH3l40632502; Tue, 28 Mar 2017 15:14:17 GMT", "from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id E3EDA5204E;\n\tTue, 28 Mar 2017 15:12:31 +0100 (BST)", "from lombard-w520.ibm.com (unknown [9.167.235.7])\n\tby d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 64B2852051; \n\tTue, 28 Mar 2017 15:12:31 +0100 (BST)" ], "From": "Christophe Lombard <clombard@linux.vnet.ibm.com>", "To": "linuxppc-dev@lists.ozlabs.org, fbarrat@linux.vnet.ibm.com,\n\timunsie@au1.ibm.com, andrew.donnellan@au1.ibm.com", "Subject": "[PATCH V3 2/7] cxl: Remove unused values in bare-metal environment.", "Date": "Tue, 28 Mar 2017 17:14:07 +0200", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1490714052-18902-1-git-send-email-clombard@linux.vnet.ibm.com>", "References": "<1490714052-18902-1-git-send-email-clombard@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17032815-0012-0000-0000-000004F70C48", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17032815-0013-0000-0000-000017CE6146", "Message-Id": "<1490714052-18902-3-git-send-email-clombard@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-03-28_12:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001\n\tdefinitions=main-1703280131", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "The two fields pid and tid of the structure cxl_irq_info are only used\nin the guest environment. To avoid confusion, it's not necessary\nto fill the fields in the bare-metal environment. These two fields\nare renamed to 'reserved' to avoid undefined behavior on bare-metal.\nThe PSL Process and Thread Identification Register (CXL_PSL_PID_TID_An)\nis only used when attaching a dedicated process for PSL8 only. This\nregister goes away in CAIA2.\n\nSigned-off-by: Christophe Lombard <clombard@linux.vnet.ibm.com>\n---\n drivers/misc/cxl/cxl.h | 13 +++++++------\n drivers/misc/cxl/hcalls.c | 4 ++--\n drivers/misc/cxl/native.c | 5 -----\n 3 files changed, 9 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/misc/cxl/cxl.h b/drivers/misc/cxl/cxl.h\nindex 79e60ec..2bbe077 100644\n--- a/drivers/misc/cxl/cxl.h\n+++ b/drivers/misc/cxl/cxl.h\n@@ -895,19 +895,20 @@ int __detach_context(struct cxl_context *ctx);\n * plpar_hcall9() in hvCall.S\n * As a consequence:\n * - we don't need to do any endianness conversion\n- * - the pid and tid are an exception. They are 32-bit values returned in\n- * the same 64-bit register. So we do need to worry about byte ordering.\n+ * - the pid (reserved0) and tid (reserved1) are an exception. They are\n+ * 32-bit values returned in the same 64-bit register. So we do need\n+ * to worry about byte ordering.\n */\n struct cxl_irq_info {\n \tu64 dsisr;\n \tu64 dar;\n \tu64 dsr;\n #ifndef CONFIG_CPU_LITTLE_ENDIAN\n-\tu32 pid;\n-\tu32 tid;\n+\tu32 reserved0;\n+\tu32 reserved1;\n #else\n-\tu32 tid;\n-\tu32 pid;\n+\tu32 reserved1;\n+\tu32 reserved0;\n #endif\n \tu64 afu_err;\n \tu64 errstat;\ndiff --git a/drivers/misc/cxl/hcalls.c b/drivers/misc/cxl/hcalls.c\nindex d6d11f4..142a095 100644\n--- a/drivers/misc/cxl/hcalls.c\n+++ b/drivers/misc/cxl/hcalls.c\n@@ -414,8 +414,8 @@ long cxl_h_collect_int_info(u64 unit_address, u64 process_token,\n \tswitch (rc) {\n \tcase H_SUCCESS: /* The interrupt info is returned in return registers. */\n \t\tpr_devel(\"dsisr:%#llx, dar:%#llx, dsr:%#llx, pid:%u, tid:%u, afu_err:%#llx, errstat:%#llx\\n\",\n-\t\t\tinfo->dsisr, info->dar, info->dsr, info->pid,\n-\t\t\tinfo->tid, info->afu_err, info->errstat);\n+\t\t\tinfo->dsisr, info->dar, info->dsr, info->reserved0,\n+\t\t\tinfo->reserved1, info->afu_err, info->errstat);\n \t\treturn 0;\n \tcase H_PARAMETER: /* An incorrect parameter was supplied. */\n \t\treturn -EINVAL;\ndiff --git a/drivers/misc/cxl/native.c b/drivers/misc/cxl/native.c\nindex 7ae7105..7257e8b 100644\n--- a/drivers/misc/cxl/native.c\n+++ b/drivers/misc/cxl/native.c\n@@ -859,8 +859,6 @@ static int native_detach_process(struct cxl_context *ctx)\n \n static int native_get_irq_info(struct cxl_afu *afu, struct cxl_irq_info *info)\n {\n-\tu64 pidtid;\n-\n \t/* If the adapter has gone away, we can't get any meaningful\n \t * information.\n \t */\n@@ -870,9 +868,6 @@ static int native_get_irq_info(struct cxl_afu *afu, struct cxl_irq_info *info)\n \tinfo->dsisr = cxl_p2n_read(afu, CXL_PSL_DSISR_An);\n \tinfo->dar = cxl_p2n_read(afu, CXL_PSL_DAR_An);\n \tinfo->dsr = cxl_p2n_read(afu, CXL_PSL_DSR_An);\n-\tpidtid = cxl_p2n_read(afu, CXL_PSL_PID_TID_An);\n-\tinfo->pid = pidtid >> 32;\n-\tinfo->tid = pidtid & 0xffffffff;\n \tinfo->afu_err = cxl_p2n_read(afu, CXL_AFU_ERR_An);\n \tinfo->errstat = cxl_p2n_read(afu, CXL_PSL_ErrStat_An);\n \tinfo->proc_handle = 0;\n", "prefixes": [ "V3", "2/7" ] }