Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/741302/?format=api
{ "id": 741302, "url": "http://patchwork.ozlabs.org/api/patches/741302/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170320234535.27900-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170320234535.27900-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2017-03-20T23:45:35", "name": "i40e: initialize params before notifying of l2_param_changes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dd604140f3a566e86ceecbc0baa5c3cc4200f4e6", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170320234535.27900-1-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/741302/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/741302/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vnCHq5MRgz9s3l\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 21 Mar 2017 10:45:43 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 45FE187D94;\n\tMon, 20 Mar 2017 23:45:42 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2W1tsS0AtEOq; Mon, 20 Mar 2017 23:45:40 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C51C787CAC;\n\tMon, 20 Mar 2017 23:45:40 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 585BE1C2A69\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Mar 2017 23:45:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5044287C4E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Mar 2017 23:45:39 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id r6A7ozLIFmy0 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Mar 2017 23:45:37 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id BB05181D4C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Mar 2017 23:45:37 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Mar 2017 16:45:37 -0700", "from jekeller-desk.amr.corp.intel.com ([10.166.35.174])\n\tby orsmga001.jf.intel.com with ESMTP; 20 Mar 2017 16:45:36 -0700" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"CUp/EYPh\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=intel;\n\tt=1490053537; x=1521589537;\n\th=from:to:cc:subject:date:message-id;\n\tbh=LbeghES8SKLms+dj4f5NAizIxf5NSapWlg3Fp3PkWCQ=;\n\tb=CUp/EYPh3esjbaGTaVg0BbYutmUM8T7huXbEzev0hoKEP76SYX+bQukt\n\ty+RjbFusFrJvc36KUO9wj0wHZG/Wcw==;", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.36,196,1486454400\"; d=\"scan'208\";\n\ta=\"1110500999\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>,\n\tColin Ian King <colin.king@canonical.com>", "Date": "Mon, 20 Mar 2017 16:45:35 -0700", "Message-Id": "<20170320234535.27900-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.12.0.rc1.272.g5157a0d593b8", "Subject": "[Intel-wired-lan] [PATCH] i40e: initialize params before notifying\n\tof l2_param_changes", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Probably due to some mis-merging fix a bug associated with commits\nd7ce6422d6e6 (\"i40e: don't check params until after checking for client\ninstance\", 2017-02-09) and 3140aa9a78c9 (\"i40e: KISS the client\ninterface\", 2017-03-14)\n\nThe first commit tried to move the initialization of the params\nstructure so that we didn't bother doing this if we didn't have a client\ninterface. You can already see that it looks fishy because of the\nindentation. The second commit refactors a bunch of the interface, and\nincorrectly drops the params initialization.\n\nI believe what occurred is that internally the two patches were\nre-ordered, and the merge conflicts as a result were performed\nincorrectly.\n\nFix the use of an uninitialized variable by correctly initializing the\nparams variable via i40e_client_get_params().\n\nReported-by: Colin Ian King <colin.king@canonical.com>\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_client.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/intel/i40e/i40e_client.c\nindex 191580ed946d..725017892f4f 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_client.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_client.c\n@@ -147,6 +147,8 @@ void i40e_notify_client_of_l2_param_changes(struct i40e_vsi *vsi)\n \t\tdev_dbg(&vsi->back->pdev->dev, \"Client is not open, abort l2 param change\\n\");\n \t\treturn;\n \t}\n+\tmemset(¶ms, 0, sizeof(params));\n+\ti40e_client_get_params(vsi, ¶ms);\n \tmemcpy(¶ms, &cdev->lan_info.params, sizeof(struct i40e_params));\n \tcdev->client->ops->l2_param_change(&cdev->lan_info, cdev->client,\n \t\t\t\t\t ¶ms);\n", "prefixes": [] }