Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/740989/?format=api
{ "id": 740989, "url": "http://patchwork.ozlabs.org/api/patches/740989/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170320120303.32284-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170320120303.32284-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2017-03-20T12:03:03", "name": "i40evf: dereference vsi after vsi has been null checked", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "85355ed84d14afc7a1a00506dc62670437a11f5f", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170320120303.32284-1-colin.king@canonical.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/740989/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/740989/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vmvjG2PRZz9s3w\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 20 Mar 2017 23:03:13 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BB5788585C;\n\tMon, 20 Mar 2017 12:03:11 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FCb+TTRGULFV; Mon, 20 Mar 2017 12:03:09 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id CC4518583D;\n\tMon, 20 Mar 2017 12:03:09 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id A16131C0906\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Mar 2017 12:03:08 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9D08284941\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Mar 2017 12:03:08 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id pYy0gI+PfoMv for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Mar 2017 12:03:07 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 934D58583D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Mar 2017 12:03:07 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1cpw1f-0005ko-OK; Mon, 20 Mar 2017 12:03:03 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Mon, 20 Mar 2017 12:03:03 +0000", "Message-Id": "<20170320120303.32284-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.11.0", "MIME-Version": "1.0", "Cc": "kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] i40evf: dereference vsi after vsi has\n\tbeen null checked", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nvsi is being dereferenced before the vsi null check; if vsi is\nnull we end up with a null pointer dereference. Fix this by\nperforming vsi deference after the vsi null check. Also remove\nthe need for using adapter by using vsi->back->cinst.\n\nDetected by CoverityScan, CID#1419696, CID#1419697\n(\"Dereference before null check\")\n\nFixes: ed0e894de7c133 (\"i40evf: add client interface\")\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf_client.c | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_client.c b/drivers/net/ethernet/intel/i40evf/i40evf_client.c\nindex 5b43e5b6e2eb..a579b2a5bd37 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_client.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_client.c\n@@ -34,12 +34,12 @@ static struct i40e_ops i40evf_lan_ops = {\n **/\n void i40evf_notify_client_message(struct i40e_vsi *vsi, u8 *msg, u16 len)\n {\n-\tstruct i40evf_adapter *adapter = vsi->back;\n-\tstruct i40e_client_instance *cinst = adapter->cinst;\n+\tstruct i40e_client_instance *cinst;\n \n \tif (!vsi)\n \t\treturn;\n \n+\tcinst = vsi->back->cinst;\n \tif (!cinst || !cinst->client || !cinst->client->ops ||\n \t !cinst->client->ops->virtchnl_receive) {\n \t\tdev_dbg(&vsi->back->pdev->dev,\n@@ -58,12 +58,13 @@ void i40evf_notify_client_message(struct i40e_vsi *vsi, u8 *msg, u16 len)\n **/\n void i40evf_notify_client_l2_params(struct i40e_vsi *vsi)\n {\n-\tstruct i40evf_adapter *adapter = vsi->back;\n-\tstruct i40e_client_instance *cinst = adapter->cinst;\n+\tstruct i40e_client_instance *cinst;\n \tstruct i40e_params params;\n \n \tif (!vsi)\n \t\treturn;\n+\n+\tcinst = vsi->back->cinst;\n \tmemset(¶ms, 0, sizeof(params));\n \tparams.mtu = vsi->netdev->mtu;\n \tparams.link_up = vsi->back->link_up;\n", "prefixes": [] }