Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/737548/?format=api
{ "id": 737548, "url": "http://patchwork.ozlabs.org/api/patches/737548/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1489177325-13156-6-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1489177325-13156-6-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2017-03-10T20:22:04", "name": "[next,S62,5/6] i40e: remove a useless goto statement", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "10a24b7222a9502896d1b6956c159d2722cc6de2", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1489177325-13156-6-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/737548/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/737548/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vfxyv0p5Jz9s7k\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 11 Mar 2017 06:24:23 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id F2F0D89CBD;\n\tFri, 10 Mar 2017 19:24:20 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id uZIf+-BYExVe; Fri, 10 Mar 2017 19:24:20 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 14F7889DF4;\n\tFri, 10 Mar 2017 19:24:18 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 33B701C0169\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Mar 2017 19:24:17 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2E8A323B10\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Mar 2017 19:24:17 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tdEDoqZEYXGI for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Mar 2017 19:24:14 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby silver.osuosl.org (Postfix) with ESMTPS id CE5A0230FE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Mar 2017 19:24:14 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t10 Mar 2017 11:24:13 -0800", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([10.166.35.87])\n\tby orsmga001.jf.intel.com with ESMTP; 10 Mar 2017 11:24:12 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.36,142,1486454400\"; d=\"scan'208\";\n\ta=\"1107116176\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 10 Mar 2017 12:22:04 -0800", "Message-Id": "<1489177325-13156-6-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1489177325-13156-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1489177325-13156-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S62 5/6] i40e: remove a useless goto\n\tstatement", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nThe goto found here for when in MFP mode is pointless. It jumps to the\nend of a series of if blocks. However, right after this statement is\na closing '}' for this if block, which will result in the program flow\ngoing to the exact same location as the goto statement indicates. Thus,\nregardless of whether we are in MFP mode, the program flow will resume\nfrom the same location.\n\nThis arose due to various refactoring which did not notice that this\ngoto became essentially a no-op.\n\nTo properly understand this diff you will need to view a larger context\nthan is given by default.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nChange-ID: I088f73c3831aa5c4e2281380c7a3ce605594300c\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex bab9337..4cfe9491 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -5175,10 +5175,6 @@ static int i40e_init_pf_dcb(struct i40e_pf *pf)\n \t\t (hw->dcbx_status == I40E_DCBX_STATUS_DISABLED)) {\n \t\t\tdev_info(&pf->pdev->dev,\n \t\t\t\t \"DCBX offload is not supported or is disabled for this PF.\\n\");\n-\n-\t\t\tif (pf->flags & I40E_FLAG_MFP_ENABLED)\n-\t\t\t\tgoto out;\n-\n \t\t} else {\n \t\t\t/* When status is not DISABLED then DCBX in FW */\n \t\t\tpf->dcbx_cap = DCB_CAP_DCBX_LLD_MANAGED |\n", "prefixes": [ "next", "S62", "5/6" ] }