Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/736767/?format=api
{ "id": 736767, "url": "http://patchwork.ozlabs.org/api/patches/736767/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170308235543.16537-2-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170308235543.16537-2-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2017-03-08T23:55:43", "name": "[2/2] fm10k: reschedule service event if we stall the PF<->SM mailbox", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9bc73edb373f440c5af94ae3b4194025484dc2b4", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170308235543.16537-2-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/736767/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/736767/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vdr523JJ0z9s7q\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 9 Mar 2017 10:55:50 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 855328982C;\n\tWed, 8 Mar 2017 23:55:48 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 57EJ7nzn9Uj1; Wed, 8 Mar 2017 23:55:47 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D153C897B0;\n\tWed, 8 Mar 2017 23:55:47 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 88AC41C02FC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 8 Mar 2017 23:55:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 82E6389F1B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 8 Mar 2017 23:55:47 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4eZzODAJC+dw for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 8 Mar 2017 23:55:46 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 7B09E89EFB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 8 Mar 2017 23:55:46 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Mar 2017 15:55:45 -0800", "from jekeller-desk.amr.corp.intel.com ([10.166.35.174])\n\tby fmsmga005.fm.intel.com with ESMTP; 08 Mar 2017 15:55:45 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.36,265,1486454400\"; d=\"scan'208\";a=\"73909748\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Wed, 8 Mar 2017 15:55:43 -0800", "Message-Id": "<20170308235543.16537-2-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.12.0.rc1.272.g5157a0d593b8", "In-Reply-To": "<20170308235543.16537-1-jacob.e.keller@intel.com>", "References": "<20170308235543.16537-1-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [PATCH 2/2] fm10k: reschedule service event if we\n\tstall the PF<->SM mailbox", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "When we are handling PF<->VF mailbox messages, it is possible that the\nVF will send us so many messages that the PF<->SM FIFO will fill up. In\nthis case, we stop the loop and wait until the service event is\nrescheduled.\n\nNormally this should happen due to an interrupt. But it is possible that\nwe don't get another interrupt for a while and it isn't until the\nservice timer actually reschedules us. Instead, simply reschedule\nimmediately which will cause the service event to be run again as soon\nas we exit.\n\nThis ensures that we promptly handle all of the PF<->VF messages with\nminimal delay, while still giving time for the SM mailbox to drain.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_iov.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_iov.c b/drivers/net/ethernet/intel/fm10k/fm10k_iov.c\nindex 2ec49116fe91..d8356c494f06 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_iov.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_iov.c\n@@ -143,6 +143,10 @@ s32 fm10k_iov_mbx(struct fm10k_intfc *interface)\n \t\tif (!hw->mbx.ops.tx_ready(&hw->mbx, FM10K_VFMBX_MSG_MTU)) {\n \t\t\t/* keep track of how many times this occurs */\n \t\t\tinterface->hw_sm_mbx_full++;\n+\n+\t\t\t/* make sure we try again momentarily */\n+\t\t\tfm10k_service_event_schedule(interface);\n+\n \t\t\tbreak;\n \t\t}\n \n", "prefixes": [ "2/2" ] }