Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/736395/?format=api
{ "id": 736395, "url": "http://patchwork.ozlabs.org/api/patches/736395/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170307231752.21671-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170307231752.21671-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2017-03-07T23:17:52", "name": "i40e: make use of hlist_for_each_entry_continue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0cf0c195e2e3bcdd992e58f5e944eb5531800bc3", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170307231752.21671-1-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/736395/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/736395/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vdCHr3LyNz9sNJ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 8 Mar 2017 10:18:00 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E97392E5D4;\n\tTue, 7 Mar 2017 23:17:58 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jSVyEGL5vyi7; Tue, 7 Mar 2017 23:17:57 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 184452E7B6;\n\tTue, 7 Mar 2017 23:17:57 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id F217F1C05CE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Mar 2017 23:17:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DAFA789574\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Mar 2017 23:17:54 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TzdPKVebkpYJ for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Mar 2017 23:17:54 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 195DD89571\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Mar 2017 23:17:54 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga104.jf.intel.com with ESMTP; 07 Mar 2017 15:17:53 -0800", "from jekeller-desk.amr.corp.intel.com ([10.166.35.174])\n\tby orsmga003.jf.intel.com with ESMTP; 07 Mar 2017 15:17:53 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.36,260,1486454400\"; d=\"scan'208\";a=\"941768232\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Tue, 7 Mar 2017 15:17:52 -0800", "Message-Id": "<20170307231752.21671-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.12.0.rc1.272.g5157a0d593b8", "Subject": "[Intel-wired-lan] [PATCH] i40e: make use of\n\thlist_for_each_entry_continue", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Replace a complex if->continue->else->break construction in\ni40e_next_filter. We can simply use hlist_for_each_entry_continue\ninstead. This drops a lot of confusing code. The resulting code is much\neasier to understand the intention, and follows the more normal pattern\nfor using hlist loops. We could have also used a break with a \"return\nnext\" at the end of the function, instead of return NULL, but the\ncurrent implementation is explicitly clear that when you reach the end\nof the loop you get a NULL value. The alternative construction is less\nclear since the reader would have to know that next is NULL at the end\nof the loop.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nChange-Id: Ife74ca451dd79d7f0d93c672bd42092d324d4a03\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 15 ++++-----------\n 1 file changed, 4 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 836ce939e65b..1e0acf764c79 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1817,19 +1817,12 @@ static void i40e_undo_add_filter_entries(struct i40e_vsi *vsi,\n static\n struct i40e_new_mac_filter *i40e_next_filter(struct i40e_new_mac_filter *next)\n {\n-\twhile (next) {\n-\t\tnext = hlist_entry(next->hlist.next,\n-\t\t\t\t typeof(struct i40e_new_mac_filter),\n-\t\t\t\t hlist);\n-\n-\t\t/* keep going if we found a broadcast filter */\n-\t\tif (next && is_broadcast_ether_addr(next->f->macaddr))\n-\t\t\tcontinue;\n-\n-\t\tbreak;\n+\thlist_for_each_entry_continue(next, hlist) {\n+\t\tif (!is_broadcast_ether_addr(next->f->macaddr))\n+\t\t\treturn next;\n \t}\n \n-\treturn next;\n+\treturn NULL;\n }\n \n /**\n", "prefixes": [] }