Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/734853/?format=api
{ "id": 734853, "url": "http://patchwork.ozlabs.org/api/patches/734853/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170302230136.8845.40421.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170302230136.8845.40421.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-03-02T23:01:36", "name": "[net] ixgbe: Fix output from ixgbe_dump", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f3b2657021d289876b72d9e3a45b89ca9df38a55", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170302230136.8845.40421.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/734853/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/734853/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vZ79P53Sjz9s7n\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 3 Mar 2017 10:01:45 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E31A988D98;\n\tThu, 2 Mar 2017 23:01:43 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3BHb66hKwCs2; Thu, 2 Mar 2017 23:01:43 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0A19088D73;\n\tThu, 2 Mar 2017 23:01:43 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2B7971C26EA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Mar 2017 23:01:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D5B6930D72\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Mar 2017 23:01:40 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AYDq8wLvlvBz for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Mar 2017 23:01:37 +0000 (UTC)", "from mail-pf0-f194.google.com (mail-pf0-f194.google.com\n\t[209.85.192.194])\n\tby silver.osuosl.org (Postfix) with ESMTPS id AE16725E0B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Mar 2017 23:01:37 +0000 (UTC)", "by mail-pf0-f194.google.com with SMTP id e66so2334437pfe.0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 02 Mar 2017 15:01:37 -0800 (PST)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\tv186sm19141805pgv.44.2017.03.02.15.01.36\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 02 Mar 2017 15:01:36 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"DYpM323V\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:date:message-id:user-agent:mime-version\n\t:content-transfer-encoding;\n\tbh=YPLL8zeJqYWHJjl92gDtsthn/jRJ0zNMt7YLLhMAUEo=;\n\tb=DYpM323VB2bdcsuVVAGjK2LyfFOedPb/ii/vrUiwJRdD2oqqGX+nnQBwNd0Yolyw2e\n\tSr2vpxuEyPjTV7rxhk0VnAjNljYk+2Oq2H6T3Bzy0Spegki8CMj73kwiNVKNM2CIdJrB\n\tgvf5kBMv782Vt6+nUyV6+uv9hMFeLJC2DPapBVotKzCCj/szZcKsMYQMyhMP7YlPbMha\n\t19Mcng2c6LV2vkecW7AapjmqCIkAJrcn728AHBd/Q4VtBjUHAhE6aI0vAEyxuuuQ6md6\n\t29l1yjbf8QZPrVTpAsjpdIbmVAyPoJV0szriiE94ULuOpOKTHlgM3T3qvp6dVRlVZVEn\n\th7sg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:date:message-id:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=YPLL8zeJqYWHJjl92gDtsthn/jRJ0zNMt7YLLhMAUEo=;\n\tb=KhDRlitY/Kuzl6R4pumF+BrEhVH9gjVK+oY3sJCrIMHIucIAnnSBWEaVUxWeui+bLT\n\tFoqCLg2vXHD4fbl2brVpSShhPLu8nKErthLJMt61fLsOMvMl9xcYiMGH1EbxSih97z3B\n\tmgfmBBgGjG4SjPhzW3H+zYbhfVdV9JBzW6MiREtUqIAwpbK3u/mGXmUHM2t5OsFmSEnl\n\t8t9jvYA48KfULXb+d1wYknK9ES8svQX88DghZz0mQP1687JQEVyQc18l16f2FimwhK5F\n\tF8ohdqGGj63S22Ln1xBJKuxor/mf96Da90aepf5W5cP7Ezzc+Q4HIly6/VQcMbFJzAPI\n\tqn8w==", "X-Gm-Message-State": "AMke39nE4hSu6bz32RtOfYlQar+rsup2howjTFAk6IJRfuy9L7UjVND5N1eDM678fvKDyg==", "X-Received": "by 10.84.168.131 with SMTP id f3mr22259853plb.163.1488495697264; \n\tThu, 02 Mar 2017 15:01:37 -0800 (PST)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Thu, 02 Mar 2017 15:01:36 -0800", "Message-ID": "<20170302230136.8845.40421.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [net PATCH] ixgbe: Fix output from ixgbe_dump", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nI just found that when we had changed the Rx path to check for length\ninstead of the DD bit we introduced an issue in ixgbe_dump since we were no\nlonger clearing the status bits.\n\nTo correct this I am updating ixgbe_dump to look for the length bits in the\ndescriptor since that is what we are using in the Rx path.\n\nFixes: c3630cc40b4f (\"ixgbe: Use length to determine if descriptor is done\")\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex a922a2c2e4b6..b58f4b255e4e 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -601,7 +601,6 @@ static void ixgbe_dump(struct ixgbe_adapter *adapter)\n \tstruct ixgbe_ring *rx_ring;\n \tunion ixgbe_adv_rx_desc *rx_desc;\n \tstruct ixgbe_rx_buffer *rx_buffer_info;\n-\tu32 staterr;\n \tint i = 0;\n \n \tif (!netif_msg_hw(adapter))\n@@ -810,8 +809,7 @@ static void ixgbe_dump(struct ixgbe_adapter *adapter)\n \t\t\trx_buffer_info = &rx_ring->rx_buffer_info[i];\n \t\t\trx_desc = IXGBE_RX_DESC(rx_ring, i);\n \t\t\tu0 = (struct my_u0 *)rx_desc;\n-\t\t\tstaterr = le32_to_cpu(rx_desc->wb.upper.status_error);\n-\t\t\tif (staterr & IXGBE_RXD_STAT_DD) {\n+\t\t\tif (rx_desc->wb.upper.length) {\n \t\t\t\t/* Descriptor Done */\n \t\t\t\tpr_info(\"RWB[0x%03X] %016llX \"\n \t\t\t\t\t\"%016llX ---------------- %p\", i,\n", "prefixes": [ "net" ] }