Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/730829/?format=api
{ "id": 730829, "url": "http://patchwork.ozlabs.org/api/patches/730829/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1487721348-25617-9-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1487721348-25617-9-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2017-02-21T23:55:46", "name": "[next,S61,08/10] i40e/i40evf: Clean-up process_skb_fields", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "69625978f89276468456d69b3c68e6d77e656bff", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1487721348-25617-9-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/730829/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/730829/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vSbWM3VBqz9s65\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 22 Feb 2017 09:58:07 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DF2C18B0A2;\n\tTue, 21 Feb 2017 22:58:05 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id QUhkNdaUlMu4; Tue, 21 Feb 2017 22:58:04 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2E3878A67C;\n\tTue, 21 Feb 2017 22:58:04 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 777751BFF60\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 21 Feb 2017 22:58:00 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 70CED8ACAC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 21 Feb 2017 22:58:00 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SYEx64mZq2Fz for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 21 Feb 2017 22:57:56 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id C35DC8A521\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 21 Feb 2017 22:57:56 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Feb 2017 14:57:55 -0800", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([10.166.35.87])\n\tby fmsmga002.fm.intel.com with ESMTP; 21 Feb 2017 14:57:55 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.35,191,1484035200\"; d=\"scan'208\";\n\ta=\"1133083145\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 21 Feb 2017 15:55:46 -0800", "Message-Id": "<1487721348-25617-9-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1487721348-25617-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1487721348-25617-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S61 08/10] i40e/i40evf: Clean-up\n\tprocess_skb_fields", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThis is a minor clean-up to make the i40e/i40evf process_skb_fields\nfunction look a little more like what we have in igb. The Rx checksum\nfunction called out a need for skb->protocol but I can't see where it\nactually needs it. I am assuming this is something that was likely\nrefactored out some time ago as the Rx checksum code has gone through a few\nrewrites.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\nChange-ID: I0b4668a34d90b61b66ded7c7c26e19a3e2d06251\n---\nTesting Hints:\n Basically just need to verify this builds and processes Rx\n checksums correctly.\n\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 8 +++-----\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 8 +++-----\n 2 files changed, 6 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex 558d7da..a540754 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -1431,8 +1431,6 @@ bool i40e_alloc_rx_buffers(struct i40e_ring *rx_ring, u16 cleaned_count)\n * @vsi: the VSI we care about\n * @skb: skb currently being received and modified\n * @rx_desc: the receive descriptor\n- *\n- * skb->protocol must be set before this function is called\n **/\n static inline void i40e_rx_checksum(struct i40e_vsi *vsi,\n \t\t\t\t struct sk_buff *skb,\n@@ -1598,12 +1596,12 @@ void i40e_process_skb_fields(struct i40e_ring *rx_ring,\n \n \ti40e_rx_hash(rx_ring, rx_desc, skb, rx_ptype);\n \n-\t/* modifies the skb - consumes the enet header */\n-\tskb->protocol = eth_type_trans(skb, rx_ring->netdev);\n-\n \ti40e_rx_checksum(rx_ring->vsi, skb, rx_desc);\n \n \tskb_record_rx_queue(skb, rx_ring->queue_index);\n+\n+\t/* modifies the skb - consumes the enet header */\n+\tskb->protocol = eth_type_trans(skb, rx_ring->netdev);\n }\n \n /**\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex 9b9314a..7f02f62 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -764,8 +764,6 @@ bool i40evf_alloc_rx_buffers(struct i40e_ring *rx_ring, u16 cleaned_count)\n * @vsi: the VSI we care about\n * @skb: skb currently being received and modified\n * @rx_desc: the receive descriptor\n- *\n- * skb->protocol must be set before this function is called\n **/\n static inline void i40e_rx_checksum(struct i40e_vsi *vsi,\n \t\t\t\t struct sk_buff *skb,\n@@ -917,12 +915,12 @@ void i40evf_process_skb_fields(struct i40e_ring *rx_ring,\n {\n \ti40e_rx_hash(rx_ring, rx_desc, skb, rx_ptype);\n \n-\t/* modifies the skb - consumes the enet header */\n-\tskb->protocol = eth_type_trans(skb, rx_ring->netdev);\n-\n \ti40e_rx_checksum(rx_ring->vsi, skb, rx_desc);\n \n \tskb_record_rx_queue(skb, rx_ring->queue_index);\n+\n+\t/* modifies the skb - consumes the enet header */\n+\tskb->protocol = eth_type_trans(skb, rx_ring->netdev);\n }\n \n /**\n", "prefixes": [ "next", "S61", "08/10" ] }