Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/730823/?format=api
{ "id": 730823, "url": "http://patchwork.ozlabs.org/api/patches/730823/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1487721348-25617-3-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1487721348-25617-3-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2017-02-21T23:55:40", "name": "[next,S61,02/10] i40e: fix configuration of RSS table with DCB", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "73d89b4cce402fb3b9f64872730c2ea493dac741", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1487721348-25617-3-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/730823/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/730823/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vSbWH1Rxzz9s7D\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 22 Feb 2017 09:58:02 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 46DE88A60F;\n\tTue, 21 Feb 2017 22:58:00 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wS+G5Dm0H6pS; Tue, 21 Feb 2017 22:57:58 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0865E8A6BB;\n\tTue, 21 Feb 2017 22:57:58 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 83ECF1BFF60\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 21 Feb 2017 22:57:56 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7EF238A698\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 21 Feb 2017 22:57:56 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CjhlwPJd13bR for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 21 Feb 2017 22:57:55 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id A73138A521\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 21 Feb 2017 22:57:55 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Feb 2017 14:57:54 -0800", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([10.166.35.87])\n\tby fmsmga002.fm.intel.com with ESMTP; 21 Feb 2017 14:57:54 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.35,191,1484035200\"; d=\"scan'208\";\n\ta=\"1133083128\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 21 Feb 2017 15:55:40 -0800", "Message-Id": "<1487721348-25617-3-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1487721348-25617-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1487721348-25617-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S61 02/10] i40e: fix configuration of\n\tRSS table with DCB", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>\n\nThere exists a bug in the driver where the calculation of the\nRSS size was not taking into account the number of traffic classes\nenabled. This patch factors in the traffic classes both in\nthe initial configuration of the table as well as reconfiguration.\n\nSigned-off-by: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>\nChange-ID: I34dcd345ce52faf1d6b9614bea28d450cfd5f621\n---\nTesting Hints: Change the number of queues and RSS hash table via\nethtool and ensure that no packets are dropped.\n\n drivers/net/ethernet/intel/i40e/i40e_main.c | 15 ++++++++++-----\n 1 file changed, 10 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex d587237..db09914 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -8733,9 +8733,12 @@ static int i40e_pf_config_rss(struct i40e_pf *pf)\n \ti40e_write_rx_ctl(hw, I40E_PFQF_CTL_0, reg_val);\n \n \t/* Determine the RSS size of the VSI */\n-\tif (!vsi->rss_size)\n-\t\tvsi->rss_size = min_t(int, pf->alloc_rss_size,\n-\t\t\t\t vsi->num_queue_pairs);\n+\tif (!vsi->rss_size) {\n+\t\tu16 qcount;\n+\n+\t\tqcount = vsi->num_queue_pairs / vsi->tc_config.numtc;\n+\t\tvsi->rss_size = min_t(int, pf->alloc_rss_size, qcount);\n+\t}\n \tif (!vsi->rss_size)\n \t\treturn -EINVAL;\n \n@@ -8781,6 +8784,8 @@ int i40e_reconfig_rss_queues(struct i40e_pf *pf, int queue_count)\n \tnew_rss_size = min_t(int, queue_count, pf->rss_size_max);\n \n \tif (queue_count != vsi->num_queue_pairs) {\n+\t\tu16 qcount;\n+\n \t\tvsi->req_queue_pairs = queue_count;\n \t\ti40e_prep_for_reset(pf);\n \n@@ -8798,8 +8803,8 @@ int i40e_reconfig_rss_queues(struct i40e_pf *pf, int queue_count)\n \t\t}\n \n \t\t/* Reset vsi->rss_size, as number of enabled queues changed */\n-\t\tvsi->rss_size = min_t(int, pf->alloc_rss_size,\n-\t\t\t\t vsi->num_queue_pairs);\n+\t\tqcount = vsi->num_queue_pairs / vsi->tc_config.numtc;\n+\t\tvsi->rss_size = min_t(int, pf->alloc_rss_size, qcount);\n \n \t\ti40e_pf_config_rss(pf);\n \t}\n", "prefixes": [ "next", "S61", "02/10" ] }