Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/728385/?format=api
{ "id": 728385, "url": "http://patchwork.ozlabs.org/api/patches/728385/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170215110811.29976-1-tklauser@distanz.ch/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170215110811.29976-1-tklauser@distanz.ch>", "list_archive_url": null, "date": "2017-02-15T11:08:11", "name": "[net-next] e1000: Omit private ndo_get_stats function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ffd6324621542179d0e2dd37a7db93be45b4c24a", "submitter": { "id": 2451, "url": "http://patchwork.ozlabs.org/api/people/2451/?format=api", "name": "Tobias Klauser", "email": "tklauser@distanz.ch" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170215110811.29976-1-tklauser@distanz.ch/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/728385/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/728385/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vNsCP48X7z9s03\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 16 Feb 2017 08:01:21 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 21AAA85A6E;\n\tWed, 15 Feb 2017 21:01:20 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 29wfjTR-IqDf; Wed, 15 Feb 2017 21:01:17 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id EFC5585A6A;\n\tWed, 15 Feb 2017 21:01:16 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id EF0201C0D29\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 15 Feb 2017 11:08:22 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id ED32085CB5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 15 Feb 2017 11:08:22 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id iUPtwJk-fd9v for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 15 Feb 2017 11:08:22 +0000 (UTC)", "from mail.zhinst.com (mail.zhinst.com [212.126.164.98])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A994686180\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 15 Feb 2017 11:08:21 +0000 (UTC)", "from ziws08.zhinst.com ([10.42.0.7])\n\tby mail.zhinst.com (Kerio Connect 9.2.1) with ESMTP;\n\tWed, 15 Feb 2017 12:08:16 +0100" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Tobias Klauser <tklauser@distanz.ch>", "To": "netdev@vger.kernel.org", "Date": "Wed, 15 Feb 2017 12:08:11 +0100", "Message-Id": "<20170215110811.29976-1-tklauser@distanz.ch>", "X-Mailer": "git-send-email 2.11.0", "X-Mailman-Approved-At": "Wed, 15 Feb 2017 21:01:15 +0000", "Cc": "Joe Perches <joe@perches.com>, intel-wired-lan@lists.osuosl.org", "Subject": "[Intel-wired-lan] [PATCH net-next] e1000: Omit private\n\tndo_get_stats function", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "e1000_get_stats() just returns dev->stats so we can leave it\nout altogether and let dev_get_stats() do the job.\n\nSuggested-by: Joe Perches <joe@perches.com>\nSigned-off-by: Tobias Klauser <tklauser@distanz.ch>\n---\n drivers/net/ethernet/intel/e1000/e1000_main.c | 15 ---------------\n 1 file changed, 15 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c\nindex 93fc6c67306b..bd8b05fe8258 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_main.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c\n@@ -131,7 +131,6 @@ static void e1000_watchdog(struct work_struct *work);\n static void e1000_82547_tx_fifo_stall_task(struct work_struct *work);\n static netdev_tx_t e1000_xmit_frame(struct sk_buff *skb,\n \t\t\t\t struct net_device *netdev);\n-static struct net_device_stats *e1000_get_stats(struct net_device *netdev);\n static int e1000_change_mtu(struct net_device *netdev, int new_mtu);\n static int e1000_set_mac(struct net_device *netdev, void *p);\n static irqreturn_t e1000_intr(int irq, void *data);\n@@ -846,7 +845,6 @@ static const struct net_device_ops e1000_netdev_ops = {\n \t.ndo_open\t\t= e1000_open,\n \t.ndo_stop\t\t= e1000_close,\n \t.ndo_start_xmit\t\t= e1000_xmit_frame,\n-\t.ndo_get_stats\t\t= e1000_get_stats,\n \t.ndo_set_rx_mode\t= e1000_set_rx_mode,\n \t.ndo_set_mac_address\t= e1000_set_mac,\n \t.ndo_tx_timeout\t\t= e1000_tx_timeout,\n@@ -3530,19 +3528,6 @@ static void e1000_reset_task(struct work_struct *work)\n }\n \n /**\n- * e1000_get_stats - Get System Network Statistics\n- * @netdev: network interface device structure\n- *\n- * Returns the address of the device statistics structure.\n- * The statistics are actually updated from the watchdog.\n- **/\n-static struct net_device_stats *e1000_get_stats(struct net_device *netdev)\n-{\n-\t/* only return the current stats */\n-\treturn &netdev->stats;\n-}\n-\n-/**\n * e1000_change_mtu - Change the Maximum Transfer Unit\n * @netdev: network interface device structure\n * @new_mtu: new value for maximum frame size\n", "prefixes": [ "net-next" ] }