Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/728307/?format=api
{ "id": 728307, "url": "http://patchwork.ozlabs.org/api/patches/728307/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170215171559.4456.38581.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170215171559.4456.38581.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-02-15T17:15:59", "name": "[next] igb/ixgbe: Fix typo in igb_build_skb and/or ixgbe_build_skb code comment", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d7246cffb10492ed3913369f7391640c836624d0", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170215171559.4456.38581.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/728307/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/728307/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vNmCb007fz9s2G\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 16 Feb 2017 04:16:10 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 07E6C2FBB6;\n\tWed, 15 Feb 2017 17:16:09 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kQRdtNZI2bXM; Wed, 15 Feb 2017 17:16:04 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 03DA72FB0F;\n\tWed, 15 Feb 2017 17:16:04 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0CFA71BFF5F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 15 Feb 2017 17:16:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0557E84479\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 15 Feb 2017 17:16:02 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id I4n3EwNEPveF for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 15 Feb 2017 17:16:01 +0000 (UTC)", "from mail-pf0-f193.google.com (mail-pf0-f193.google.com\n\t[209.85.192.193])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 5C5A5841E7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 15 Feb 2017 17:16:01 +0000 (UTC)", "by mail-pf0-f193.google.com with SMTP id o64so8195912pfb.1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 15 Feb 2017 09:16:01 -0800 (PST)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\th14sm8711167pgn.41.2017.02.15.09.16.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 15 Feb 2017 09:16:00 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Li4VwH9y\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:date:message-id:user-agent:mime-version\n\t:content-transfer-encoding;\n\tbh=IY9KuLJ3s8W/TmsSNFBH+FT1Jo6qYdDcgOUVA0OAXfo=;\n\tb=Li4VwH9yXU2a4LmnUHyzEw3eZQJcftC56CRXLWKWXAleUav6mtGBc7uAuAfDuMqW4B\n\tZFM0M/1q6es19UTkP57ge3ka3kIib7it2MC+jG9ki+J6pmZnuZfaNigCEOHp0lgYKj5z\n\tVuOoHPh8BUWAy3tU5khtiIwrNmGaiPwnARlPPzalQYlCJXPFgu8N+7JZ9F1p9H8psNiW\n\tTqsbjKo7uJMaSphFsCf4ewI4T0LLYY/h/U3JTxGGPS0k6sqw0UiP27UHtPlTOU1iWepe\n\tCYvahnwF1hx2xSw2wlE5+B7/NGIMCLtGjvrkGiBKpQAa9F1w4ir3YkQhPBn7W0lc6+D4\n\tW3WA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:date:message-id:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=IY9KuLJ3s8W/TmsSNFBH+FT1Jo6qYdDcgOUVA0OAXfo=;\n\tb=nROuSWtXrMQ0EFubRgtRyvm4sEdVUnnCbqBrGusGot1FsCOI4dT7+bGtyfmomYm8R0\n\tpdw07x0xsVWq7Mr3bl9dhdNv+pIImuaL3selxAAmcJcGCZf6Abptl/QgnZx7nfLoZ+E2\n\taJ+rqQuE3L3rQ0ZwhXY9VVjBVm90V/91gZ3xIadrpzuOrqpGJNKUiIClDyJhAuteACUQ\n\t9lM2yt7jpIQGZhgJ7KRloQ4K3eNn+Td/MaRTW1LIuebU9Na+UFxE611aR6wfH9FpdRn2\n\tut6xIUE552nKwukBDJzqQhuCApLZc+MYQUuJ96/A0rN7kawCSx4scUmanC1J2UkSIcFQ\n\tdpbw==", "X-Gm-Message-State": "AMke39mqOiYLjU20KHORpn6OpWuLNyRwHZQAn5rciu6o1PvYMF2tZYdC8ip5IbHceY1uPQ==", "X-Received": "by 10.84.217.18 with SMTP id o18mr44803351pli.51.1487178961009; \n\tWed, 15 Feb 2017 09:16:01 -0800 (PST)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Wed, 15 Feb 2017 09:15:59 -0800", "Message-ID": "<20170215171559.4456.38581.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH] igb/ixgbe: Fix typo in igb_build_skb\n\tand/or ixgbe_build_skb code comment", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThere was a typo that I had left in the code comments for the igb and ixgbe\nfunctions that enabled build_skb support. This patch is meant to clean\nthat up since it didn't seem like something worth respinning both series\nfor. If I end up having to respin the series I will pull this change into\nthe patch and at that time we can drop this one.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 2 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 2796e9a2361e..c62513f348e8 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -7043,7 +7043,7 @@ static struct sk_buff *igb_build_skb(struct igb_ring *rx_ring,\n \tprefetch(va + L1_CACHE_BYTES);\n #endif\n \n-\t/* build an skb to around the page buffer */\n+\t/* build an skb around the page buffer */\n \tskb = build_skb(va - IGB_SKB_PAD, truesize);\n \tif (unlikely(!skb))\n \t\treturn NULL;\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex bfcdc2fdeae4..25059fed3c72 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -2139,7 +2139,7 @@ static struct sk_buff *ixgbe_build_skb(struct ixgbe_ring *rx_ring,\n \tprefetch(va + L1_CACHE_BYTES);\n #endif\n \n-\t/* build an skb to around the page buffer */\n+\t/* build an skb around the page buffer */\n \tskb = build_skb(va - IXGBE_SKB_PAD, truesize);\n \tif (unlikely(!skb))\n \t\treturn NULL;\n", "prefixes": [ "next" ] }