Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/725216/?format=api
{ "id": 725216, "url": "http://patchwork.ozlabs.org/api/patches/725216/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1486482993-7818-1-git-send-email-tremyfr@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1486482993-7818-1-git-send-email-tremyfr@gmail.com>", "list_archive_url": null, "date": "2017-02-07T15:56:33", "name": "net: intel: ixgbevf: use new api ethtool_{get|set}_link_ksettings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8106941e1cc10b7d955bb2fd1be862e5b4cf22e5", "submitter": { "id": 65172, "url": "http://patchwork.ozlabs.org/api/people/65172/?format=api", "name": "Philippe Reynes", "email": "tremyfr@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1486482993-7818-1-git-send-email-tremyfr@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/725216/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/725216/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vHpqj6q7Pz9s7f\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 8 Feb 2017 02:56:48 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D6F6D2FB11;\n\tTue, 7 Feb 2017 15:56:46 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PPT2H+REekvR; Tue, 7 Feb 2017 15:56:45 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id F1D112F1A3;\n\tTue, 7 Feb 2017 15:56:44 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 277301BFF09\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Feb 2017 15:56:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 21B5B88AE6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Feb 2017 15:56:44 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ptcI1uEeRY7W for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Feb 2017 15:56:43 +0000 (UTC)", "from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 6490288ADB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Feb 2017 15:56:43 +0000 (UTC)", "by mail-wm0-f65.google.com with SMTP id v77so29020999wmv.0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 07 Feb 2017 07:56:43 -0800 (PST)", "from localhost.localdomain (bny93-7-88-161-33-221.fbx.proxad.net.\n\t[88.161.33.221]) by smtp.gmail.com with ESMTPSA id\n\ts26sm8009348wra.26.2017.02.07.07.56.40\n\t(version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 07 Feb 2017 07:56:40 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"EJ8mW98J\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=6JqfF7Rl3Bf/IB6/0jlSdKV70akdZ6vUqikNFH6TsRA=;\n\tb=EJ8mW98JAl35vfczle80wLU7Z10Rt0RORC4fe+jCUhPKfHJ6dbJEbbTpjgiPwdjDep\n\tD64UEFmJR/nGCQNhbaDFY2VDBL5d99/SxdReGdoPN2zfCFvk3CZmtHSk0HrA2I/nDDgO\n\t4WT1sEIQK8q9F1KOhIZtbp0Pa6eBYEfIYoUM4WKCkskPmWsyI8OY/yo51EAakfGXVSem\n\tVeLw7CyxOmuOvQFI5NsGjYEvR8Inhc3Ov6tqJg29nUHMBPuxGSjt7RLaPaSvG3m4Xj9K\n\ttVdmUR+3AnSDSkxRKPixSNthoM+FAAayFkoJX9p/nSNK2A12WYEZNcgUe0aajwCibJ3b\n\touCQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=6JqfF7Rl3Bf/IB6/0jlSdKV70akdZ6vUqikNFH6TsRA=;\n\tb=CloqgeZiC9PppH8R07Sw6nYBsM5LhAGvHiHjf3gZRiVabNh5803WV9gFA2oALUB93r\n\tOX3M0ccmwQlKZE2HjUwqx3ZNMlNGHIdTleLJnfYQN/Rm9R7GuapNldwI1M0N1wR/+Xab\n\tzyZIti86kUYUlo/sf13bOrR+XcU3HrLK3k/uhNsr8wgT2Frw3VnK1ZXtoNkI9xrYa5DL\n\tWOfdHP5tNXtn83uDVZLXGTcWHP6YJEOe5rtlU3GQONr/l2FWQjogzrj0I/C0IwN4R8AV\n\tFoEklHmXjXnTHSeiRr7Dm1cvbYcIgnd6dcrrKaM23Qm55eYwrPUJexPa9Aks+WSWVcH2\n\tLmzg==", "X-Gm-Message-State": "AMke39mH8lc5HDwzpOWJBnf7ZBCa5J+zD1TQrJQDo0LPX19nrrLtBwBFXAC1mVlk1C2TUA==", "X-Received": "by 10.28.214.144 with SMTP id\n\tn138mr12788240wmg.136.1486483001900; \n\tTue, 07 Feb 2017 07:56:41 -0800 (PST)", "From": "Philippe Reynes <tremyfr@gmail.com>", "To": "jeffrey.t.kirsher@intel.com,\n\tdavem@davemloft.net", "Date": "Tue, 7 Feb 2017 16:56:33 +0100", "Message-Id": "<1486482993-7818-1-git-send-email-tremyfr@gmail.com>", "X-Mailer": "git-send-email 1.7.4.4", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org, Philippe Reynes <tremyfr@gmail.com>", "Subject": "[Intel-wired-lan] [PATCH] net: intel: ixgbevf: use new api\n\tethtool_{get|set}_link_ksettings", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The ethtool api {get|set}_settings is deprecated.\nWe move this driver to new api {get|set}_link_ksettings.\n\nAs I don't have the hardware, I'd be very pleased if\nsomeone may test this patch.\n\nSigned-off-by: Philippe Reynes <tremyfr@gmail.com>\n---\n drivers/net/ethernet/intel/ixgbevf/ethtool.c | 22 +++++++++++-----------\n 1 files changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ethtool.c b/drivers/net/ethernet/intel/ixgbevf/ethtool.c\nindex 1f6c0ec..6bf7409 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ethtool.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ethtool.c\n@@ -91,18 +91,18 @@ struct ixgbe_stats {\n \n #define IXGBEVF_TEST_LEN (sizeof(ixgbe_gstrings_test) / ETH_GSTRING_LEN)\n \n-static int ixgbevf_get_settings(struct net_device *netdev,\n-\t\t\t\tstruct ethtool_cmd *ecmd)\n+static int ixgbevf_get_link_ksettings(struct net_device *netdev,\n+\t\t\t\t struct ethtool_link_ksettings *cmd)\n {\n \tstruct ixgbevf_adapter *adapter = netdev_priv(netdev);\n \tstruct ixgbe_hw *hw = &adapter->hw;\n \tu32 link_speed = 0;\n \tbool link_up;\n \n-\tecmd->supported = SUPPORTED_10000baseT_Full;\n-\tecmd->autoneg = AUTONEG_DISABLE;\n-\tecmd->transceiver = XCVR_DUMMY1;\n-\tecmd->port = -1;\n+\tethtool_link_ksettings_zero_link_mode(cmd, supported);\n+\tethtool_link_ksettings_add_link_mode(cmd, supported, 10000baseT_Full);\n+\tcmd->base.autoneg = AUTONEG_DISABLE;\n+\tcmd->base.port = -1;\n \n \thw->mac.get_link_status = 1;\n \thw->mac.ops.check_link(hw, &link_speed, &link_up, false);\n@@ -122,11 +122,11 @@ static int ixgbevf_get_settings(struct net_device *netdev,\n \t\t\tbreak;\n \t\t}\n \n-\t\tethtool_cmd_speed_set(ecmd, speed);\n-\t\tecmd->duplex = DUPLEX_FULL;\n+\t\tcmd->base.speed = speed;\n+\t\tcmd->base.duplex = DUPLEX_FULL;\n \t} else {\n-\t\tethtool_cmd_speed_set(ecmd, SPEED_UNKNOWN);\n-\t\tecmd->duplex = DUPLEX_UNKNOWN;\n+\t\tcmd->base.speed = SPEED_UNKNOWN;\n+\t\tcmd->base.duplex = DUPLEX_UNKNOWN;\n \t}\n \n \treturn 0;\n@@ -885,7 +885,6 @@ static int ixgbevf_get_rxfh(struct net_device *netdev, u32 *indir, u8 *key,\n }\n \n static const struct ethtool_ops ixgbevf_ethtool_ops = {\n-\t.get_settings\t\t= ixgbevf_get_settings,\n \t.get_drvinfo\t\t= ixgbevf_get_drvinfo,\n \t.get_regs_len\t\t= ixgbevf_get_regs_len,\n \t.get_regs\t\t= ixgbevf_get_regs,\n@@ -905,6 +904,7 @@ static int ixgbevf_get_rxfh(struct net_device *netdev, u32 *indir, u8 *key,\n \t.get_rxfh_indir_size\t= ixgbevf_get_rxfh_indir_size,\n \t.get_rxfh_key_size\t= ixgbevf_get_rxfh_key_size,\n \t.get_rxfh\t\t= ixgbevf_get_rxfh,\n+\t.get_link_ksettings\t= ixgbevf_get_link_ksettings,\n };\n \n void ixgbevf_set_ethtool_ops(struct net_device *netdev)\n", "prefixes": [] }