Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/724868/?format=api
{ "id": 724868, "url": "http://patchwork.ozlabs.org/api/patches/724868/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170207022632.9864.8422.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170207022632.9864.8422.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-02-07T02:26:40", "name": "[next,v5,07/12] igb: Use page_address offset from page instead of masking virtual address", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ec05cdbe835bb925ccdd1db2ca6d2630bbb9f0cb", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170207022632.9864.8422.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/724868/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/724868/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vHSs25Pp2z9s2P\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 7 Feb 2017 13:26:46 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4D31730A5B;\n\tTue, 7 Feb 2017 02:26:45 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DYykNcSMO5Xo; Tue, 7 Feb 2017 02:26:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 235CB30A47;\n\tTue, 7 Feb 2017 02:26:44 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6194D1BFEC6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Feb 2017 02:26:42 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5C0158A401\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Feb 2017 02:26:42 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Xb5h2QFJD5wd for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Feb 2017 02:26:41 +0000 (UTC)", "from mail-pf0-f193.google.com (mail-pf0-f193.google.com\n\t[209.85.192.193])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id DFE658A3FA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Feb 2017 02:26:41 +0000 (UTC)", "by mail-pf0-f193.google.com with SMTP id e4so8101196pfg.0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 06 Feb 2017 18:26:41 -0800 (PST)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\te4sm5689153pgc.45.2017.02.06.18.26.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 06 Feb 2017 18:26:40 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"E86S/zxE\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:date:message-id:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=4Mq8+TGlOYrs5RdUKYJC8mqdFFLVoS+UFKBO1EkQsmg=;\n\tb=E86S/zxEoZgBWBERCq2ToJ5GFclX1LxbVRUgDBapQTRrgMOmFBCHmyah/rJNvSwc1b\n\tOUeG2hJRA6Q7+zhMwxwmtPfM6hgMKhUc116zy0tcekdHEjOxJk4xIEKkpO1lPJQ1fg3F\n\tcK4Ae3bru0CoyQ+ozyPGeSOWjKErnM760ToMvXP8P7hsBNYPWezyWW0gYXEdySYOxJ/I\n\t88g3mLAjE8wh5Lz0IBZk+RmTJs3NDHUScFXKS+/3QOfilwA3bP5+YWeBFER2GGHFrWv2\n\tklqJREM2i45owbwGFmmMA+TjDTbh1151ExAupsWunuvu5oBFBBW++NJkHFXX+SkfqFuA\n\tt6Pg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=4Mq8+TGlOYrs5RdUKYJC8mqdFFLVoS+UFKBO1EkQsmg=;\n\tb=q61TKgw1HNhgFOJdJ/t9I0RYI4bk/ngHrzYfrNV9xz2Nxt2chvLZEoMZdJjZzqlryO\n\tmSP0cuYy0jzgWZhOPU/fjr+OCdlxihSaU0Wj52/FLawqSo4s6z+txVi4zm+t8Z4pgpO3\n\tpHOles9LyOWq2Dc0x1j39YaZAk5J1P1ZdiYLir5Y+v9Cvo4aAcwU2c88CgM36muNlPa6\n\t5wr2BFRhw449QCYHhmGFD3NdhNp9VajfxQKGWk1kabABKXA+6+moq1uz0wrDbUqC4AKV\n\tMZcQMpy4RA6NM1nSFF0h3YWyXX53WRZ6OxjvsYjJ5hE/nlvs6FpgQ3uvQz+wSC0oHSkH\n\t0Ong==", "X-Gm-Message-State": "AIkVDXLPK2o4bTCkOujDiheUtmqVblYMo6KtBH+rwFWlLGqNZ9Lz+1eRvW0QHvQcgr61HQ==", "X-Received": "by 10.98.133.202 with SMTP id m71mr17079706pfk.102.1486434401351;\n\tMon, 06 Feb 2017 18:26:41 -0800 (PST)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Mon, 06 Feb 2017 18:26:40 -0800", "Message-ID": "<20170207022632.9864.8422.stgit@localhost.localdomain>", "In-Reply-To": "<20170207022339.9864.87863.stgit@localhost.localdomain>", "References": "<20170207022339.9864.87863.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH v5 07/12] igb: Use page_address\n\toffset from page instead of masking virtual address", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nUpdate the handling of page addresses so that we always refer to them using\na void pointer, and try to use the consistent name of va indicating we are\nworking with a virtual address.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\nv4: Split this code out of patch 6 of the original series.\n\n drivers/net/ethernet/intel/igb/igb.h | 2 +-\n drivers/net/ethernet/intel/igb/igb_main.c | 11 +++++------\n drivers/net/ethernet/intel/igb/igb_ptp.c | 3 +--\n 3 files changed, 7 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb.h b/drivers/net/ethernet/intel/igb/igb.h\nindex a74928cc0e58..6a88a08c021c 100644\n--- a/drivers/net/ethernet/intel/igb/igb.h\n+++ b/drivers/net/ethernet/intel/igb/igb.h\n@@ -614,7 +614,7 @@ enum igb_boards {\n void igb_ptp_suspend(struct igb_adapter *adapter);\n void igb_ptp_rx_hang(struct igb_adapter *adapter);\n void igb_ptp_rx_rgtstamp(struct igb_q_vector *q_vector, struct sk_buff *skb);\n-void igb_ptp_rx_pktstamp(struct igb_q_vector *q_vector, unsigned char *va,\n+void igb_ptp_rx_pktstamp(struct igb_q_vector *q_vector, void *va,\n \t\t\t struct sk_buff *skb);\n int igb_ptp_set_ts_config(struct net_device *netdev, struct ifreq *ifr);\n int igb_ptp_get_ts_config(struct net_device *netdev, struct ifreq *ifr);\ndiff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 0820fded7331..c5cb93ebc633 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -6929,7 +6929,7 @@ static bool igb_add_rx_frag(struct igb_ring *rx_ring,\n \t\t\t struct sk_buff *skb)\n {\n \tstruct page *page = rx_buffer->page;\n-\tunsigned char *va = page_address(page) + rx_buffer->page_offset;\n+\tvoid *va = page_address(page) + rx_buffer->page_offset;\n #if (PAGE_SIZE < 8192)\n \tunsigned int truesize = IGB_RX_BUFSZ;\n #else\n@@ -6971,7 +6971,7 @@ static bool igb_add_rx_frag(struct igb_ring *rx_ring,\n \n add_tail_frag:\n \tskb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags, page,\n-\t\t\t(unsigned long)va & ~PAGE_MASK, size, truesize);\n+\t\t\tva - page_address(page), size, truesize);\n \n \treturn igb_can_reuse_rx_page(rx_buffer, page, truesize);\n }\n@@ -6996,13 +6996,12 @@ static struct sk_buff *igb_fetch_rx_buffer(struct igb_ring *rx_ring,\n \t\t\t\t DMA_FROM_DEVICE);\n \n \tif (likely(!skb)) {\n-\t\tvoid *page_addr = page_address(page) +\n-\t\t\t\t rx_buffer->page_offset;\n+\t\tvoid *va = page_address(page) + rx_buffer->page_offset;\n \n \t\t/* prefetch first cache line of first page */\n-\t\tprefetch(page_addr);\n+\t\tprefetch(va);\n #if L1_CACHE_BYTES < 128\n-\t\tprefetch(page_addr + L1_CACHE_BYTES);\n+\t\tprefetch(va + L1_CACHE_BYTES);\n #endif\n \n \t\t/* allocate a skb to store the frags */\ndiff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c b/drivers/net/ethernet/intel/igb/igb_ptp.c\nindex c4477552ce9e..7a3fd4d74592 100644\n--- a/drivers/net/ethernet/intel/igb/igb_ptp.c\n+++ b/drivers/net/ethernet/intel/igb/igb_ptp.c\n@@ -764,8 +764,7 @@ static void igb_ptp_tx_hwtstamp(struct igb_adapter *adapter)\n * incoming frame. The value is stored in little endian format starting on\n * byte 8.\n **/\n-void igb_ptp_rx_pktstamp(struct igb_q_vector *q_vector,\n-\t\t\t unsigned char *va,\n+void igb_ptp_rx_pktstamp(struct igb_q_vector *q_vector, void *va,\n \t\t\t struct sk_buff *skb)\n {\n \t__le64 *regval = (__le64 *)va;\n", "prefixes": [ "next", "v5", "07/12" ] }