Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/724863/?format=api
{ "id": 724863, "url": "http://patchwork.ozlabs.org/api/patches/724863/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170207022532.9864.50994.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170207022532.9864.50994.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-02-07T02:25:41", "name": "[next,v5,02/12] igb: Use length to determine if descriptor is done", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "16f3430aa6b0aceed8d6ed5d6e58ac442800d752", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170207022532.9864.50994.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/724863/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/724863/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vHSqv4mZnz9s2P\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 7 Feb 2017 13:25:47 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 321B530353;\n\tTue, 7 Feb 2017 02:25:46 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CN3VxXeMLJdf; Tue, 7 Feb 2017 02:25:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id E592830397;\n\tTue, 7 Feb 2017 02:25:44 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id AF3B81BFEC6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Feb 2017 02:25:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A91738A401\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Feb 2017 02:25:43 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WSvuJopjrGNa for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Feb 2017 02:25:43 +0000 (UTC)", "from mail-pg0-f65.google.com (mail-pg0-f65.google.com\n\t[74.125.83.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 0EFE88A3FA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Feb 2017 02:25:43 +0000 (UTC)", "by mail-pg0-f65.google.com with SMTP id 75so10623957pgf.3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 06 Feb 2017 18:25:43 -0800 (PST)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\tp25sm5858606pfd.0.2017.02.06.18.25.41\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 06 Feb 2017 18:25:42 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"PV69MyfS\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:date:message-id:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=clKlL39X11t75hRfcijMwwFlga2Gtbja/S5u5KozOY4=;\n\tb=PV69MyfSka+UERgCXXf1BQywAiI40EBJHtT3WFqSercNr7wOpktzRJYcFrWhouFwmN\n\t0fsUjriBJ5Ien92X2N4gNo0PALiRBzSkUOcWCgc+t3+zE9kY0JMtITS+TFIAyp+/IdXy\n\t3ERteKvHS69dhXiaP2l8BR2IYnqJbY+oWF0drQM1KOu+npTEZK09WxLYuWBVVVN36bjc\n\terYQ0GmB49u2IvMIOeQJSaEBoNq+XRa+5TftX9NAk44WvG/bAhlD6RTRCMi5f3fmgoqw\n\tcWbZhPxZZvsGScHVbW6KDOnhqaEHtchnP97YOtPNywCT7KG8ErxgCgsLo/OAmDduZ2Xe\n\tesbQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=clKlL39X11t75hRfcijMwwFlga2Gtbja/S5u5KozOY4=;\n\tb=cL1yNdqLDHIU0P4egLSBYVNe7XF1xjpj5VdkFLSdPpFzj21vC5QrnbC/Ize034EWsd\n\t16UCb/c04TNm24QQm/Mb1yvkjbdcpFbsynpU0ExB0GoauD4FODhQ2lXV3Pl4qy1gVgug\n\tPA0+pdrNxCfdLJW29mf1Hh4FRBcA4bIc7bfd9WyTg93JgEzOUxRlAEuINOZN0fQ04wLN\n\tXJFyW4IqK5jYJRVg84eBbA1jkFx4CoEbryjf4NKEaT2SqOphvojwYcN7Oi2mtmUq048x\n\tmkYDe7OWnhIfT2Mqv7Wzx8BDG4GLY5bhn70WK6SF0tBAUfBKNdUUl/7aQQfdJw4p5Lhg\n\t2Z3Q==", "X-Gm-Message-State": "AIkVDXJAPHhp1jNzr4gsKnNztC6r78a4/aDCIPYvAQYT8YvWOnmUEm6/lxg88IWlt47mBA==", "X-Received": "by 10.98.75.156 with SMTP id d28mr16951283pfj.59.1486434342671; \n\tMon, 06 Feb 2017 18:25:42 -0800 (PST)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Mon, 06 Feb 2017 18:25:41 -0800", "Message-ID": "<20170207022532.9864.50994.stgit@localhost.localdomain>", "In-Reply-To": "<20170207022339.9864.87863.stgit@localhost.localdomain>", "References": "<20170207022339.9864.87863.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH v5 02/12] igb: Use length to\n\tdetermine if descriptor is done", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThis change makes it so that we use the length of the packet instead of the\nDD status bit to determine if a new descriptor is ready to be processed.\nThe obvious advantage is that it cuts down on reads as we don't really even\nneed the DD bit if going from a 0 to a non-zero value on size is enough to\ninform us that the packet has been completed.\n\nIn addition I have updated the code so that we only reset the Rx descriptor\nlength for descriptor zero when resetting a ring instead of having to do a\nmemset with 0 over the entire ring. By doing this we can save some time on\ninitialization.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\nv2: Update ethtool loopback test to use length check instead of DD check\n\n drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +-\n drivers/net/ethernet/intel/igb/igb_main.c | 14 ++++++++------\n 2 files changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c\nindex 737b664d004c..3f5f7744c90f 100644\n--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c\n+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c\n@@ -1811,7 +1811,7 @@ static int igb_clean_test_rings(struct igb_ring *rx_ring,\n \ttx_ntc = tx_ring->next_to_clean;\n \trx_desc = IGB_RX_DESC(rx_ring, rx_ntc);\n \n-\twhile (igb_test_staterr(rx_desc, E1000_RXD_STAT_DD)) {\n+\twhile (rx_desc->wb.upper.length) {\n \t\t/* check Rx buffer */\n \t\trx_buffer_info = &rx_ring->rx_buffer_info[rx_ntc];\n \ndiff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex eede6db6037c..91a524b155ce 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -3720,6 +3720,7 @@ void igb_configure_rx_ring(struct igb_adapter *adapter,\n \t\t\t struct igb_ring *ring)\n {\n \tstruct e1000_hw *hw = &adapter->hw;\n+\tunion e1000_adv_rx_desc *rx_desc;\n \tu64 rdba = ring->dma;\n \tint reg_idx = ring->reg_idx;\n \tu32 srrctl = 0, rxdctl = 0;\n@@ -3758,6 +3759,10 @@ void igb_configure_rx_ring(struct igb_adapter *adapter,\n \trxdctl |= IGB_RX_HTHRESH << 8;\n \trxdctl |= IGB_RX_WTHRESH << 16;\n \n+\t/* initialize Rx descriptor 0 */\n+\trx_desc = IGB_RX_DESC(ring, 0);\n+\trx_desc->wb.upper.length = 0;\n+\n \t/* enable receive descriptor fetching */\n \trxdctl |= E1000_RXDCTL_QUEUE_ENABLE;\n \twr32(E1000_RXDCTL(reg_idx), rxdctl);\n@@ -3973,9 +3978,6 @@ static void igb_clean_rx_ring(struct igb_ring *rx_ring)\n \tsize = sizeof(struct igb_rx_buffer) * rx_ring->count;\n \tmemset(rx_ring->rx_buffer_info, 0, size);\n \n-\t/* Zero out the descriptor ring */\n-\tmemset(rx_ring->desc, 0, rx_ring->size);\n-\n \trx_ring->next_to_alloc = 0;\n \trx_ring->next_to_clean = 0;\n \trx_ring->next_to_use = 0;\n@@ -7174,7 +7176,7 @@ static int igb_clean_rx_irq(struct igb_q_vector *q_vector, const int budget)\n \n \t\trx_desc = IGB_RX_DESC(rx_ring, rx_ring->next_to_clean);\n \n-\t\tif (!rx_desc->wb.upper.status_error)\n+\t\tif (!rx_desc->wb.upper.length)\n \t\t\tbreak;\n \n \t\t/* This memory barrier is needed to keep us from reading\n@@ -7314,8 +7316,8 @@ void igb_alloc_rx_buffers(struct igb_ring *rx_ring, u16 cleaned_count)\n \t\t\ti -= rx_ring->count;\n \t\t}\n \n-\t\t/* clear the status bits for the next_to_use descriptor */\n-\t\trx_desc->wb.upper.status_error = 0;\n+\t\t/* clear the length for the next_to_use descriptor */\n+\t\trx_desc->wb.upper.length = 0;\n \n \t\tcleaned_count--;\n \t} while (cleaned_count);\n", "prefixes": [ "next", "v5", "02/12" ] }