Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/724783/?format=api
{ "id": 724783, "url": "http://patchwork.ozlabs.org/api/patches/724783/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170206223846.31052-6-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170206223846.31052-6-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2017-02-06T22:38:42", "name": "[PART1,05/11] i40e: exit ATR mode only when adding TCP/IPv4 filter succeeds", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e759b0027adbdb7b73d862742dd5acf6edb9397c", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170206223846.31052-6-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/724783/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/724783/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vHMpP2nRZz9s1y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 7 Feb 2017 09:39:09 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id AD96D30A53;\n\tMon, 6 Feb 2017 22:39:07 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id yluQ9WUzuumW; Mon, 6 Feb 2017 22:39:02 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0FEC230A74;\n\tMon, 6 Feb 2017 22:38:56 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id C8B091BFF07\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 6 Feb 2017 22:38:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C548589EF2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 6 Feb 2017 22:38:51 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HlS75EIG5AHM for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 6 Feb 2017 22:38:49 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 9209F89EF6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 6 Feb 2017 22:38:49 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga102.jf.intel.com with ESMTP; 06 Feb 2017 14:38:48 -0800", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([10.166.35.174])\n\tby fmsmga006.fm.intel.com with ESMTP; 06 Feb 2017 14:38:48 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.33,342,1477983600\"; d=\"scan'208\";a=\"62577446\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Mon, 6 Feb 2017 14:38:42 -0800", "Message-Id": "<20170206223846.31052-6-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.12.0.rc0.151.g8a5726c42288", "In-Reply-To": "<20170206223846.31052-1-jacob.e.keller@intel.com>", "References": "<20170206223846.31052-1-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [PART1 PATCH 05/11] i40e: exit ATR mode only when\n\tadding TCP/IPv4 filter succeeds", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Move ATR exit check after we have sent the TCP/IPv4 filter to the ring\nsuccessfully. This avoids an issue where we potentially update the\nfilter count without actually succeeding in adding the filter. Now, we\nonly increment the fd_tcp_rule after we've succeeded. Additionally, we\nwill re-enable ATR mode only after deletion of the filter is actually\nposted to the FDIR ring.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nReviewed-by: Williams, Mitch A <mitch.a.williams@intel.com>\nChange-ID: If5c1dea422081cc5e2de65618b01b4c3bf6bd586\n---\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 34 ++++++++++++++---------------\n 1 file changed, 17 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex 8924ee6e7773..5756139636ff 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -285,23 +285,6 @@ static int i40e_add_del_fdir_tcpv4(struct i40e_vsi *vsi,\n \tip->saddr = fd_data->src_ip;\n \ttcp->source = fd_data->src_port;\n \n-\tif (add) {\n-\t\tpf->fd_tcp_rule++;\n-\t\tif ((pf->flags & I40E_FLAG_FD_ATR_ENABLED) &&\n-\t\t I40E_DEBUG_FD & pf->hw.debug_mask)\n-\t\t\tdev_info(&pf->pdev->dev, \"Forcing ATR off, sideband rules for TCP/IPv4 flow being applied\\n\");\n-\t\tpf->auto_disable_flags |= I40E_FLAG_FD_ATR_ENABLED;\n-\t} else {\n-\t\tpf->fd_tcp_rule = (pf->fd_tcp_rule > 0) ?\n-\t\t\t\t (pf->fd_tcp_rule - 1) : 0;\n-\t\tif (pf->fd_tcp_rule == 0) {\n-\t\t\tif ((pf->flags & I40E_FLAG_FD_ATR_ENABLED) &&\n-\t\t\t I40E_DEBUG_FD & pf->hw.debug_mask)\n-\t\t\t\tdev_info(&pf->pdev->dev, \"ATR re-enabled due to no sideband TCP/IPv4 rules\\n\");\n-\t\t\tpf->auto_disable_flags &= ~I40E_FLAG_FD_ATR_ENABLED;\n-\t\t}\n-\t}\n-\n \tfd_data->pctype = I40E_FILTER_PCTYPE_NONF_IPV4_TCP;\n \tret = i40e_program_fdir_filter(fd_data, raw_packet, pf, add);\n \tif (ret) {\n@@ -321,6 +304,23 @@ static int i40e_add_del_fdir_tcpv4(struct i40e_vsi *vsi,\n \t\t\t\t fd_data->pctype, fd_data->fd_id);\n \t}\n \n+\tif (add) {\n+\t\tpf->fd_tcp_rule++;\n+\t\tif ((pf->flags & I40E_FLAG_FD_ATR_ENABLED) &&\n+\t\t I40E_DEBUG_FD & pf->hw.debug_mask)\n+\t\t\tdev_info(&pf->pdev->dev, \"Forcing ATR off, sideband rules for TCP/IPv4 flow being applied\\n\");\n+\t\tpf->auto_disable_flags |= I40E_FLAG_FD_ATR_ENABLED;\n+\t} else {\n+\t\tpf->fd_tcp_rule = (pf->fd_tcp_rule > 0) ?\n+\t\t\t\t (pf->fd_tcp_rule - 1) : 0;\n+\t\tif (pf->fd_tcp_rule == 0) {\n+\t\t\tif ((pf->flags & I40E_FLAG_FD_ATR_ENABLED) &&\n+\t\t\t I40E_DEBUG_FD & pf->hw.debug_mask)\n+\t\t\t\tdev_info(&pf->pdev->dev, \"ATR re-enabled due to no sideband TCP/IPv4 rules\\n\");\n+\t\t\tpf->auto_disable_flags &= ~I40E_FLAG_FD_ATR_ENABLED;\n+\t\t}\n+\t}\n+\n \treturn 0;\n }\n \n", "prefixes": [ "PART1", "05/11" ] }