Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/724302/?format=api
{ "id": 724302, "url": "http://patchwork.ozlabs.org/api/patches/724302/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1486336271-25336-1-git-send-email-tremyfr@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1486336271-25336-1-git-send-email-tremyfr@gmail.com>", "list_archive_url": null, "date": "2017-02-05T23:11:11", "name": "net: intel: ixgb: use new api ethtool_{get|set}_link_ksettings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "069a02a0189086bf0830ff95e002706de0fcdd01", "submitter": { "id": 65172, "url": "http://patchwork.ozlabs.org/api/people/65172/?format=api", "name": "Philippe Reynes", "email": "tremyfr@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1486336271-25336-1-git-send-email-tremyfr@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/724302/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/724302/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vGmZ44SjYz9s2s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 6 Feb 2017 10:11:24 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 10A592F743;\n\tSun, 5 Feb 2017 23:11:23 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6-QZpl+CMajK; Sun, 5 Feb 2017 23:11:22 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1C7EF2EEDC;\n\tSun, 5 Feb 2017 23:11:22 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4C80D1C0378\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 5 Feb 2017 23:11:21 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 464212EEDC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 5 Feb 2017 23:11:21 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Il3oBRKpZL0S for <intel-wired-lan@lists.osuosl.org>;\n\tSun, 5 Feb 2017 23:11:20 +0000 (UTC)", "from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 3D1872EEC4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 5 Feb 2017 23:11:20 +0000 (UTC)", "by mail-wm0-f67.google.com with SMTP id c85so18590090wmi.1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 05 Feb 2017 15:11:20 -0800 (PST)", "from localhost.localdomain (bny93-7-88-161-33-221.fbx.proxad.net.\n\t[88.161.33.221]) by smtp.gmail.com with ESMTPSA id\n\tz67sm57211686wrb.49.2017.02.05.15.11.17\n\t(version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSun, 05 Feb 2017 15:11:17 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"uXu1/Ly5\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=qs+FsVgRZm0O8wWWAkSIGK6hnW7d2i7SeA2L8jieBvI=;\n\tb=uXu1/Ly51bz3UCdEHaYPTi0Xp+NE8seTKpnZl55FSd9rct1qc5iTvuTqNfAOZF4i2l\n\tI2GJ5IVWsoEEB1GXsJqrYLeY65+6E/fDUxDFyvQ3to6X2SDvuR9LGI/SqIM/GlT3jwmh\n\tqPVqoL1/flJcZnMq0i88k8gsYFeLvyo5bfEUiq0p/ILNHoxkKo4czHJqCP1JBXuowrcI\n\t09ehvr9+VmRESG+0lcdb+SyY4rSuYVg/p8RD7zPbsy5ZZNiekmYsrGU13V3NhqFNd3po\n\tduUJuCYYqCn5ex/OwfRgiA3Zkceb9FBQWiPQwxUnj6dPwaPgX6whfYfTcnz4kY+A89io\n\tYq1g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=qs+FsVgRZm0O8wWWAkSIGK6hnW7d2i7SeA2L8jieBvI=;\n\tb=MknG1K6D+Cuau4Fs5wX7NTxEmllUNYtcpazLSURkM2X6MteAVv2kJQaE9/HbDRmRqH\n\tbbD3l9KyJPfgfvxFCAY/hanJzS1wTrso5TMSKuCMDKgGo4osKEjXGw3J3rrZYoBIYGCj\n\tewY1rdRL8ctYCnTGMN6zpuPas7a58rCZkYzZ2LsMK27eiU9azuT8vaD4tlazmFBxw8Me\n\tDEAeMy2CMyQtwxpPlotWqNAwsNq1kdnKfNl/1ODjctwq2SjYkp1P6qNFuBFLY3ULUh9I\n\t1/Eu74YFlQxUMfrNXB8i9bnxQIEjUGN3WcH+eALQZqFld7qd8N0vCZZB9VqPN6bhRyLs\n\tgF2g==", "X-Gm-Message-State": "AIkVDXJ3jooVYB9442ACvg74sX6rSGsiRleAGuWMtr7lAmTvoQTg5iq51IQodTa/sDHusQ==", "X-Received": "by 10.223.172.210 with SMTP id o76mr6654341wrc.21.1486336278575; \n\tSun, 05 Feb 2017 15:11:18 -0800 (PST)", "From": "Philippe Reynes <tremyfr@gmail.com>", "To": "jeffrey.t.kirsher@intel.com,\n\tdavem@davemloft.net", "Date": "Mon, 6 Feb 2017 00:11:11 +0100", "Message-Id": "<1486336271-25336-1-git-send-email-tremyfr@gmail.com>", "X-Mailer": "git-send-email 1.7.4.4", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org, Philippe Reynes <tremyfr@gmail.com>", "Subject": "[Intel-wired-lan] [PATCH] net: intel: ixgb: use new api\n\tethtool_{get|set}_link_ksettings", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The ethtool api {get|set}_settings is deprecated.\nWe move this driver to new api {get|set}_link_ksettings.\n\nAs I don't have the hardware, I'd be very pleased if\nsomeone may test this patch.\n\nSigned-off-by: Philippe Reynes <tremyfr@gmail.com>\n---\n drivers/net/ethernet/intel/ixgb/ixgb_ethtool.c | 39 ++++++++++++++----------\n 1 files changed, 23 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgb/ixgb_ethtool.c b/drivers/net/ethernet/intel/ixgb/ixgb_ethtool.c\nindex e5d7255..d10a0d2 100644\n--- a/drivers/net/ethernet/intel/ixgb/ixgb_ethtool.c\n+++ b/drivers/net/ethernet/intel/ixgb/ixgb_ethtool.c\n@@ -94,24 +94,30 @@ struct ixgb_stats {\n #define IXGB_STATS_LEN\tARRAY_SIZE(ixgb_gstrings_stats)\n \n static int\n-ixgb_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)\n+ixgb_get_link_ksettings(struct net_device *netdev,\n+\t\t\tstruct ethtool_link_ksettings *cmd)\n {\n \tstruct ixgb_adapter *adapter = netdev_priv(netdev);\n \n-\tecmd->supported = (SUPPORTED_10000baseT_Full | SUPPORTED_FIBRE);\n-\tecmd->advertising = (ADVERTISED_10000baseT_Full | ADVERTISED_FIBRE);\n-\tecmd->port = PORT_FIBRE;\n-\tecmd->transceiver = XCVR_EXTERNAL;\n+\tethtool_link_ksettings_zero_link_mode(cmd, supported);\n+\tethtool_link_ksettings_add_link_mode(cmd, supported, 10000baseT_Full);\n+\tethtool_link_ksettings_add_link_mode(cmd, supported, FIBRE);\n+\n+\tethtool_link_ksettings_zero_link_mode(cmd, advertising);\n+\tethtool_link_ksettings_add_link_mode(cmd, advertising, 10000baseT_Full);\n+\tethtool_link_ksettings_add_link_mode(cmd, advertising, FIBRE);\n+\n+\tcmd->base.port = PORT_FIBRE;\n \n \tif (netif_carrier_ok(adapter->netdev)) {\n-\t\tethtool_cmd_speed_set(ecmd, SPEED_10000);\n-\t\tecmd->duplex = DUPLEX_FULL;\n+\t\tcmd->base.speed = SPEED_10000;\n+\t\tcmd->base.duplex = DUPLEX_FULL;\n \t} else {\n-\t\tethtool_cmd_speed_set(ecmd, SPEED_UNKNOWN);\n-\t\tecmd->duplex = DUPLEX_UNKNOWN;\n+\t\tcmd->base.speed = SPEED_UNKNOWN;\n+\t\tcmd->base.duplex = DUPLEX_UNKNOWN;\n \t}\n \n-\tecmd->autoneg = AUTONEG_DISABLE;\n+\tcmd->base.autoneg = AUTONEG_DISABLE;\n \treturn 0;\n }\n \n@@ -126,13 +132,14 @@ void ixgb_set_speed_duplex(struct net_device *netdev)\n }\n \n static int\n-ixgb_set_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)\n+ixgb_set_link_ksettings(struct net_device *netdev,\n+\t\t\tconst struct ethtool_link_ksettings *cmd)\n {\n \tstruct ixgb_adapter *adapter = netdev_priv(netdev);\n-\tu32 speed = ethtool_cmd_speed(ecmd);\n+\tu32 speed = cmd->base.speed;\n \n-\tif (ecmd->autoneg == AUTONEG_ENABLE ||\n-\t (speed + ecmd->duplex != SPEED_10000 + DUPLEX_FULL))\n+\tif (cmd->base.autoneg == AUTONEG_ENABLE ||\n+\t (speed + cmd->base.duplex != SPEED_10000 + DUPLEX_FULL))\n \t\treturn -EINVAL;\n \n \tif (netif_running(adapter->netdev)) {\n@@ -630,8 +637,6 @@ void ixgb_set_speed_duplex(struct net_device *netdev)\n }\n \n static const struct ethtool_ops ixgb_ethtool_ops = {\n-\t.get_settings = ixgb_get_settings,\n-\t.set_settings = ixgb_set_settings,\n \t.get_drvinfo = ixgb_get_drvinfo,\n \t.get_regs_len = ixgb_get_regs_len,\n \t.get_regs = ixgb_get_regs,\n@@ -649,6 +654,8 @@ void ixgb_set_speed_duplex(struct net_device *netdev)\n \t.set_phys_id = ixgb_set_phys_id,\n \t.get_sset_count = ixgb_get_sset_count,\n \t.get_ethtool_stats = ixgb_get_ethtool_stats,\n+\t.get_link_ksettings = ixgb_get_link_ksettings,\n+\t.set_link_ksettings = ixgb_set_link_ksettings,\n };\n \n void ixgb_set_ethtool_ops(struct net_device *netdev)\n", "prefixes": [] }