Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/724300/?format=api
{ "id": 724300, "url": "http://patchwork.ozlabs.org/api/patches/724300/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1486335319-16273-1-git-send-email-tremyfr@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1486335319-16273-1-git-send-email-tremyfr@gmail.com>", "list_archive_url": null, "date": "2017-02-05T22:55:19", "name": "net: intel: igbvf: use new api ethtool_{get|set}_link_ksettings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9e10c4e152050aa86b1b2d10834896d1858e86e7", "submitter": { "id": 65172, "url": "http://patchwork.ozlabs.org/api/people/65172/?format=api", "name": "Philippe Reynes", "email": "tremyfr@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1486335319-16273-1-git-send-email-tremyfr@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/724300/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/724300/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vGmCn4BxPz9s3s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 6 Feb 2017 09:55:33 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D28928793F;\n\tSun, 5 Feb 2017 22:55:31 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id B9M09FMnCVCS; Sun, 5 Feb 2017 22:55:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9C48E8793C;\n\tSun, 5 Feb 2017 22:55:30 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 5C7E21C03CF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 5 Feb 2017 22:55:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 56612872DB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 5 Feb 2017 22:55:29 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zKkYvetzGFU5 for <intel-wired-lan@lists.osuosl.org>;\n\tSun, 5 Feb 2017 22:55:28 +0000 (UTC)", "from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 1E32187132\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 5 Feb 2017 22:55:28 +0000 (UTC)", "by mail-wm0-f65.google.com with SMTP id c85so18539172wmi.1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 05 Feb 2017 14:55:28 -0800 (PST)", "from localhost.localdomain (bny93-7-88-161-33-221.fbx.proxad.net.\n\t[88.161.33.221]) by smtp.gmail.com with ESMTPSA id\n\tn13sm56908640wrn.40.2017.02.05.14.55.24\n\t(version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSun, 05 Feb 2017 14:55:25 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"gMQJ2qUu\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=AEU5OH6Rp2SrBaIle9sKFUTTmi5WSF8RwPLHUk0Ogz0=;\n\tb=gMQJ2qUuo+zo47/MpkHY5BdGnocYtNbvIEMQMtOsXRuXknM9gnDaIVyIU2uXejYFLa\n\tVSDc6Lhn/2KGvyxkVpiMbYY5RYWsmhp8TdVGwrQBZ6+HfF8W+cPl9mfW00o8bMNC/RTF\n\thNVvqyNb8e0gQYd8y5igrg/9nzdS+TJ+8euxYYPoWdOhS4FY5AOm9bWeGlfH7GyIdosQ\n\treEHtIcKT3UQI6hlS4O21Rhv1FN638zvNZVOMJcILGbVqLiteOL3g/LWLPqRuxRmniC8\n\tIYPwIPaGKAbbx6+Bo0nmSHs38cy1MkTQ7ZX52gVTJ4xk4fCpOsFmvG0s5eI9INPvbWXV\n\tHbHQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=AEU5OH6Rp2SrBaIle9sKFUTTmi5WSF8RwPLHUk0Ogz0=;\n\tb=d+RH2QgKZHGigeFDmoF5UeapLdgZ4AWUNaHaUgD5XxBmcFYG5VD34OeOGT9bpcdh4m\n\t2eaZcB7VN6RIf8cwl90PAedV2lgalBDgi+dEGk/WGFMUUnj1hXqMOZDG+OgrMTFhyVBG\n\tR+W/ZlbcGsP+io9LeHsgLTETbhC5Upgyokk52/abS6goOd90jcMK50AxaoYADxqthDB4\n\t1rKcsDpr6+k9Pv4uzoIDmoLsmjH/NVMR92ilosJIYCkI13oRx5/2sTWiL5UffQ9EPB6R\n\tiqEqCSIMwNjEm4GbIQ6S+FUypdRmPN7z5eWq6bEb6lJQ8VJxAuICai8FsVH++eiStHLw\n\tPEug==", "X-Gm-Message-State": "AMke39m5mw81plbSQtHzXQTymfVOVwidgA1xh9c8m1Q3sd8VZHhYTtg0pKtMPxVRnHhSBw==", "X-Received": "by 10.28.111.220 with SMTP id c89mr5875465wmi.102.1486335326569; \n\tSun, 05 Feb 2017 14:55:26 -0800 (PST)", "From": "Philippe Reynes <tremyfr@gmail.com>", "To": "jeffrey.t.kirsher@intel.com,\n\tdavem@davemloft.net", "Date": "Sun, 5 Feb 2017 23:55:19 +0100", "Message-Id": "<1486335319-16273-1-git-send-email-tremyfr@gmail.com>", "X-Mailer": "git-send-email 1.7.4.4", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org, Philippe Reynes <tremyfr@gmail.com>", "Subject": "[Intel-wired-lan] [PATCH] net: intel: igbvf: use new api\n\tethtool_{get|set}_link_ksettings", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The ethtool api {get|set}_settings is deprecated.\nWe move this driver to new api {get|set}_link_ksettings.\n\nAs I don't have the hardware, I'd be very pleased if\nsomeone may test this patch.\n\nSigned-off-by: Philippe Reynes <tremyfr@gmail.com>\n---\n drivers/net/ethernet/intel/igbvf/ethtool.c | 38 ++++++++++++++--------------\n 1 files changed, 19 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c b/drivers/net/ethernet/intel/igbvf/ethtool.c\nindex 8dea1b1..34faa11 100644\n--- a/drivers/net/ethernet/intel/igbvf/ethtool.c\n+++ b/drivers/net/ethernet/intel/igbvf/ethtool.c\n@@ -71,45 +71,45 @@ struct igbvf_stats {\n \n #define IGBVF_TEST_LEN ARRAY_SIZE(igbvf_gstrings_test)\n \n-static int igbvf_get_settings(struct net_device *netdev,\n-\t\t\t struct ethtool_cmd *ecmd)\n+static int igbvf_get_link_ksettings(struct net_device *netdev,\n+\t\t\t\t struct ethtool_link_ksettings *cmd)\n {\n \tstruct igbvf_adapter *adapter = netdev_priv(netdev);\n \tstruct e1000_hw *hw = &adapter->hw;\n \tu32 status;\n \n-\tecmd->supported = SUPPORTED_1000baseT_Full;\n+\tethtool_link_ksettings_zero_link_mode(cmd, supported);\n+\tethtool_link_ksettings_add_link_mode(cmd, supported, 1000baseT_Full);\n+\tethtool_link_ksettings_zero_link_mode(cmd, advertising);\n+\tethtool_link_ksettings_add_link_mode(cmd, advertising, 1000baseT_Full);\n \n-\tecmd->advertising = ADVERTISED_1000baseT_Full;\n-\n-\tecmd->port = -1;\n-\tecmd->transceiver = XCVR_DUMMY1;\n+\tcmd->base.port = -1;\n \n \tstatus = er32(STATUS);\n \tif (status & E1000_STATUS_LU) {\n \t\tif (status & E1000_STATUS_SPEED_1000)\n-\t\t\tethtool_cmd_speed_set(ecmd, SPEED_1000);\n+\t\t\tcmd->base.speed = SPEED_1000;\n \t\telse if (status & E1000_STATUS_SPEED_100)\n-\t\t\tethtool_cmd_speed_set(ecmd, SPEED_100);\n+\t\t\tcmd->base.speed = SPEED_100;\n \t\telse\n-\t\t\tethtool_cmd_speed_set(ecmd, SPEED_10);\n+\t\t\tcmd->base.speed = SPEED_10;\n \n \t\tif (status & E1000_STATUS_FD)\n-\t\t\tecmd->duplex = DUPLEX_FULL;\n+\t\t\tcmd->base.duplex = DUPLEX_FULL;\n \t\telse\n-\t\t\tecmd->duplex = DUPLEX_HALF;\n+\t\t\tcmd->base.duplex = DUPLEX_HALF;\n \t} else {\n-\t\tethtool_cmd_speed_set(ecmd, SPEED_UNKNOWN);\n-\t\tecmd->duplex = DUPLEX_UNKNOWN;\n+\t\tcmd->base.speed = SPEED_UNKNOWN;\n+\t\tcmd->base.duplex = DUPLEX_UNKNOWN;\n \t}\n \n-\tecmd->autoneg = AUTONEG_DISABLE;\n+\tcmd->base.autoneg = AUTONEG_DISABLE;\n \n \treturn 0;\n }\n \n-static int igbvf_set_settings(struct net_device *netdev,\n-\t\t\t struct ethtool_cmd *ecmd)\n+static int igbvf_set_link_ksettings(struct net_device *netdev,\n+\t\t\t\t const struct ethtool_link_ksettings *cmd)\n {\n \treturn -EOPNOTSUPP;\n }\n@@ -443,8 +443,6 @@ static void igbvf_get_strings(struct net_device *netdev, u32 stringset,\n }\n \n static const struct ethtool_ops igbvf_ethtool_ops = {\n-\t.get_settings\t\t= igbvf_get_settings,\n-\t.set_settings\t\t= igbvf_set_settings,\n \t.get_drvinfo\t\t= igbvf_get_drvinfo,\n \t.get_regs_len\t\t= igbvf_get_regs_len,\n \t.get_regs\t\t= igbvf_get_regs,\n@@ -467,6 +465,8 @@ static void igbvf_get_strings(struct net_device *netdev, u32 stringset,\n \t.get_ethtool_stats\t= igbvf_get_ethtool_stats,\n \t.get_coalesce\t\t= igbvf_get_coalesce,\n \t.set_coalesce\t\t= igbvf_set_coalesce,\n+\t.get_link_ksettings\t= igbvf_get_link_ksettings,\n+\t.set_link_ksettings\t= igbvf_set_link_ksettings,\n };\n \n void igbvf_set_ethtool_ops(struct net_device *netdev)\n", "prefixes": [] }