Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/724149/?format=api
{ "id": 724149, "url": "http://patchwork.ozlabs.org/api/patches/724149/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1486248543-14722-1-git-send-email-tremyfr@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1486248543-14722-1-git-send-email-tremyfr@gmail.com>", "list_archive_url": null, "date": "2017-02-04T22:49:03", "name": "net: intel: i40evf: use new api ethtool_{get|set}_link_ksettings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "aa205776dab23f6ad0bbf3dbda47930af133720c", "submitter": { "id": 65172, "url": "http://patchwork.ozlabs.org/api/people/65172/?format=api", "name": "Philippe Reynes", "email": "tremyfr@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1486248543-14722-1-git-send-email-tremyfr@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/724149/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/724149/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vG8733nMMz9s2P\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 5 Feb 2017 09:49:19 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6E46F87E05;\n\tSat, 4 Feb 2017 22:49:17 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gkR_HPBlltz4; Sat, 4 Feb 2017 22:49:15 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3E59A88049;\n\tSat, 4 Feb 2017 22:49:15 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8D46B1C232B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 4 Feb 2017 22:49:13 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 86AB089946\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 4 Feb 2017 22:49:13 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id x-6kfQt1ja5O for <intel-wired-lan@lists.osuosl.org>;\n\tSat, 4 Feb 2017 22:49:11 +0000 (UTC)", "from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 750FA89910\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 4 Feb 2017 22:49:11 +0000 (UTC)", "by mail-wm0-f67.google.com with SMTP id r18so13417357wmd.3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 04 Feb 2017 14:49:11 -0800 (PST)", "from localhost.localdomain (bny93-7-88-161-33-221.fbx.proxad.net.\n\t[88.161.33.221]) by smtp.gmail.com with ESMTPSA id\n\tw16sm4638379wmd.4.2017.02.04.14.49.07\n\t(version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSat, 04 Feb 2017 14:49:08 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"X5tNMvhq\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=l0zIsr0rr6W+nBhTzcSR9L2tJXF7r2iJ9OiAIfnKAV0=;\n\tb=X5tNMvhqylG42KsqGqgvRpkx+8MJ1LOdjURZz4t3FbyprjNb4NI7vWG1BcqJfOblNf\n\tGH71PdGofkAS1z1DBYXpaPDlNX9JVzXK4yguvtMh3bNOv9WmMBJ9OKDTFAroWFtlX8np\n\t573frgloLvYEUWggBLl2BPXAWO+0+zqCctNb7eCzxeehhiYxrsbHPWBGXW8/mGPDkBls\n\txL6drUfd76d3+t2gHqf6SpdeWmJQEALOAJ/oaA+D9AChKCSff6J7cXCY9EsCHQgC8F93\n\tZMGJUWAQZCj2y4CV/vW1lwbJPk2UR/4WAW8zdbjT/lHfF53ze2lw1oXhN9uvF0oft7aC\n\txUdw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=l0zIsr0rr6W+nBhTzcSR9L2tJXF7r2iJ9OiAIfnKAV0=;\n\tb=B4yCv3Z85Ku2dMfTq+p6CFwLlVw9nER7rrI5ekZK9zlrOFfio0XLV2JvW7TPRe1MtT\n\t2vvacXzHTYGbkcoLw57Fx1NiN+2//uJBIBE1EyKSwfIZsqztPvTYAp63Zw32xg1OB+Pm\n\tMngH8OQufXZMhutcROwlBfon+g/syQGT1jFaIYEMsE3g88N8fznB1UrhgJqvXcK6SnX+\n\tEIHdGE1HKFgBgZju7+iXAa0UXxI6wcTfxgctsm0DQQS/PzhUGZtIK2Zwb6Ewj3Vi1lJp\n\tmZMsAPdNgsnaFGWsZ2o36La2i7+eIrlTO2aiDXrsYjRognQc9PrwHfi8hEecJL+Lwmyc\n\tatXg==", "X-Gm-Message-State": "AMke39k5e4HUlHm+s7ZWwqcCpAP+k6mK3JGtZ3iPAqjh/snFkMwdLgLiguI6anyl9n+SSg==", "X-Received": "by 10.28.8.130 with SMTP id 124mr2994014wmi.65.1486248549949;\n\tSat, 04 Feb 2017 14:49:09 -0800 (PST)", "From": "Philippe Reynes <tremyfr@gmail.com>", "To": "jeffrey.t.kirsher@intel.com,\n\tdavem@davemloft.net", "Date": "Sat, 4 Feb 2017 23:49:03 +0100", "Message-Id": "<1486248543-14722-1-git-send-email-tremyfr@gmail.com>", "X-Mailer": "git-send-email 1.7.4.4", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org, Philippe Reynes <tremyfr@gmail.com>", "Subject": "[Intel-wired-lan] [PATCH] net: intel: i40evf: use new api\n\tethtool_{get|set}_link_ksettings", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The ethtool api {get|set}_settings is deprecated.\nWe move this driver to new api {get|set}_link_ksettings.\n\nAs I don't have the hardware, I'd be very pleased if\nsomeone may test this patch.\n\nSigned-off-by: Philippe Reynes <tremyfr@gmail.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c | 31 +++++++++----------\n 1 files changed, 15 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c b/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\nindex 272d600..122efbd 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\n@@ -64,51 +64,50 @@ struct i40evf_stats {\n \t(I40EVF_GLOBAL_STATS_LEN + I40EVF_QUEUE_STATS_LEN(_dev))\n \n /**\n- * i40evf_get_settings - Get Link Speed and Duplex settings\n+ * i40evf_get_link_ksettings - Get Link Speed and Duplex settings\n * @netdev: network interface device structure\n- * @ecmd: ethtool command\n+ * @cmd: ethtool command\n *\n * Reports speed/duplex settings. Because this is a VF, we don't know what\n * kind of link we really have, so we fake it.\n **/\n-static int i40evf_get_settings(struct net_device *netdev,\n-\t\t\t struct ethtool_cmd *ecmd)\n+static int i40evf_get_link_ksettings(struct net_device *netdev,\n+\t\t\t\t struct ethtool_link_ksettings *cmd)\n {\n \tstruct i40evf_adapter *adapter = netdev_priv(netdev);\n \n-\tecmd->supported = 0;\n-\tecmd->autoneg = AUTONEG_DISABLE;\n-\tecmd->transceiver = XCVR_DUMMY1;\n-\tecmd->port = PORT_NONE;\n+\tethtool_link_ksettings_zero_link_mode(cmd, supported);\n+\tcmd->base.autoneg = AUTONEG_DISABLE;\n+\tcmd->base.port = PORT_NONE;\n \t/* Set speed and duplex */\n \tswitch (adapter->link_speed) {\n \tcase I40E_LINK_SPEED_40GB:\n-\t\tethtool_cmd_speed_set(ecmd, SPEED_40000);\n+\t\tcmd->base.speed = SPEED_40000;\n \t\tbreak;\n \tcase I40E_LINK_SPEED_25GB:\n #ifdef SPEED_25000\n-\t\tethtool_cmd_speed_set(ecmd, SPEED_25000);\n+\t\tcmd->base.speed = SPEED_25000;\n #else\n \t\tnetdev_info(netdev,\n \t\t\t \"Speed is 25G, display not supported by this version of ethtool.\\n\");\n #endif\n \t\tbreak;\n \tcase I40E_LINK_SPEED_20GB:\n-\t\tethtool_cmd_speed_set(ecmd, SPEED_20000);\n+\t\tcmd->base.speed = SPEED_20000;\n \t\tbreak;\n \tcase I40E_LINK_SPEED_10GB:\n-\t\tethtool_cmd_speed_set(ecmd, SPEED_10000);\n+\t\tcmd->base.speed = SPEED_10000;\n \t\tbreak;\n \tcase I40E_LINK_SPEED_1GB:\n-\t\tethtool_cmd_speed_set(ecmd, SPEED_1000);\n+\t\tcmd->base.speed = SPEED_1000;\n \t\tbreak;\n \tcase I40E_LINK_SPEED_100MB:\n-\t\tethtool_cmd_speed_set(ecmd, SPEED_100);\n+\t\tcmd->base.speed = SPEED_100;\n \t\tbreak;\n \tdefault:\n \t\tbreak;\n \t}\n-\tecmd->duplex = DUPLEX_FULL;\n+\tcmd->base.duplex = DUPLEX_FULL;\n \n \treturn 0;\n }\n@@ -643,7 +642,6 @@ static int i40evf_set_rxfh(struct net_device *netdev, const u32 *indir,\n }\n \n static const struct ethtool_ops i40evf_ethtool_ops = {\n-\t.get_settings\t\t= i40evf_get_settings,\n \t.get_drvinfo\t\t= i40evf_get_drvinfo,\n \t.get_link\t\t= ethtool_op_get_link,\n \t.get_ringparam\t\t= i40evf_get_ringparam,\n@@ -663,6 +661,7 @@ static int i40evf_set_rxfh(struct net_device *netdev, const u32 *indir,\n \t.set_rxfh\t\t= i40evf_set_rxfh,\n \t.get_channels\t\t= i40evf_get_channels,\n \t.get_rxfh_key_size\t= i40evf_get_rxfh_key_size,\n+\t.get_link_ksettings\t= i40evf_get_link_ksettings,\n };\n \n /**\n", "prefixes": [] }