Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/714722/?format=api
{ "id": 714722, "url": "http://patchwork.ozlabs.org/api/patches/714722/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170113010414.22708-1-bpoirier@suse.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170113010414.22708-1-bpoirier@suse.com>", "list_archive_url": null, "date": "2017-01-13T01:04:14", "name": "i40e: Invoke softirqs after napi_reschedule", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b0f3fce16b598e5ecb4997a571e14f2e8f9a8d56", "submitter": { "id": 67008, "url": "http://patchwork.ozlabs.org/api/people/67008/?format=api", "name": "Benjamin Poirier", "email": "bpoirier@suse.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170113010414.22708-1-bpoirier@suse.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/714722/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/714722/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3v04Dg0xBRz9t1H\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 13 Jan 2017 12:05:22 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 84639308F4;\n\tFri, 13 Jan 2017 01:05:20 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9+wZNabd7MQV; Fri, 13 Jan 2017 01:05:19 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6175D30892;\n\tFri, 13 Jan 2017 01:05:19 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6BABB1C0F86\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 13 Jan 2017 01:05:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 68219892EC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 13 Jan 2017 01:05:18 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dlXZQHy-09P2 for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 13 Jan 2017 01:05:17 +0000 (UTC)", "from mail-pf0-f194.google.com (mail-pf0-f194.google.com\n\t[209.85.192.194])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 4BE30891D0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 13 Jan 2017 01:05:17 +0000 (UTC)", "by mail-pf0-f194.google.com with SMTP id f144so5671045pfa.2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 Jan 2017 17:05:17 -0800 (PST)", "from f1.synalogic.ca (mobile-166-171-251-076.mycingular.net.\n\t[166.171.251.76]) by smtp.gmail.com with ESMTPSA id\n\tt87sm19580617pfe.59.2017.01.12.17.05.15\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 12 Jan 2017 17:05:16 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"TFessgYc\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id;\n\tbh=woMUwfKkPJzVlCZqzOw3LI9viFvHKxVtva+7/GWZ3iY=;\n\tb=TFessgYc2gA4IK+CAHYuKAD18stbQet8RHftdS/fEuFvjlXagqttBC1FFEmb5yIkHY\n\tdNGkzA0eEw00FtwEica3cm4V3Fb6v+A97MtG+MGJeN+BC8zEzQ6R//EObqgR9QtMWpqZ\n\ts1Qjw5kZPhvSmk760+UEZZSXhOUAhPQO+qDS0APkVkAL9XpEJo5yCrKdlBRfhad4Ma1g\n\tF2gPwR+7Y/B9mH7teVloH6Ou/wTUbkKofVjgKK7PZjxcvWUuLyeT5fucnzaBclDQY/+J\n\tO66e8gwDnrWGvjY+kef6+7xrJACq32ihPagpnVXxUq+3zwMYBZmtbdYeNJfYqivFDTeo\n\tJ6AQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id;\n\tbh=woMUwfKkPJzVlCZqzOw3LI9viFvHKxVtva+7/GWZ3iY=;\n\tb=CUYVUQxKRDNRQF1Bx4D3uG/jNfyVAV386m8h4M2eFNPAs43lgKfb4HR50oXbunc7yB\n\tGoEzhXSmeQ6P12Q2qmNDkNf0C7jGg/oUPcnPiBi6gnvUptUib0Np4/dlKzwQfnbCEV6R\n\tKS1+EM9eafOVAda/rEKJHdfWz3sx8nV1cfAs4D3qJU4WzodUz1PF84VYhOuheSwDtTW7\n\tA9ZJdK6eXefx6CjPfjfqrtSgn7jBa514+nrm3xawsDagkujI96TRrz85IisKifLLSu+6\n\tKgUqopX6TFMosMTwigTGiHxNUoB6qJk941pOQ3+uYmyLIPfReU4NcXeEqHh0YG5maFHz\n\tEoUA==", "X-Gm-Message-State": "AIkVDXLkWdszcEUKSWkASYXPd4A7X9ipg5cBCGrHGbTkwvAdh3AS0lj/WW7WayrgS1v23g==", "X-Received": "by 10.99.126.68 with SMTP id o4mr20999569pgn.66.1484269516891;\n\tThu, 12 Jan 2017 17:05:16 -0800 (PST)", "From": "Benjamin Poirier <bpoirier@suse.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Thu, 12 Jan 2017 17:04:14 -0800", "Message-Id": "<20170113010414.22708-1-bpoirier@suse.com>", "X-Mailer": "git-send-email 2.10.2", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "Subject": "[Intel-wired-lan] [PATCH] i40e: Invoke softirqs after\n\tnapi_reschedule", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The following message is logged from time to time when using i40e:\nNOHZ: local_softirq_pending 08\n\ni40e may schedule napi from a workqueue. Afterwards, softirqs are not run\nin a deterministic time frame. The problem is the same as what was\ndescribed in commit ec13ee80145c (\"virtio_net: invoke softirqs after\n__napi_schedule\") and this patch applies the same fix to i40e.\n\nSigned-off-by: Benjamin Poirier <bpoirier@suse.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex ad4cf63..d65488c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -4621,8 +4621,10 @@ static void i40e_detect_recover_hung_queue(int q_idx, struct i40e_vsi *vsi)\n \t */\n \tif ((!tx_pending_hw) && i40e_get_tx_pending(tx_ring, true) &&\n \t (!(val & I40E_PFINT_DYN_CTLN_INTENA_MASK))) {\n+\t\tlocal_bh_disable();\n \t\tif (napi_reschedule(&tx_ring->q_vector->napi))\n \t\t\ttx_ring->tx_stats.tx_lost_interrupt++;\n+\t\tlocal_bh_enable();\n \t}\n }\n \n", "prefixes": [] }