Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/712001/?format=api
{ "id": 712001, "url": "http://patchwork.ozlabs.org/api/patches/712001/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170106160743.1501.31101.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170106160743.1501.31101.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-01-06T16:07:45", "name": "[next,10/11] ixgbe: Add support for build_skb", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a91657e63f5084ce8a8ab7ea7c7aed37c74185a5", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170106160743.1501.31101.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/712001/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/712001/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tw8lK008Kz9ryZ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 7 Jan 2017 03:14:52 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8DEA38707F;\n\tFri, 6 Jan 2017 16:14:51 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wAQoeJXC016M; Fri, 6 Jan 2017 16:14:49 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id AD177823C9;\n\tFri, 6 Jan 2017 16:14:49 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 216391BFA57\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 6 Jan 2017 16:14:48 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1B3382A0DE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 6 Jan 2017 16:14:48 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id R8eI8kGaPVkk for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 6 Jan 2017 16:14:47 +0000 (UTC)", "from mail-pg0-f66.google.com (mail-pg0-f66.google.com\n\t[74.125.83.66])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 348C227329\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 6 Jan 2017 16:14:47 +0000 (UTC)", "by mail-pg0-f66.google.com with SMTP id 75so6207109pgf.3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 06 Jan 2017 08:14:47 -0800 (PST)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\ty189sm160917624pfy.32.2017.01.06.08.07.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 06 Jan 2017 08:07:46 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"GhIEQZTq\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-transfer-encoding;\n\tbh=bM2lEfamsxuVR5CLC9OYQ72+SMrfnf4BJfgDQQf07aE=;\n\tb=GhIEQZTq/p4udOZbnCKaJmXe0TjACYqTqAJmH91oD4aIhWXEFEYzALmWbqQZReCL8l\n\tqUaBZ/3owWSRW/rSxvbVx4oPJmnWQ9nvjZf9gRn07CqAxXme+etgLmCmSQu9UbMmq27Q\n\tlagkesbgoUwaJuVdXHbcBNbLzSjinWL3mfrCe7nOi0EmNi0VtLd7Ne2z+sT0Pf/vdWz5\n\tzQU3Fy/QVOMygoL8M9yKuzIU6LO8r+22wZC5qD1tOzCyhleccsEED5sHmnIVylTlx6vi\n\tObDYubsFmpdP4zFCiCIhPNxltaNUdZBRhI/3WwMDNEBb6T84pnzuMgrcJ4UBhwSRvSzh\n\tXvSA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=bM2lEfamsxuVR5CLC9OYQ72+SMrfnf4BJfgDQQf07aE=;\n\tb=OF04pqcUt4boeWOfdIm+60y7k/XHjaK6QevzLSfKr3jp1r0oj0PCe+I63EKla3mwUk\n\t+gBw6Ygpcok2JsA+VKhHpjUjwxKiUB08z+tKqUVpQlndZLqUinxFkmKH/bEIeKRpZVwz\n\tvsHnUC+MuBbr+U9NoshOio0JgCFK2A4fz/yLt/aWfU/Osr4FKVK9K31gB/TXYFuJO3XW\n\tqL/rPmG1XY9Txa0OwHS6stQhE4aacDKPvhxh9unWguzTt32qt3MMuf4t3ycq0A38hrlY\n\tTH/NpZ4rVWNX22GilZNhh0xo0jO+WOQDfZ+FtwU8csjtTx72vMZT2oDEA+e7fSZ4uoi+\n\tBC5g==", "X-Gm-Message-State": "AIkVDXKnxU18OVtaOB4Sz1NibtfnhOaKibY9m5z9yr4uMAWwB9eYiOLa6nEo+bZeNbEcuQ==", "X-Received": "by 10.84.199.194 with SMTP id d2mr14349297plh.134.1483718866611; \n\tFri, 06 Jan 2017 08:07:46 -0800 (PST)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Fri, 06 Jan 2017 08:07:45 -0800", "Message-ID": "<20170106160743.1501.31101.stgit@localhost.localdomain>", "In-Reply-To": "<20170106155448.1501.31298.stgit@localhost.localdomain>", "References": "<20170106155448.1501.31298.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Cc": "netdev@vger.kernel.org", "Subject": "[Intel-wired-lan] [next PATCH 10/11] ixgbe: Add support for\n\tbuild_skb", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThis patch adds build_skb support to the Rx path. There are several\nadvantages to this change.\n\n1. It avoids the memcpy and skb->head allocation for small packets which\n improves performance by about 5% in my tests.\n2. It avoids the memcpy, skb->head allocation, and eth_get_headlen\n for larger packets improving performance by about 10% in my tests.\n3. For VXLAN packets it allows the full header to be in skb->data which\n improves the performance by as much as 30% in some of my tests.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 49 ++++++++++++++++++++++++-\n 1 file changed, 48 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 8529eafb9717..dd04b76ae0bd 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -1913,7 +1913,7 @@ static bool ixgbe_cleanup_headers(struct ixgbe_ring *rx_ring,\n \t}\n \n \t/* place header in linear portion of buffer */\n-\tif (skb_is_nonlinear(skb))\n+\tif (!skb_headlen(skb))\n \t\tixgbe_pull_tail(rx_ring, skb);\n \n #ifdef IXGBE_FCOE\n@@ -2142,6 +2142,49 @@ static struct sk_buff *ixgbe_construct_skb(struct ixgbe_ring *rx_ring,\n \treturn skb;\n }\n \n+static struct sk_buff *ixgbe_build_skb(struct ixgbe_ring *rx_ring,\n+\t\t\t\t struct ixgbe_rx_buffer *rx_buffer,\n+\t\t\t\t union ixgbe_adv_rx_desc *rx_desc,\n+\t\t\t\t unsigned int size)\n+{\n+\tvoid *va = page_address(rx_buffer->page) + rx_buffer->page_offset;\n+#if (PAGE_SIZE < 8192)\n+\tunsigned int truesize = ixgbe_rx_pg_size(rx_ring) / 2;\n+#else\n+\tunsigned int truesize = SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) +\n+\t\t\t\tSKB_DATA_ALIGN(IXGBE_SKB_PAD + size);\n+#endif\n+\tstruct sk_buff *skb;\n+\n+\t/* prefetch first cache line of first page */\n+\tprefetch(va);\n+#if L1_CACHE_BYTES < 128\n+\tprefetch(va + L1_CACHE_BYTES);\n+#endif\n+\n+\t/* build an skb to around the page buffer */\n+\tskb = build_skb(va - IXGBE_SKB_PAD, truesize);\n+\tif (unlikely(!skb))\n+\t\treturn NULL;\n+\n+\t/* update pointers within the skb to store the data */\n+\tskb_reserve(skb, IXGBE_SKB_PAD);\n+\t__skb_put(skb, size);\n+\n+\t/* record DMA address if this is the start of a chain of buffers */\n+\tif (!ixgbe_test_staterr(rx_desc, IXGBE_RXD_STAT_EOP))\n+\t\tIXGBE_CB(skb)->dma = rx_buffer->dma;\n+\n+\t/* update buffer offset */\n+#if (PAGE_SIZE < 8192)\n+\trx_buffer->page_offset ^= truesize;\n+#else\n+\trx_buffer->page_offset += truesize;\n+#endif\n+\n+\treturn skb;\n+}\n+\n /**\n * ixgbe_clean_rx_irq - Clean completed descriptors from Rx ring - bounce buf\n * @q_vector: structure containing interrupt and ring information\n@@ -2195,6 +2238,9 @@ static int ixgbe_clean_rx_irq(struct ixgbe_q_vector *q_vector,\n \t\t/* retrieve a buffer from the ring */\n \t\tif (skb)\n \t\t\tixgbe_add_rx_frag(rx_ring, rx_buffer, skb, size);\n+\t\telse if (ring_uses_build_skb(rx_ring))\n+\t\t\tskb = ixgbe_build_skb(rx_ring, rx_buffer,\n+\t\t\t\t\t rx_desc, size);\n \t\telse\n \t\t\tskb = ixgbe_construct_skb(rx_ring, rx_buffer,\n \t\t\t\t\t\t rx_desc, size);\n@@ -3970,6 +4016,7 @@ static void ixgbe_set_rx_buffer_len(struct ixgbe_adapter *adapter)\n \t\tif (test_bit(__IXGBE_RX_FCOE, &rx_ring->state))\n \t\t\tset_bit(__IXGBE_RX_3K_BUFFER, &rx_ring->state);\n \n+\t\tclear_bit(__IXGBE_RX_BUILD_SKB_ENABLED, &rx_ring->state);\n \t\tif (adapter->flags2 & IXGBE_FLAG2_RX_LEGACY)\n \t\t\tcontinue;\n \n", "prefixes": [ "next", "10/11" ] }