Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/711977/?format=api
{ "id": 711977, "url": "http://patchwork.ozlabs.org/api/patches/711977/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170106160711.1501.3612.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170106160711.1501.3612.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-01-06T16:07:13", "name": "[next,06/11] ixgbe: Use length to determine if descriptor is done", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "abc6e8202e87d706b5cc799a35d8a411d4d0bf4c", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170106160711.1501.3612.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/711977/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/711977/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tw8Zh47H9z9sfH\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 7 Jan 2017 03:07:24 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 19A4685AD9;\n\tFri, 6 Jan 2017 16:07:23 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id vva-iBs76dFt; Fri, 6 Jan 2017 16:07:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 00B3885A7F;\n\tFri, 6 Jan 2017 16:07:16 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 313FD1BFA57\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 6 Jan 2017 16:07:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2D6EE89423\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 6 Jan 2017 16:07:15 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gcyIU6GLxnuO for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 6 Jan 2017 16:07:14 +0000 (UTC)", "from mail-pg0-f66.google.com (mail-pg0-f66.google.com\n\t[74.125.83.66])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 752BB87F55\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 6 Jan 2017 16:07:14 +0000 (UTC)", "by mail-pg0-f66.google.com with SMTP id b1so44397779pgc.1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 06 Jan 2017 08:07:14 -0800 (PST)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\te11sm162573521pgp.10.2017.01.06.08.07.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 06 Jan 2017 08:07:13 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"FGA2V5o6\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-transfer-encoding;\n\tbh=e3UDAqcr1BfKGTYBSQbqpza2n27rYk0GrUd8vWzvFJQ=;\n\tb=FGA2V5o6sR1ezGfW/XZy6cp96/6JMG9Fqcaa3xaAdwMRulTn84q1wPgysnjgaqA+OX\n\tqcmwUEM6Ha7siuRXTk1oZG3laiQDkvU277TqYrCZHRO5bMogKNB5xgtynBEbxLrJTg5y\n\tR7QhxZywQXgocZdt3uytATx6FZvu2tQ/31qZm8o8M9DaTmaZngXrY0TwBU61FMipu1FE\n\t+M/9mSwk5WoblJNExCVQvwl+JvkdrVlSadrf82CGGax0H4h6cmGllcPf2pH4niOLiVdT\n\tDtmDC80Kr69KTQDsPBaMpSeEnakeyL0yZ5ei56PCFl/ELG21IrHwMaNjq9dK7oFv00pr\n\tty4Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=e3UDAqcr1BfKGTYBSQbqpza2n27rYk0GrUd8vWzvFJQ=;\n\tb=emzJUICQNWy+CzpHQtqpw1ZCb83Y82U6FGDicrBGxc5P218MRJa8cjjDpKquN/uard\n\t5jUzX8ZZs6WrfzDsk1jKV6cXA0YNdKmhYUunqqSiralnD8JjXkB4ZpM0IPg8sBZ5KoKB\n\tlPNkTncleUv8zaAhi4hgdoV7pOP+374eRJDLpNa9jQ3O21/+8sM/MOmECYOyfH159zkM\n\tLSJKzBE8bWDV7MD2kAmb8KIM7twk0GUqeCvtzJdrXDHEfz7XFaqpA3B0z1/X4MV316Nh\n\tlENFvvCledLQNXtqnK0Ghtp+BtIzabccAhdW7EKWp+QJycwpj9dG7U+5WbmJjrSZnmeB\n\te3dQ==", "X-Gm-Message-State": "AIkVDXKAgsnxyHa+PF9HmFM7E94ZIa/P0SjLuXQArpa8zvfZcPLVj8zA4upUJxnYI1Cw8A==", "X-Received": "by 10.99.170.5 with SMTP id e5mr144351048pgf.46.1483718834034;\n\tFri, 06 Jan 2017 08:07:14 -0800 (PST)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Fri, 06 Jan 2017 08:07:13 -0800", "Message-ID": "<20170106160711.1501.3612.stgit@localhost.localdomain>", "In-Reply-To": "<20170106155448.1501.31298.stgit@localhost.localdomain>", "References": "<20170106155448.1501.31298.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Cc": "netdev@vger.kernel.org", "Subject": "[Intel-wired-lan] [next PATCH 06/11] ixgbe: Use length to determine\n\tif descriptor is done", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThis change makes it so that we use the length of the packet instead of the\nDD status bit to determine if a new descriptor is ready to be processed.\nThe obvious advantage is that it cuts down on reads as we don't really even\nneed the DD bit if going from a 0 to a non-zero value on size is enough to\ninform us that the packet has been completed.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 1b6f1f584044..6ce596816954 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -1653,8 +1653,8 @@ void ixgbe_alloc_rx_buffers(struct ixgbe_ring *rx_ring, u16 cleaned_count)\n \t\t\ti -= rx_ring->count;\n \t\t}\n \n-\t\t/* clear the status bits for the next_to_use descriptor */\n-\t\trx_desc->wb.upper.status_error = 0;\n+\t\t/* clear the length for the next_to_use descriptor */\n+\t\trx_desc->wb.upper.length = 0;\n \n \t\tcleaned_count--;\n \t} while (cleaned_count);\n@@ -2170,7 +2170,7 @@ static int ixgbe_clean_rx_irq(struct ixgbe_q_vector *q_vector,\n \n \t\trx_desc = IXGBE_RX_DESC(rx_ring, rx_ring->next_to_clean);\n \n-\t\tif (!rx_desc->wb.upper.status_error)\n+\t\tif (!rx_desc->wb.upper.length)\n \t\t\tbreak;\n \n \t\t/* This memory barrier is needed to keep us from reading\n@@ -3749,6 +3749,7 @@ void ixgbe_configure_rx_ring(struct ixgbe_adapter *adapter,\n \t\t\t struct ixgbe_ring *ring)\n {\n \tstruct ixgbe_hw *hw = &adapter->hw;\n+\tunion ixgbe_adv_rx_desc *rx_desc;\n \tu64 rdba = ring->dma;\n \tu32 rxdctl;\n \tu8 reg_idx = ring->reg_idx;\n@@ -3783,6 +3784,10 @@ void ixgbe_configure_rx_ring(struct ixgbe_adapter *adapter,\n \t\trxdctl |= 0x080420;\n \t}\n \n+\t/* initialize Rx descriptor 0 */\n+\trx_desc = IXGBE_RX_DESC(ring, 0);\n+\trx_desc->wb.upper.length = 0;\n+\n \t/* enable receive descriptor ring */\n \trxdctl |= IXGBE_RXDCTL_ENABLE;\n \tIXGBE_WRITE_REG(hw, IXGBE_RXDCTL(reg_idx), rxdctl);\n@@ -4998,9 +5003,6 @@ static void ixgbe_clean_rx_ring(struct ixgbe_ring *rx_ring)\n \tsize = sizeof(struct ixgbe_rx_buffer) * rx_ring->count;\n \tmemset(rx_ring->rx_buffer_info, 0, size);\n \n-\t/* Zero out the descriptor ring */\n-\tmemset(rx_ring->desc, 0, rx_ring->size);\n-\n \trx_ring->next_to_alloc = 0;\n \trx_ring->next_to_clean = 0;\n \trx_ring->next_to_use = 0;\n", "prefixes": [ "next", "06/11" ] }