Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/710800/?format=api
{ "id": 710800, "url": "http://patchwork.ozlabs.org/api/patches/710800/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170104023954.13451.5678.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170104023954.13451.5678.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-01-04T02:41:51", "name": "[next,v4,2/3] mm: Rename __page_frag functions to __page_frag_cache, drop order from drain", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6c88d71232b689487ae858be0072a03c732446bb", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170104023954.13451.5678.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/710800/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/710800/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ttZpF3kq6z9sxS\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 4 Jan 2017 13:41:57 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0D3612E78C;\n\tWed, 4 Jan 2017 02:41:56 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MMhmMKF2wMbb; Wed, 4 Jan 2017 02:41:53 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 894402E46D;\n\tWed, 4 Jan 2017 02:41:53 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 05D0D1C0028\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 4 Jan 2017 02:41:53 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id F3DF0865A9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 4 Jan 2017 02:41:52 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xe-ts0C3p7Nt for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 4 Jan 2017 02:41:52 +0000 (UTC)", "from mail-pf0-f195.google.com (mail-pf0-f195.google.com\n\t[209.85.192.195])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 72A6D86544\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 4 Jan 2017 02:41:52 +0000 (UTC)", "by mail-pf0-f195.google.com with SMTP id c4so26334663pfb.3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 03 Jan 2017 18:41:52 -0800 (PST)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\tv82sm142777201pfi.6.2017.01.03.18.41.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 03 Jan 2017 18:41:51 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"rMkWjdVV\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-transfer-encoding;\n\tbh=iYq9/E7jdxOO2Mo/Mevw9gXyxAg1xa8SbeqzU0fyJQ8=;\n\tb=rMkWjdVVXFtyq/uCAYDTesOScnq/20NCCfb849ASoctxXKrIVJq3CzR/ImItNu8MQF\n\t2PdZ8yGJwxmJDvVbQhBwTqaOzxFq9nLlL8xt7PPN/uEspIzvlZVmBXOiA7GKKBNickXj\n\tIhlhByUDO1taJU0WEkYgj6elx3mXiDrZsr3uN9hixtfBoHcmXq0ScgQM27nw1ZSAvZWo\n\t6eS6EwRTE1z2wcohMiDrSk3KfUfAFjsVVqyhQyVgnQBTkPZVfZOATBrtG3+TGCxEpOuj\n\tAgX7bTovjUf2oskqdYtkF5KJVaP2PLsTX8vG1NrVN0ZyMR/OR3w+M9poUzBXKgwZ1yyi\n\t05Fg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=iYq9/E7jdxOO2Mo/Mevw9gXyxAg1xa8SbeqzU0fyJQ8=;\n\tb=GV6Qwgi65t9HDKBhUR8K+e4o9HNK6hu+49xxilTYDizyGx+b2syM6NJle6wI3JHRNu\n\t2fqJwjhchsNCE8Of4oc16Phoj7hXFitn2TkaCkLY0hmB0BxFZDJ8EMtr4DUQuKmccLc3\n\tDchPwNrD+0QK5APBicDxt64H1onPR+88QSsPFw7X5Trdy6UUDS8UTlHGroNjqwLO1LFI\n\tHc4byEAgerBTTHBGEPtVtip/uyLlYD+DNhLLEU1Ms7A8AC3yG2Z4yCDL68rrO+Y/sYhB\n\tgPRMCwBcKPxReIcrEGBNRs9ht9bBvX4dZtjK3goxIruNA+sbYR16zGHr/nfmvr/IArAI\n\tO97A==", "X-Gm-Message-State": "AIkVDXJnBYqZ1tyeQbggIofD1nb+wjUpNVX1MNBltrPsk0xjIsH6TDNr4jUW1J9+Q1Liwg==", "X-Received": "by 10.99.207.17 with SMTP id j17mr117434727pgg.57.1483497712136; \n\tTue, 03 Jan 2017 18:41:52 -0800 (PST)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Tue, 03 Jan 2017 18:41:51 -0800", "Message-ID": "<20170104023954.13451.5678.stgit@localhost.localdomain>", "In-Reply-To": "<20170104023620.13451.80691.stgit@localhost.localdomain>", "References": "<20170104023620.13451.80691.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Cc": "linux-mm@kvack.org, akpm@linux-foundation.org,\n\tlinux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [next PATCH v4 2/3] mm: Rename __page_frag\n\tfunctions to __page_frag_cache, drop order from drain", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThis patch does two things.\n\nFirst it goes through and renames the __page_frag prefixed functions to\n__page_frag_cache so that we can be clear that we are draining or refilling\nthe cache, not the frags themselves.\n\nSecond we drop the order parameter from __page_frag_cache_drain since we\ndon't actually need to pass it since all fragments are either order 0 or\nmust be a compound page.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n\nv2: No change\nv3: No change (in theory)\nv4: Pulled out page_frag_alloc rename bits which had leaked through due to me\n trying out reordering some patches in my own queue.\n\n drivers/net/ethernet/intel/igb/igb_main.c | 6 +++---\n include/linux/gfp.h | 3 +--\n mm/page_alloc.c | 13 +++++++------\n 3 files changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 594604e09f8d..cb08900c9cf2 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -3964,8 +3964,8 @@ static void igb_clean_rx_ring(struct igb_ring *rx_ring)\n \t\t\t\t PAGE_SIZE,\n \t\t\t\t DMA_FROM_DEVICE,\n \t\t\t\t DMA_ATTR_SKIP_CPU_SYNC);\n-\t\t__page_frag_drain(buffer_info->page, 0,\n-\t\t\t\t buffer_info->pagecnt_bias);\n+\t\t__page_frag_cache_drain(buffer_info->page,\n+\t\t\t\t\tbuffer_info->pagecnt_bias);\n \n \t\tbuffer_info->page = NULL;\n \t}\n@@ -6993,7 +6993,7 @@ static struct sk_buff *igb_fetch_rx_buffer(struct igb_ring *rx_ring,\n \t\tdma_unmap_page_attrs(rx_ring->dev, rx_buffer->dma,\n \t\t\t\t PAGE_SIZE, DMA_FROM_DEVICE,\n \t\t\t\t DMA_ATTR_SKIP_CPU_SYNC);\n-\t\t__page_frag_drain(page, 0, rx_buffer->pagecnt_bias);\n+\t\t__page_frag_cache_drain(page, rx_buffer->pagecnt_bias);\n \t}\n \n \t/* clear contents of rx_buffer */\ndiff --git a/include/linux/gfp.h b/include/linux/gfp.h\nindex 6238c74e0a01..884080404e24 100644\n--- a/include/linux/gfp.h\n+++ b/include/linux/gfp.h\n@@ -506,8 +506,7 @@ extern struct page *alloc_pages_vma(gfp_t gfp_mask, int order,\n extern void free_hot_cold_page_list(struct list_head *list, bool cold);\n \n struct page_frag_cache;\n-extern void __page_frag_drain(struct page *page, unsigned int order,\n-\t\t\t unsigned int count);\n+extern void __page_frag_cache_drain(struct page *page, unsigned int count);\n extern void *page_frag_alloc(struct page_frag_cache *nc,\n \t\t\t unsigned int fragsz, gfp_t gfp_mask);\n extern void page_frag_free(void *addr);\ndiff --git a/mm/page_alloc.c b/mm/page_alloc.c\nindex 9534e44308b2..4b0541cd3699 100644\n--- a/mm/page_alloc.c\n+++ b/mm/page_alloc.c\n@@ -3904,8 +3904,8 @@ void free_pages(unsigned long addr, unsigned int order)\n * drivers to provide a backing region of memory for use as either an\n * sk_buff->head, or to be used in the \"frags\" portion of skb_shared_info.\n */\n-static struct page *__page_frag_refill(struct page_frag_cache *nc,\n-\t\t\t\t gfp_t gfp_mask)\n+static struct page *__page_frag_cache_refill(struct page_frag_cache *nc,\n+\t\t\t\t\t gfp_t gfp_mask)\n {\n \tstruct page *page = NULL;\n \tgfp_t gfp = gfp_mask;\n@@ -3925,19 +3925,20 @@ static struct page *__page_frag_refill(struct page_frag_cache *nc,\n \treturn page;\n }\n \n-void __page_frag_drain(struct page *page, unsigned int order,\n-\t\t unsigned int count)\n+void __page_frag_cache_drain(struct page *page, unsigned int count)\n {\n \tVM_BUG_ON_PAGE(page_ref_count(page) == 0, page);\n \n \tif (page_ref_sub_and_test(page, count)) {\n+\t\tunsigned int order = compound_order(page);\n+\n \t\tif (order == 0)\n \t\t\tfree_hot_cold_page(page, false);\n \t\telse\n \t\t\t__free_pages_ok(page, order);\n \t}\n }\n-EXPORT_SYMBOL(__page_frag_drain);\n+EXPORT_SYMBOL(__page_frag_cache_drain);\n \n void *page_frag_alloc(struct page_frag_cache *nc,\n \t\t unsigned int fragsz, gfp_t gfp_mask)\n@@ -3948,7 +3949,7 @@ void *page_frag_alloc(struct page_frag_cache *nc,\n \n \tif (unlikely(!nc->va)) {\n refill:\n-\t\tpage = __page_frag_refill(nc, gfp_mask);\n+\t\tpage = __page_frag_cache_refill(nc, gfp_mask);\n \t\tif (!page)\n \t\t\treturn NULL;\n \n", "prefixes": [ "next", "v4", "2/3" ] }