Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/710799/?format=api
{ "id": 710799, "url": "http://patchwork.ozlabs.org/api/patches/710799/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170104023854.13451.67390.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170104023854.13451.67390.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-01-04T02:39:48", "name": "[next,v4,1/3] mm: Rename __alloc_page_frag to page_frag_alloc and __free_page_frag to page_frag_free", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7e132bd7e0b02fb78cc465d6cbf7d3a44364bd8f", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170104023854.13451.67390.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/710799/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/710799/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ttZlw0CG1z9sxS\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 4 Jan 2017 13:39:55 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 298172EE6E;\n\tWed, 4 Jan 2017 02:39:54 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3YkNmaxRMEuh; Wed, 4 Jan 2017 02:39:52 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 161A62E46D;\n\tWed, 4 Jan 2017 02:39:52 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7FF7E1C0028\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 4 Jan 2017 02:39:50 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7A15E86A62\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 4 Jan 2017 02:39:50 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nU87Bt5NsZNd for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 4 Jan 2017 02:39:49 +0000 (UTC)", "from mail-pg0-f67.google.com (mail-pg0-f67.google.com\n\t[74.125.83.67])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id B9EAD86A5B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 4 Jan 2017 02:39:49 +0000 (UTC)", "by mail-pg0-f67.google.com with SMTP id b1so35383548pgc.1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 03 Jan 2017 18:39:49 -0800 (PST)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\tr2sm142659964pfi.67.2017.01.03.18.39.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 03 Jan 2017 18:39:48 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"HJgDOAlb\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-transfer-encoding;\n\tbh=8dtG3Jc6wOYxW8HbALCIaDKL+79EAS/rAdLfEHVdZvw=;\n\tb=HJgDOAlbn/5ia1CPdKkmd8ZMGprDNiKt6zjBefcssQBYfzRceLASTA7HEhhVHd0NOu\n\tIWVB9JSvzNQddO1t2ltjMiF1uQrEYvpAVKQzV61Y/FzbfdIYdN9ff8ZOva5rkWyyKgft\n\tpt5opwwwfPxD2Dlmqvd379VUmlknu+WneXIIDUeQZocfZ71B/+Q1o6y5aO8AkS7Z/oBE\n\tcbp61+ZLUB2/mqVP8Wxil1Ihm9NWXfV3HfJXWfGc3hSsymDQwp9kdq3e1yd9hDVu24jz\n\td7wAoN1PXKoDFqsDEYJZBIKiKpBUlOc48p+zdqijiVcIwmDoKGbkPmrZ2LO2Vxtw+Z87\n\tgqjg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=8dtG3Jc6wOYxW8HbALCIaDKL+79EAS/rAdLfEHVdZvw=;\n\tb=paUdkquvcNY1ukTbH9eHRWfKYuYungt4Dt+X8xmDzvCmniI9j9x07U0mMPkwB6WGk8\n\tm4QstndLzyJG0WKe2pfgkNrg5Id9r1m5yv0XgQtPrmtLTwLfaspO1toJtioJlyeMeF43\n\tkvXtKyewWB6108GoeTzZ02IZmSvqg6TjfaF6GiPtc2CPmSnzgnmr5Rtf9tOpHbMIkzSi\n\toTIdJkuc98q43+Ow6dJAl6cCAGKzzpO3RlXX13yQRoeM7on7lzVjwitXBWlg4PRPA6hY\n\tfQISdWOnxQVi6Thdzi4QLmMK/dR8+Fj6OLddBLy44vkKXlGJwSX8Epd9IR6rbAF7pfsx\n\t0Gzw==", "X-Gm-Message-State": "AIkVDXJB3HIXUKsTL/hxvkOAAYnJ7Wf50dWeg2ES2SHAv7Bnils9RjpHkF08H4klw5BqDQ==", "X-Received": "by 10.84.206.37 with SMTP id f34mr141635687ple.35.1483497589407; \n\tTue, 03 Jan 2017 18:39:49 -0800 (PST)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Tue, 03 Jan 2017 18:39:48 -0800", "Message-ID": "<20170104023854.13451.67390.stgit@localhost.localdomain>", "In-Reply-To": "<20170104023620.13451.80691.stgit@localhost.localdomain>", "References": "<20170104023620.13451.80691.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Cc": "linux-mm@kvack.org, akpm@linux-foundation.org,\n\tlinux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [next PATCH v4 1/3] mm: Rename __alloc_page_frag\n\tto page_frag_alloc and __free_page_frag to page_frag_free", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThis patch renames the page frag functions to be more consistent with other\nAPIs. Specifically we place the name page_frag first in the name and then\nhave either an alloc or free call name that we append as the suffix. This\nmakes it a bit clearer in terms of naming.\n\nIn addition we drop the leading double underscores since we are technically\nno longer a backing interface and instead the front end that is called from\nthe networking APIs.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n\nv2: Fixed a comparison between a void* and 0 due to copy/paste from free_pages\nv3: Dropped changes to function and make this a rename patch only.\n This fixes a small performance regression I saw in some tests.\nv4: Added back page_frag_alloc which had leaked through to patch 2 after\n I had tried reordering them in my own queue.\n\n include/linux/gfp.h | 6 +++---\n include/linux/skbuff.h | 2 +-\n mm/page_alloc.c | 10 +++++-----\n net/core/skbuff.c | 8 ++++----\n 4 files changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/include/linux/gfp.h b/include/linux/gfp.h\nindex 4175dca4ac39..6238c74e0a01 100644\n--- a/include/linux/gfp.h\n+++ b/include/linux/gfp.h\n@@ -508,9 +508,9 @@ extern struct page *alloc_pages_vma(gfp_t gfp_mask, int order,\n struct page_frag_cache;\n extern void __page_frag_drain(struct page *page, unsigned int order,\n \t\t\t unsigned int count);\n-extern void *__alloc_page_frag(struct page_frag_cache *nc,\n-\t\t\t unsigned int fragsz, gfp_t gfp_mask);\n-extern void __free_page_frag(void *addr);\n+extern void *page_frag_alloc(struct page_frag_cache *nc,\n+\t\t\t unsigned int fragsz, gfp_t gfp_mask);\n+extern void page_frag_free(void *addr);\n \n #define __free_page(page) __free_pages((page), 0)\n #define free_page(addr) free_pages((addr), 0)\ndiff --git a/include/linux/skbuff.h b/include/linux/skbuff.h\nindex b53c0cfd417e..a410715bbef8 100644\n--- a/include/linux/skbuff.h\n+++ b/include/linux/skbuff.h\n@@ -2480,7 +2480,7 @@ static inline struct sk_buff *netdev_alloc_skb_ip_align(struct net_device *dev,\n \n static inline void skb_free_frag(void *addr)\n {\n-\t__free_page_frag(addr);\n+\tpage_frag_free(addr);\n }\n \n void *napi_alloc_frag(unsigned int fragsz);\ndiff --git a/mm/page_alloc.c b/mm/page_alloc.c\nindex 2c6d5f64feca..9534e44308b2 100644\n--- a/mm/page_alloc.c\n+++ b/mm/page_alloc.c\n@@ -3939,8 +3939,8 @@ void __page_frag_drain(struct page *page, unsigned int order,\n }\n EXPORT_SYMBOL(__page_frag_drain);\n \n-void *__alloc_page_frag(struct page_frag_cache *nc,\n-\t\t\tunsigned int fragsz, gfp_t gfp_mask)\n+void *page_frag_alloc(struct page_frag_cache *nc,\n+\t\t unsigned int fragsz, gfp_t gfp_mask)\n {\n \tunsigned int size = PAGE_SIZE;\n \tstruct page *page;\n@@ -3991,19 +3991,19 @@ void *__alloc_page_frag(struct page_frag_cache *nc,\n \n \treturn nc->va + offset;\n }\n-EXPORT_SYMBOL(__alloc_page_frag);\n+EXPORT_SYMBOL(page_frag_alloc);\n \n /*\n * Frees a page fragment allocated out of either a compound or order 0 page.\n */\n-void __free_page_frag(void *addr)\n+void page_frag_free(void *addr)\n {\n \tstruct page *page = virt_to_head_page(addr);\n \n \tif (unlikely(put_page_testzero(page)))\n \t\t__free_pages_ok(page, compound_order(page));\n }\n-EXPORT_SYMBOL(__free_page_frag);\n+EXPORT_SYMBOL(page_frag_free);\n \n static void *make_alloc_exact(unsigned long addr, unsigned int order,\n \t\tsize_t size)\ndiff --git a/net/core/skbuff.c b/net/core/skbuff.c\nindex 5a03730fbc1a..734c71468b01 100644\n--- a/net/core/skbuff.c\n+++ b/net/core/skbuff.c\n@@ -369,7 +369,7 @@ static void *__netdev_alloc_frag(unsigned int fragsz, gfp_t gfp_mask)\n \n \tlocal_irq_save(flags);\n \tnc = this_cpu_ptr(&netdev_alloc_cache);\n-\tdata = __alloc_page_frag(nc, fragsz, gfp_mask);\n+\tdata = page_frag_alloc(nc, fragsz, gfp_mask);\n \tlocal_irq_restore(flags);\n \treturn data;\n }\n@@ -391,7 +391,7 @@ static void *__napi_alloc_frag(unsigned int fragsz, gfp_t gfp_mask)\n {\n \tstruct napi_alloc_cache *nc = this_cpu_ptr(&napi_alloc_cache);\n \n-\treturn __alloc_page_frag(&nc->page, fragsz, gfp_mask);\n+\treturn page_frag_alloc(&nc->page, fragsz, gfp_mask);\n }\n \n void *napi_alloc_frag(unsigned int fragsz)\n@@ -441,7 +441,7 @@ struct sk_buff *__netdev_alloc_skb(struct net_device *dev, unsigned int len,\n \tlocal_irq_save(flags);\n \n \tnc = this_cpu_ptr(&netdev_alloc_cache);\n-\tdata = __alloc_page_frag(nc, len, gfp_mask);\n+\tdata = page_frag_alloc(nc, len, gfp_mask);\n \tpfmemalloc = nc->pfmemalloc;\n \n \tlocal_irq_restore(flags);\n@@ -505,7 +505,7 @@ struct sk_buff *__napi_alloc_skb(struct napi_struct *napi, unsigned int len,\n \tif (sk_memalloc_socks())\n \t\tgfp_mask |= __GFP_MEMALLOC;\n \n-\tdata = __alloc_page_frag(&nc->page, len, gfp_mask);\n+\tdata = page_frag_alloc(&nc->page, len, gfp_mask);\n \tif (unlikely(!data))\n \t\treturn NULL;\n \n", "prefixes": [ "next", "v4", "1/3" ] }