Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/705232/?format=api
{ "id": 705232, "url": "http://patchwork.ozlabs.org/api/patches/705232/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1481586257-28872-12-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1481586257-28872-12-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-12-12T23:44:17", "name": "[next,S57,11/11] i40e: mark the value passed to csum_replace_by_diff as __wsum", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1bed872c9919d7f267b72b00af7651bc4c0aa229", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1481586257-28872-12-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/705232/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/705232/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tczxp0qjNz9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 13 Dec 2016 10:46:22 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id A90632D201;\n\tMon, 12 Dec 2016 23:46:20 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Nrxj9u98lsPp; Mon, 12 Dec 2016 23:46:11 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 929E32D40D;\n\tMon, 12 Dec 2016 23:46:04 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 143F31C048D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Dec 2016 23:46:01 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 089E685F95\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Dec 2016 23:46:01 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9LIieBGGIO93 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Dec 2016 23:45:58 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 391CE861C8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Dec 2016 23:45:57 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga104.jf.intel.com with ESMTP; 12 Dec 2016 15:45:55 -0800", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.167])\n\tby orsmga003.jf.intel.com with ESMTP; 12 Dec 2016 15:45:55 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.33,339,1477983600\"; d=\"scan'208\";a=\"911471199\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 12 Dec 2016 15:44:17 -0800", "Message-Id": "<1481586257-28872-12-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1481586257-28872-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1481586257-28872-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S57 11/11] i40e: mark the value\n\tpassed to csum_replace_by_diff as __wsum", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nFix, or rather, avoid a sparse warning caused by the fact that\ncsum_replace_by_diff expects to receive a __wsum value. Since the\ncalculation appears to work, simply typecast the passed paylen value to\n__wsum to avoid the warning.\n\nThis seems pretty fishy since __wsum was obviously annotated as\na separate type on purpose, so this throws the entire calculation into\nquestion. Since it currently appears to behave as expected, the typecast\nis probably safe.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nChange-ID: I4fdc5cddd589abc16098176e8a61127e761488f4\n---\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 5 +++--\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 5 +++--\n 2 files changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex 8531f4b..a623de9 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -2335,7 +2335,8 @@ static int i40e_tso(struct i40e_tx_buffer *first, u8 *hdr_len,\n \n \t\t\t/* remove payload length from outer checksum */\n \t\t\tpaylen = skb->len - l4_offset;\n-\t\t\tcsum_replace_by_diff(&l4.udp->check, htonl(paylen));\n+\t\t\tcsum_replace_by_diff(&l4.udp->check,\n+\t\t\t\t\t (__force __wsum)htonl(paylen));\n \t\t}\n \n \t\t/* reset pointers to inner headers */\n@@ -2356,7 +2357,7 @@ static int i40e_tso(struct i40e_tx_buffer *first, u8 *hdr_len,\n \n \t/* remove payload length from inner checksum */\n \tpaylen = skb->len - l4_offset;\n-\tcsum_replace_by_diff(&l4.tcp->check, htonl(paylen));\n+\tcsum_replace_by_diff(&l4.tcp->check, (__force __wsum)htonl(paylen));\n \n \t/* compute length of segmentation header */\n \t*hdr_len = (l4.tcp->doff * 4) + l4_offset;\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex 45792dd..cd0e28f 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -1629,7 +1629,8 @@ static int i40e_tso(struct i40e_tx_buffer *first, u8 *hdr_len,\n \n \t\t\t/* remove payload length from outer checksum */\n \t\t\tpaylen = skb->len - l4_offset;\n-\t\t\tcsum_replace_by_diff(&l4.udp->check, htonl(paylen));\n+\t\t\tcsum_replace_by_diff(&l4.udp->check,\n+\t\t\t\t\t (__force __wsum)htonl(paylen));\n \t\t}\n \n \t\t/* reset pointers to inner headers */\n@@ -1650,7 +1651,7 @@ static int i40e_tso(struct i40e_tx_buffer *first, u8 *hdr_len,\n \n \t/* remove payload length from inner checksum */\n \tpaylen = skb->len - l4_offset;\n-\tcsum_replace_by_diff(&l4.tcp->check, htonl(paylen));\n+\tcsum_replace_by_diff(&l4.tcp->check, (__force __wsum)htonl(paylen));\n \n \t/* compute length of segmentation header */\n \t*hdr_len = (l4.tcp->doff * 4) + l4_offset;\n", "prefixes": [ "next", "S57", "11/11" ] }