Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/705231/?format=api
{ "id": 705231, "url": "http://patchwork.ozlabs.org/api/patches/705231/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1481586257-28872-8-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1481586257-28872-8-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-12-12T23:44:13", "name": "[next,S57,07/11] i40e: refactor AQ CMD buffer debug printing", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6b764e841761433399515d766ce5f331380048f4", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1481586257-28872-8-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/705231/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/705231/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tczxn29Grz9t10\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 13 Dec 2016 10:46:21 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D56C42CFC6;\n\tMon, 12 Dec 2016 23:46:19 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KnfGZKnAKILX; Mon, 12 Dec 2016 23:46:11 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 624572D3CF;\n\tMon, 12 Dec 2016 23:46:04 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id C67571C048D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Dec 2016 23:46:00 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C3EE885F95\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Dec 2016 23:46:00 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HRB12d6unrWF for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Dec 2016 23:45:58 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id D214B861C2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Dec 2016 23:45:56 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga104.jf.intel.com with ESMTP; 12 Dec 2016 15:45:55 -0800", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.167])\n\tby orsmga003.jf.intel.com with ESMTP; 12 Dec 2016 15:45:55 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.33,339,1477983600\"; d=\"scan'208\";a=\"911471188\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 12 Dec 2016 15:44:13 -0800", "Message-Id": "<1481586257-28872-8-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1481586257-28872-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1481586257-28872-1-git-send-email-bimmy.pujari@intel.com>", "Cc": "Alan Brady <alan.brady@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S57 07/11] i40e: refactor AQ CMD\n\tbuffer debug printing", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Alan Brady <alan.brady@intel.com>\n\nThis patch refactors the '%*ph' printk format specifier to instead use\nthe print_hex_dump function, as recommended by the '%*ph' documentation.\nThis produces better/more standardized output.\n\nSigned-off-by: Alan Brady <alan.brady@intel.com>\nChange-ID: Id56700b4e8abc40ff8c04bc8379e7df04cb4d6fd\n---\n drivers/net/ethernet/intel/i40e/i40e_common.c | 19 ++++++++++++-------\n drivers/net/ethernet/intel/i40evf/i40e_common.c | 19 ++++++++++++-------\n 2 files changed, 24 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c\nindex a5d0028..ed5d328 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c\n@@ -300,7 +300,6 @@ void i40e_debug_aq(struct i40e_hw *hw, enum i40e_debug_mask mask, void *desc,\n \tstruct i40e_aq_desc *aq_desc = (struct i40e_aq_desc *)desc;\n \tu16 len;\n \tu8 *buf = (u8 *)buffer;\n-\tu16 i = 0;\n \n \tif ((!(mask & hw->debug_mask)) || (desc == NULL))\n \t\treturn;\n@@ -328,12 +327,18 @@ void i40e_debug_aq(struct i40e_hw *hw, enum i40e_debug_mask mask, void *desc,\n \t\tif (buf_len < len)\n \t\t\tlen = buf_len;\n \t\t/* write the full 16-byte chunks */\n-\t\tfor (i = 0; i < (len - 16); i += 16)\n-\t\t\ti40e_debug(hw, mask, \"\\t0x%04X %16ph\\n\", i, buf + i);\n-\t\t/* write whatever's left over without overrunning the buffer */\n-\t\tif (i < len)\n-\t\t\ti40e_debug(hw, mask, \"\\t0x%04X %*ph\\n\",\n-\t\t\t\t\t i, len - i, buf + i);\n+\t\tif (hw->debug_mask & mask) {\n+\t\t\tchar prefix[20];\n+\n+\t\t\tsnprintf(prefix, 20,\n+\t\t\t\t \"i40e %02x:%02x.%x: \\t0x\",\n+\t\t\t\t hw->bus.bus_id,\n+\t\t\t\t hw->bus.device,\n+\t\t\t\t hw->bus.func);\n+\n+\t\t\tprint_hex_dump(KERN_INFO, prefix, DUMP_PREFIX_OFFSET,\n+\t\t\t\t 16, 1, buf, len, false);\n+\t\t}\n \t}\n }\n \ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_common.c b/drivers/net/ethernet/intel/i40evf/i40e_common.c\nindex b5a59dd..89dfdbc 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_common.c\n@@ -304,7 +304,6 @@ void i40evf_debug_aq(struct i40e_hw *hw, enum i40e_debug_mask mask, void *desc,\n {\n \tstruct i40e_aq_desc *aq_desc = (struct i40e_aq_desc *)desc;\n \tu8 *buf = (u8 *)buffer;\n-\tu16 i = 0;\n \n \tif ((!(mask & hw->debug_mask)) || (desc == NULL))\n \t\treturn;\n@@ -332,12 +331,18 @@ void i40evf_debug_aq(struct i40e_hw *hw, enum i40e_debug_mask mask, void *desc,\n \t\tif (buf_len < len)\n \t\t\tlen = buf_len;\n \t\t/* write the full 16-byte chunks */\n-\t\tfor (i = 0; i < (len - 16); i += 16)\n-\t\t\ti40e_debug(hw, mask, \"\\t0x%04X %16ph\\n\", i, buf + i);\n-\t\t/* write whatever's left over without overrunning the buffer */\n-\t\tif (i < len)\n-\t\t\ti40e_debug(hw, mask, \"\\t0x%04X %*ph\\n\",\n-\t\t\t\t\t i, len - i, buf + i);\n+\t\tif (hw->debug_mask & mask) {\n+\t\t\tchar prefix[20];\n+\n+\t\t\tsnprintf(prefix, 20,\n+\t\t\t\t \"i40evf %02x:%02x.%x: \\t0x\",\n+\t\t\t\t hw->bus.bus_id,\n+\t\t\t\t hw->bus.device,\n+\t\t\t\t hw->bus.func);\n+\n+\t\t\tprint_hex_dump(KERN_INFO, prefix, DUMP_PREFIX_OFFSET,\n+\t\t\t\t 16, 1, buf, len, false);\n+\t\t}\n \t}\n }\n \n", "prefixes": [ "next", "S57", "07/11" ] }