Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/705230/?format=api
{ "id": 705230, "url": "http://patchwork.ozlabs.org/api/patches/705230/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1481586257-28872-10-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1481586257-28872-10-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-12-12T23:44:15", "name": "[next,S57,09/11] i40e: properly convert le16 value to CPU format", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a3c0abd335b843d4053c598998663f320892c999", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1481586257-28872-10-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/705230/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/705230/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tczxl5yMLz9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 13 Dec 2016 10:46:19 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5C4E12C9FF;\n\tMon, 12 Dec 2016 23:46:18 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OTxu7PAZh308; Mon, 12 Dec 2016 23:46:13 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id DF7372D09B;\n\tMon, 12 Dec 2016 23:46:08 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8E2581C048D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Dec 2016 23:46:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 73C1885F95\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Dec 2016 23:46:02 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WMMKtCZYwxXo for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Dec 2016 23:45:58 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 1FE95861C6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Dec 2016 23:45:57 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga104.jf.intel.com with ESMTP; 12 Dec 2016 15:45:55 -0800", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.167])\n\tby orsmga003.jf.intel.com with ESMTP; 12 Dec 2016 15:45:55 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.33,339,1477983600\"; d=\"scan'208\";a=\"911471194\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 12 Dec 2016 15:44:15 -0800", "Message-Id": "<1481586257-28872-10-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1481586257-28872-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1481586257-28872-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S57 09/11] i40e: properly convert\n\tle16 value to CPU format", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nThis ensures that the pvid which is stored in __le16 format is converted\nto the CPU format. This will fix comparison issues on Big Endian\nplatforms.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nChange-ID: I92c80d1315dc2a0f9f095d5a0c48d461beb052ed\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 128a21e..99ea5652 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1260,6 +1260,7 @@ static int i40e_correct_mac_vlan_filters(struct i40e_vsi *vsi,\n \t\t\t\t\t struct hlist_head *tmp_del_list,\n \t\t\t\t\t int vlan_filters)\n {\n+\ts16 pvid = le16_to_cpu(vsi->info.pvid);\n \tstruct i40e_mac_filter *f, *add_head;\n \tstruct i40e_new_mac_filter *new;\n \tstruct hlist_node *h;\n@@ -1281,8 +1282,8 @@ static int i40e_correct_mac_vlan_filters(struct i40e_vsi *vsi,\n \n \t/* Update the filters about to be added in place */\n \thlist_for_each_entry(new, tmp_add_list, hlist) {\n-\t\tif (vsi->info.pvid && new->f->vlan != vsi->info.pvid)\n-\t\t\tnew->f->vlan = vsi->info.pvid;\n+\t\tif (pvid && new->f->vlan != pvid)\n+\t\t\tnew->f->vlan = pvid;\n \t\telse if (vlan_filters && new->f->vlan == I40E_VLAN_ANY)\n \t\t\tnew->f->vlan = 0;\n \t\telse if (!vlan_filters && new->f->vlan == 0)\n@@ -1296,12 +1297,12 @@ static int i40e_correct_mac_vlan_filters(struct i40e_vsi *vsi,\n \t\t * order to avoid duplicating code for adding the new filter\n \t\t * then deleting the old filter.\n \t\t */\n-\t\tif ((vsi->info.pvid && f->vlan != vsi->info.pvid) ||\n+\t\tif ((pvid && f->vlan != pvid) ||\n \t\t (vlan_filters && f->vlan == I40E_VLAN_ANY) ||\n \t\t (!vlan_filters && f->vlan == 0)) {\n \t\t\t/* Determine the new vlan we will be adding */\n-\t\t\tif (vsi->info.pvid)\n-\t\t\t\tnew_vlan = vsi->info.pvid;\n+\t\t\tif (pvid)\n+\t\t\t\tnew_vlan = pvid;\n \t\t\telse if (vlan_filters)\n \t\t\t\tnew_vlan = 0;\n \t\t\telse\n", "prefixes": [ "next", "S57", "09/11" ] }