Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/705225/?format=api
{ "id": 705225, "url": "http://patchwork.ozlabs.org/api/patches/705225/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1481586257-28872-7-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1481586257-28872-7-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-12-12T23:44:12", "name": "[next,S57,06/11] i40e: Fix Adaptive ITR enabling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "23ca09d43ee4828c96249e44fb133ac3c1bbf687", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1481586257-28872-7-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/705225/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/705225/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tczxX6VYMz9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 13 Dec 2016 10:46:08 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 280232E602;\n\tMon, 12 Dec 2016 23:46:07 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Q55xL0MMcPKA; Mon, 12 Dec 2016 23:46:02 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 69DFA2D097;\n\tMon, 12 Dec 2016 23:45:59 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id A37E91C048D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Dec 2016 23:45:58 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A1D9C861B0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Dec 2016 23:45:58 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4b6I0iOYeUdg for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Dec 2016 23:45:58 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id B6CE3861BF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Dec 2016 23:45:56 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga104.jf.intel.com with ESMTP; 12 Dec 2016 15:45:55 -0800", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.167])\n\tby orsmga003.jf.intel.com with ESMTP; 12 Dec 2016 15:45:55 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.33,339,1477983600\"; d=\"scan'208\";a=\"911471185\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 12 Dec 2016 15:44:12 -0800", "Message-Id": "<1481586257-28872-7-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1481586257-28872-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1481586257-28872-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S57 06/11] i40e: Fix Adaptive ITR\n\tenabling", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Carolyn Wyborny <carolyn.wyborny@intel.com>\n\nThis patch fixes a bug introduced with the addition of the per queue\nITR feature support in ethtool. With that addition, there were\nfunctions added which converted the ITR settings to binary values.\nThe IS_ENABLED macros that run on those values check whether a bit\nis set or not and with the value being binary, the bit check always\nreturned ITR disabled which prevents any updating of the ITR rate.\nThis patch fixes the problem by changing the functions to return the\ncurrent ITR value instead and renaming it to better reflect\nits function. These functions now provide a value which will be\naccurately asessed and update the ITR as intended.\n\nSigned-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>\nChange-ID: I14f1d088d052e27f652aaa3113e186415ddea1fc\n---\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 12 ++++++------\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 12 ++++++------\n 2 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex e88e335..8531f4b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -1864,14 +1864,14 @@ static u32 i40e_buildreg_itr(const int type, const u16 itr)\n \n /* a small macro to shorten up some long lines */\n #define INTREG I40E_PFINT_DYN_CTLN\n-static inline int get_rx_itr_enabled(struct i40e_vsi *vsi, int idx)\n+static inline int get_rx_itr(struct i40e_vsi *vsi, int idx)\n {\n-\treturn !!(vsi->rx_rings[idx]->rx_itr_setting);\n+\treturn vsi->rx_rings[idx]->rx_itr_setting;\n }\n \n-static inline int get_tx_itr_enabled(struct i40e_vsi *vsi, int idx)\n+static inline int get_tx_itr(struct i40e_vsi *vsi, int idx)\n {\n-\treturn !!(vsi->tx_rings[idx]->tx_itr_setting);\n+\treturn vsi->tx_rings[idx]->tx_itr_setting;\n }\n \n /**\n@@ -1897,8 +1897,8 @@ static inline void i40e_update_enable_itr(struct i40e_vsi *vsi,\n \t */\n \trxval = txval = i40e_buildreg_itr(I40E_ITR_NONE, 0);\n \n-\trx_itr_setting = get_rx_itr_enabled(vsi, idx);\n-\ttx_itr_setting = get_tx_itr_enabled(vsi, idx);\n+\trx_itr_setting = get_rx_itr(vsi, idx);\n+\ttx_itr_setting = get_tx_itr(vsi, idx);\n \n \tif (q_vector->itr_countdown > 0 ||\n \t (!ITR_IS_DYNAMIC(rx_itr_setting) &&\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex 4870cb5..45792dd 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -1324,18 +1324,18 @@ static u32 i40e_buildreg_itr(const int type, const u16 itr)\n \n /* a small macro to shorten up some long lines */\n #define INTREG I40E_VFINT_DYN_CTLN1\n-static inline int get_rx_itr_enabled(struct i40e_vsi *vsi, int idx)\n+static inline int get_rx_itr(struct i40e_vsi *vsi, int idx)\n {\n \tstruct i40evf_adapter *adapter = vsi->back;\n \n-\treturn !!(adapter->rx_rings[idx].rx_itr_setting);\n+\treturn adapter->rx_rings[idx].rx_itr_setting;\n }\n \n-static inline int get_tx_itr_enabled(struct i40e_vsi *vsi, int idx)\n+static inline int get_tx_itr(struct i40e_vsi *vsi, int idx)\n {\n \tstruct i40evf_adapter *adapter = vsi->back;\n \n-\treturn !!(adapter->tx_rings[idx].tx_itr_setting);\n+\treturn adapter->tx_rings[idx].tx_itr_setting;\n }\n \n /**\n@@ -1361,8 +1361,8 @@ static inline void i40e_update_enable_itr(struct i40e_vsi *vsi,\n \t */\n \trxval = txval = i40e_buildreg_itr(I40E_ITR_NONE, 0);\n \n-\trx_itr_setting = get_rx_itr_enabled(vsi, idx);\n-\ttx_itr_setting = get_tx_itr_enabled(vsi, idx);\n+\trx_itr_setting = get_rx_itr(vsi, idx);\n+\ttx_itr_setting = get_tx_itr(vsi, idx);\n \n \tif (q_vector->itr_countdown > 0 ||\n \t (!ITR_IS_DYNAMIC(rx_itr_setting) &&\n", "prefixes": [ "next", "S57", "06/11" ] }