Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/703909/?format=api
{ "id": 703909, "url": "http://patchwork.ozlabs.org/api/patches/703909/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20161208001248.13098.93773.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20161208001248.13098.93773.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2016-12-08T00:14:29", "name": "[next-queue,v3] i40e/i40evf: Update driver to support napi_complete_done changes", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "4b72ecf35bdb9970f99a8a517ae699351f7f7c03", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20161208001248.13098.93773.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/703909/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/703909/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tYwpg5W3Pz9t3N\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 8 Dec 2016 11:14:35 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 31BC489CB4;\n\tThu, 8 Dec 2016 00:14:33 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HT3ZZgCxPTrc; Thu, 8 Dec 2016 00:14:32 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B4A8589CB8;\n\tThu, 8 Dec 2016 00:14:32 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id D69821D0683\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Dec 2016 00:14:31 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id CEC3489CB4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Dec 2016 00:14:31 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id onyb60kvpb6f for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Dec 2016 00:14:31 +0000 (UTC)", "from mail-pg0-f66.google.com (mail-pg0-f66.google.com\n\t[74.125.83.66])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 14A4B89C9E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Dec 2016 00:14:31 +0000 (UTC)", "by mail-pg0-f66.google.com with SMTP id e9so24886405pgc.1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 07 Dec 2016 16:14:31 -0800 (PST)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\tt184sm45300298pgt.36.2016.12.07.16.14.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 07 Dec 2016 16:14:30 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Vj/eF0GC\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=subject:from:to:cc:date:message-id:user-agent:mime-version\n\t:content-transfer-encoding;\n\tbh=0eZNBXS9LPQsYrOyqUtrazBh5rXMNtAx57i/GAeQ8PA=;\n\tb=Vj/eF0GCkwYfvF+i7mpPwcCGPO7LA0AiZ9EGXc62TV720UnCChqgk1E1/kRbKE8Kw5\n\tVe9WwO1szYFvi7ELEBdukwUfeUT7W55t36bMNqNVcaw8YNDFT7BWSLkuKTwZLiU3I2Hc\n\tqTgO8a/LYSOZjMk3paUNew3uMLY5FIZsVVIMntTGHPR7Aq6flBqilUMzWcSfc7X2Pcbn\n\t7Ubc1XzhA+YKIb1PBTc7Fjo2LLpBLnhui7pg5E0dVgyOrK0mrFMiX8oB6d2wYJiASXq6\n\t9QSSm4/Ym5rG03zsag4Yn0JhzTlzZtINVtB3OkN0RcoTdwdAgW2cU4dVlfASQupFtVDi\n\t1I8A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=0eZNBXS9LPQsYrOyqUtrazBh5rXMNtAx57i/GAeQ8PA=;\n\tb=NErDlD4tU6HbyhQ5VRMEVJZsGX/S76qCHp0TLHChxacsGncoh1XXhPh3ohpSM1mJTX\n\tE4LNiMINbse/LdJGEiuHk/DtKEd1BpZl4Nh7Re594krVrVHIT1+WgWQtWaNrVjk+0uDJ\n\tSVqyjV5U7RKGatzZwp23A4zVE6OpF6wgz8BVORYEiQcfdBwY2WirNXLPuIi/KI+oQ556\n\t5XdxOiDHPg4aDigVr4yk7H8DaoS5i4HI8qS0QrmdJamWJf0NR3FM11ln3JnlTDskfCim\n\tU/DRJ8lD8l7FEIB2yQSaC3WqhsH1mCyr73TNxP3v/ko2l9u0MtWSMaPPrUux7fOv2wwj\n\t8nwA==", "X-Gm-Message-State": "AKaTC01iW3Pt7v0Jr8gkXnH4ROfkhigBD44rnKpNxe1N3k1Xhd59GQnWer/lG8flh3QTxg==", "X-Received": "by 10.84.204.133 with SMTP id b5mr152649341ple.49.1481156070675; \n\tWed, 07 Dec 2016 16:14:30 -0800 (PST)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 07 Dec 2016 16:14:29 -0800", "Message-ID": "<20161208001248.13098.93773.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next-queue PATCH v3] i40e/i40evf: Update driver\n\tto support napi_complete_done changes", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nRecently napi_complete_done was updated so that it will return zero if we\nare using the queue vector for busy polling. When this is the case we\ndon't need to re-enable interrupts as the busy polling will reschedule the\nNAPI instance when it is finally done polling.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n\nv2: Updated code to place the IRQ enabling inside the if statment\n This made it so that we are consistent with the recent return value changes\n\nv3: Added i40evf changes as well\n\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 32 +++++++++++++------------\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 28 ++++++++++++----------\n 2 files changed, 32 insertions(+), 28 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex e88e335c34ef..f9ef8c2676e2 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -2033,22 +2033,24 @@ int i40e_napi_poll(struct napi_struct *napi, int budget)\n \t\t}\n \t}\n \n-\tif (vsi->back->flags & I40E_TXR_FLAGS_WB_ON_ITR)\n-\t\tq_vector->arm_wb_state = false;\n-\n-\t/* Work is done so exit the polling mode and re-enable the interrupt */\n-\tnapi_complete_done(napi, work_done);\n-\n-\t/* If we're prematurely stopping polling to fix the interrupt\n-\t * affinity we want to make sure polling starts back up so we\n-\t * issue a call to i40e_force_wb which triggers a SW interrupt.\n+\t/* Work is done so exit the polling mode,\n+\t * if not busy polling re-enable interrupts.\n \t */\n-\tif (!clean_complete)\n-\t\ti40e_force_wb(vsi, q_vector);\n-\telse if (!(vsi->back->flags & I40E_FLAG_MSIX_ENABLED))\n-\t\ti40e_irq_dynamic_enable_icr0(vsi->back, false);\n-\telse\n-\t\ti40e_update_enable_itr(vsi, q_vector);\n+\tif (napi_complete_done(napi, work_done)) {\n+\t\tif (vsi->back->flags & I40E_TXR_FLAGS_WB_ON_ITR)\n+\t\t\tq_vector->arm_wb_state = false;\n+\n+\t\t/* If we're prematurely stopping polling to fix the interrupt\n+\t\t * affinity we want to make sure polling starts back up so we\n+\t\t * issue a call to i40e_force_wb which triggers a SW interrupt.\n+\t\t */\n+\t\tif (!clean_complete)\n+\t\t\ti40e_force_wb(vsi, q_vector);\n+\t\telse if (!(vsi->back->flags & I40E_FLAG_MSIX_ENABLED))\n+\t\t\ti40e_irq_dynamic_enable_icr0(vsi->back, false);\n+\t\telse\n+\t\t\ti40e_update_enable_itr(vsi, q_vector);\n+\t}\n \n \treturn min(work_done, budget - 1);\n }\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex 4870cb50dc33..3097a91bd4aa 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -1494,20 +1494,22 @@ int i40evf_napi_poll(struct napi_struct *napi, int budget)\n \t\t}\n \t}\n \n-\tif (vsi->back->flags & I40E_TXR_FLAGS_WB_ON_ITR)\n-\t\tq_vector->arm_wb_state = false;\n-\n-\t/* Work is done so exit the polling mode and re-enable the interrupt */\n-\tnapi_complete_done(napi, work_done);\n-\n-\t/* If we're prematurely stopping polling to fix the interrupt\n-\t * affinity we want to make sure polling starts back up so we\n-\t * issue a call to i40evf_force_wb which triggers a SW interrupt.\n+\t/* Work is done so exit the polling mode,\n+\t * if not busy polling re-enable interrupts.\n \t */\n-\tif (!clean_complete)\n-\t\ti40evf_force_wb(vsi, q_vector);\n-\telse\n-\t\ti40e_update_enable_itr(vsi, q_vector);\n+\tif (napi_complete_done(napi, work_done)) {\n+\t\tif (vsi->back->flags & I40E_TXR_FLAGS_WB_ON_ITR)\n+\t\t\tq_vector->arm_wb_state = false;\n+\n+\t\t/* If we're prematurely stopping polling to fix the interrupt\n+\t\t * affinity we want to make sure polling starts back up so we\n+\t\t * issue a call to i40evf_force_wb which triggers a SW interrupt.\n+\t\t */\n+\t\tif (!clean_complete)\n+\t\t\ti40evf_force_wb(vsi, q_vector);\n+\t\telse\n+\t\t\ti40e_update_enable_itr(vsi, q_vector);\n+\t}\n \n \treturn min(work_done, budget - 1);\n }\n", "prefixes": [ "next-queue", "v3" ] }