Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/702111/?format=api
{ "id": 702111, "url": "http://patchwork.ozlabs.org/api/patches/702111/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1480710782-9195-5-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1480710782-9195-5-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-12-02T20:32:58", "name": "[next,S56,4/8] i40e: don't warn every time we clear an Rx timestamp register", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "337afa58857c9041373ec6d6b3841f2e55d60466", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1480710782-9195-5-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/702111/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/702111/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tVm9P0l7vz9t2n\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 3 Dec 2016 07:34:49 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8F11B851CF;\n\tFri, 2 Dec 2016 20:34:47 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2i7Fy-sj1Qui; Fri, 2 Dec 2016 20:34:46 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3D856851EF;\n\tFri, 2 Dec 2016 20:34:45 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 57E1C1BFB36\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 2 Dec 2016 20:34:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 551CB85025\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 2 Dec 2016 20:34:41 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id RB0zf7y25ahR for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 2 Dec 2016 20:34:40 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id B805C84FEC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 2 Dec 2016 20:34:40 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga101.fm.intel.com with ESMTP; 02 Dec 2016 12:34:39 -0800", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.167])\n\tby orsmga001.jf.intel.com with ESMTP; 02 Dec 2016 12:34:39 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.33,288,1477983600\"; d=\"scan'208\";\n\ta=\"1067223588\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 2 Dec 2016 12:32:58 -0800", "Message-Id": "<1480710782-9195-5-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1480710782-9195-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1480710782-9195-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S56 4/8] i40e: don't warn every time\n\twe clear an Rx timestamp register", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nThe intent of this message was to indicate to a user that we might have\nmissed a timestamp event for a valid packet. The original method of\ndetecting the missed events relied on waiting until all 4 registers were\nfilled.\n\nA recent commit d55458c0cd7a5 (\"i40e: replace PTP Rx timestamp hang\nlogic\") replaced this logic with much better detection\nscheme that could detect a stalled Rx timestamp register even when other\nregisters were still functional.\n\nThe new logic means that a message will be displayed almost as soon as\na timestamp for a dropped frame occurs. This new logic highlights that\nthe hardware will attempt timestamp for frames which it later decides to\ndrop. The most prominent example is when a multicast PTP frame is\nreceived on a multicast address that we are not subscribed to.\n\nBecause the hardware initiates the Rx timestamp as soon as possible, it\nwill latch an RXTIME register, but then drop the packet.\n\nThis results in users being confused by the message as they are not\nexpecting to see dropped timestamp messages unless their application\nalso indicates that timestamps were missing.\n\nResolve this by reducing the severity and frequency of the displayed\nmessage. We now only print the message if 3 or 4 of the RXTIME registers\nare stalled and get cleared within the same watchdog event. This ensures\nthat the common case does not constantly display the message.\nAdditionally, since the message is likely not as meaningful to most\nusers, reduce the message to a dev_dbg instead of a dev_warn.\n\nUsers can still get a count of the number of timestamps dropped by\nreading the ethtool statistics value, if necessary.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nChange-ID: I35494442226a444c418dfb4f91a3070d06c8435c\n---\n drivers/net/ethernet/intel/i40e/i40e_ptp.c | 21 ++++++++++++++++-----\n 1 file changed, 16 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ptp.c b/drivers/net/ethernet/intel/i40e/i40e_ptp.c\nindex 9e49ffa..2caee35 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ptp.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ptp.c\n@@ -280,7 +280,7 @@ void i40e_ptp_rx_hang(struct i40e_vsi *vsi)\n {\n \tstruct i40e_pf *pf = vsi->back;\n \tstruct i40e_hw *hw = &pf->hw;\n-\tint i;\n+\tunsigned int i, cleared = 0;\n \n \t/* Since we cannot turn off the Rx timestamp logic if the device is\n \t * configured for Tx timestamping, we check if Rx timestamping is\n@@ -306,14 +306,25 @@ void i40e_ptp_rx_hang(struct i40e_vsi *vsi)\n \t\t time_is_before_jiffies(pf->latch_events[i] + HZ)) {\n \t\t\trd32(hw, I40E_PRTTSYN_RXTIME_H(i));\n \t\t\tpf->latch_event_flags &= ~BIT(i);\n-\t\t\tpf->rx_hwtstamp_cleared++;\n-\t\t\tdev_warn(&pf->pdev->dev,\n-\t\t\t\t \"Clearing a missed Rx timestamp event for RXTIME[%d]\\n\",\n-\t\t\t\t i);\n+\t\t\tcleared++;\n \t\t}\n \t}\n \n \tspin_unlock_bh(&pf->ptp_rx_lock);\n+\n+\t/* Log a warning if more than 2 timestamps got dropped in the same\n+\t * check. We don't want to warn about all drops because it can occur\n+\t * in normal scenarios such as PTP frames on multicast addresses we\n+\t * aren't listening to. However, administrator should know if this is\n+\t * the reason packets aren't receiving timestamps.\n+\t */\n+\tif (cleared > 2)\n+\t\tdev_dbg(&pf->pdev->dev,\n+\t\t\t\"Dropped %d missed RXTIME timestamp events\\n\",\n+\t\t\tcleared);\n+\n+\t/* Finally, update the rx_hwtstamp_cleared counter */\n+\tpf->rx_hwtstamp_cleared += cleared;\n }\n \n /**\n", "prefixes": [ "next", "S56", "4/8" ] }