Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/702108/?format=api
{ "id": 702108, "url": "http://patchwork.ozlabs.org/api/patches/702108/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1480710782-9195-2-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1480710782-9195-2-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-12-02T20:32:55", "name": "[next,S56,1/8] i40e: Clean up dead code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "40d3c3360a2b0f3c891a969f58170689f8114b18", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1480710782-9195-2-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/702108/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/702108/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tVm9M1Mfxz9t2n\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 3 Dec 2016 07:34:47 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B537A8532F;\n\tFri, 2 Dec 2016 20:34:45 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id yhDL6fTj2pL1; Fri, 2 Dec 2016 20:34:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9F1CD850AC;\n\tFri, 2 Dec 2016 20:34:44 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id E32FD1BFB36\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 2 Dec 2016 20:34:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E05CE850AC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 2 Dec 2016 20:34:40 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ooyYOpR87EzG for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 2 Dec 2016 20:34:40 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 3B3A885019\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 2 Dec 2016 20:34:40 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga101.fm.intel.com with ESMTP; 02 Dec 2016 12:34:39 -0800", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.167])\n\tby orsmga001.jf.intel.com with ESMTP; 02 Dec 2016 12:34:39 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.33,288,1477983600\"; d=\"scan'208\";\n\ta=\"1067223581\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 2 Dec 2016 12:32:55 -0800", "Message-Id": "<1480710782-9195-2-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1480710782-9195-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1480710782-9195-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S56 1/8] i40e: Clean up dead code", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nThe function i40e_client_prepare() can never return an error. So make it\nvoid and quit checking its return value.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nChange-ID: I9ff311e2324dde329eb68648efb2c94aaff856db\n---\nTesting Hints : Found by static code analysis. Not\npossible to test, just code cleanup.\n\n drivers/net/ethernet/intel/i40e/i40e_client.c | 13 +++----------\n 1 file changed, 3 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/intel/i40e/i40e_client.c\nindex f6409f9..337d417 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_client.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_client.c\n@@ -653,13 +653,11 @@ static int i40e_client_release(struct i40e_client *client)\n * i40e_client_prepare - prepare client specific resources\n * @client: pointer to the registered client\n *\n- * Return 0 on success or < 0 on error\n **/\n-static int i40e_client_prepare(struct i40e_client *client)\n+static void i40e_client_prepare(struct i40e_client *client)\n {\n \tstruct i40e_device *ldev;\n \tstruct i40e_pf *pf;\n-\tint ret = 0;\n \n \tmutex_lock(&i40e_device_mutex);\n \tlist_for_each_entry(ldev, &i40e_devices, list) {\n@@ -669,7 +667,6 @@ static int i40e_client_prepare(struct i40e_client *client)\n \t\ti40e_service_event_schedule(pf);\n \t}\n \tmutex_unlock(&i40e_device_mutex);\n-\treturn ret;\n }\n \n /**\n@@ -926,13 +923,9 @@ int i40e_register_client(struct i40e_client *client)\n \tset_bit(__I40E_CLIENT_REGISTERED, &client->state);\n \tmutex_unlock(&i40e_client_mutex);\n \n-\tif (i40e_client_prepare(client)) {\n-\t\tret = -EIO;\n-\t\tgoto out;\n-\t}\n+\ti40e_client_prepare(client);\n \n-\tpr_info(\"i40e: Registered client %s with return code %d\\n\",\n-\t\tclient->name, ret);\n+\tpr_info(\"i40e: Registered client %s\\n\",\tclient->name);\n out:\n \treturn ret;\n }\n", "prefixes": [ "next", "S56", "1/8" ] }