Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/700615/?format=api
{ "id": 700615, "url": "http://patchwork.ozlabs.org/api/patches/700615/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1589605144.308560.1480435436440.JavaMail.zimbra@xes-inc.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1589605144.308560.1480435436440.JavaMail.zimbra@xes-inc.com>", "list_archive_url": null, "date": "2016-11-29T16:03:56", "name": "igb: reset the PHY before reading the PHY ID", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "caa87c3d3cd8edaf97ede80d1122ef1787d028e9", "submitter": { "id": 10211, "url": "http://patchwork.ozlabs.org/api/people/10211/?format=api", "name": "Aaron Sierra", "email": "asierra@xes-inc.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1589605144.308560.1480435436440.JavaMail.zimbra@xes-inc.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/700615/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/700615/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tSpJZ3Xkzz9t26\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Nov 2016 03:04:13 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B564D871B7;\n\tTue, 29 Nov 2016 16:04:11 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ZxDemg9Frryw; Tue, 29 Nov 2016 16:04:09 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2405A87004;\n\tTue, 29 Nov 2016 16:04:09 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id DB1941BFFA6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Nov 2016 16:04:08 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D3DEAC0AD2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Nov 2016 16:04:08 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id g0QK--7ip0y1 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Nov 2016 16:04:03 +0000 (UTC)", "from xes-mad.com (xes-mad.com [216.165.139.218])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 99F13C08B3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Nov 2016 16:04:03 +0000 (UTC)", "from zimbra.xes-mad.com (zimbra.xes-mad.com [10.52.0.127])\n\tby xes-mad.com (8.13.8/8.13.8) with ESMTP id uATG3uE3015186;\n\tTue, 29 Nov 2016 10:03:56 -0600" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "Date": "Tue, 29 Nov 2016 10:03:56 -0600 (CST)", "From": "Aaron Sierra <asierra@xes-inc.com>", "To": "Jeffrey T Kirsher <jeffrey.t.kirsher@intel.com>", "Message-ID": "<1589605144.308560.1480435436440.JavaMail.zimbra@xes-inc.com>", "MIME-Version": "1.0", "X-Originating-IP": "[10.52.0.127]", "X-Mailer": "Zimbra 8.7.0_GA_1659 (ZimbraWebClient - FF48 (Linux)/8.7.0_GA_1659)", "Thread-Index": "ttBlEogvb+XGy3sKMoxRbI2s50PrYw==", "Thread-Topic": "reset the PHY before reading the PHY ID", "Cc": "Chris Arges <carges@vectranetworks.com>,\n\tintel-wired-lan <intel-wired-lan@lists.osuosl.org>,\n\t\"Matwey V. Kornilov\" <matwey@sai.msu.ru>", "Subject": "[Intel-wired-lan] [PATCH] igb: reset the PHY before reading the PHY\n\tID", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Several people have reported firmware leaving the I210/I211 PHY's page\nselect register set to something other than the default of zero. This\ncauses the first accesses, PHY_IDx register reads, to access something\nelse, resulting in device probe failure:\n\n igb: Intel(R) Gigabit Ethernet Network Driver - version 5.4.0-k\n igb: Copyright (c) 2007-2014 Intel Corporation.\n igb: probe of 0000:01:00.0 failed with error -2\n\nThis problem began for them after a previous patch I submitted was\napplied:\n\n commit 2a3cdead8b408351fa1e3079b220fa331480ffbc\n Author: Aaron Sierra <asierra@xes-inc.com>\n Date: Tue Nov 3 12:37:09 2015 -0600\n\n igb: Remove GS40G specific defines/functions\n\nI personally experienced this problem after attempting to PXE boot from\nI210 devices using this firmware:\n\n Intel(R) Boot Agent GE v1.5.78\n Copyright (C) 1997-2014, Intel Corporation\n\nResetting the PHY before reading from it, ensures the page select\nregister is in its default state and doesn't make assumptions about\nthe PHY's register set before the PHY has been probed.\n\nCc: Matwey V. Kornilov <matwey@sai.msu.ru>\nCc: Chris Arges <carges@vectranetworks.com>\nCc: Jochen Henneberg <jh@henneberg-systemdesign.com>\nSigned-off-by: Aaron Sierra <asierra@xes-inc.com>\n---\n drivers/net/ethernet/intel/igb/e1000_82575.c | 11 +++++++++++\n 1 file changed, 11 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c b/drivers/net/ethernet/intel/igb/e1000_82575.c\nindex a61447f..ee44398 100644\n--- a/drivers/net/ethernet/intel/igb/e1000_82575.c\n+++ b/drivers/net/ethernet/intel/igb/e1000_82575.c\n@@ -245,6 +245,17 @@ static s32 igb_init_phy_params_82575(struct e1000_hw *hw)\n \thw->bus.func = (rd32(E1000_STATUS) & E1000_STATUS_FUNC_MASK) >>\n \t\t\tE1000_STATUS_FUNC_SHIFT;\n \n+\t/* Make sure the PHY is in a good state. Several people have reported\n+\t * firmware leaving the PHY's page select register set to something\n+\t * other than the default of zero, which causes the PHY ID read to\n+\t * access something other than the intended register.\n+\t */\n+\tret_val = hw->phy.ops.reset(hw);\n+\tif (ret_val) {\n+\t\thw_dbg(\"Error resetting the PHY.\\n\");\n+\t\tgoto out;\n+\t}\n+\n \t/* Set phy->phy_addr and phy->id. */\n \tret_val = igb_get_phy_id_82575(hw);\n \tif (ret_val)\n", "prefixes": [] }