Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/700235/?format=api
{ "id": 700235, "url": "http://patchwork.ozlabs.org/api/patches/700235/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1480377971-23412-7-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1480377971-23412-7-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-11-29T00:06:03", "name": "[next,S55,06/14] i40e: add interrupt rate limit verbosity", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8b1963abfbcf2fb5c9ca399c475b0339d70964be", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1480377971-23412-7-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/700235/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/700235/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tSP5W4l8nz9vF7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Nov 2016 11:08:15 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 40C388890A;\n\tTue, 29 Nov 2016 00:08:14 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PM2t2NTwQxxE; Tue, 29 Nov 2016 00:08:11 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8FA4988916;\n\tTue, 29 Nov 2016 00:07:58 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6F9181C0C28\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Nov 2016 00:07:52 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6B39B93A8F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Nov 2016 00:07:52 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hiJtKypysbeT for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Nov 2016 00:07:48 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 940A593F82\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Nov 2016 00:07:48 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga104.jf.intel.com with ESMTP; 28 Nov 2016 16:07:47 -0800", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.167])\n\tby orsmga004.jf.intel.com with ESMTP; 28 Nov 2016 16:07:47 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,565,1473145200\"; d=\"scan'208\";a=\"35284059\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 28 Nov 2016 16:06:03 -0800", "Message-Id": "<1480377971-23412-7-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1480377971-23412-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1480377971-23412-1-git-send-email-bimmy.pujari@intel.com>", "Cc": "Alan Brady <alan.brady@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S55 06/14] i40e: add interrupt rate\n\tlimit verbosity", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Alan Brady <alan.brady@intel.com>\n\nDue to the resolution of the register controlling interrupt rate\nlimiting, setting certain values for the interrupt rate limit make it\nappear as though the limiting is not completely accurate. The problem\nis that the interrupt rate limit is getting rounded down to the nearest\nmultiple of 4. This patch fixes the problem by adding some feedback to\nthe user as to the actual interrupt rate limit being used when it\ndiffers from the requested limit. Without this patch setting interrupt\nrate limits may appear to behave inaccurately.\n\nSigned-off-by: Alan Brady <alan.brady@intel.com>\nChange-ID: I3093cf3f2d437d35a4c4f4bb5af5ce1b85ab21b7\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 977ae6f..f9f71fb 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -2116,6 +2116,7 @@ static int __i40e_set_coalesce(struct net_device *netdev,\n \tstruct i40e_netdev_priv *np = netdev_priv(netdev);\n \tstruct i40e_vsi *vsi = np->vsi;\n \tstruct i40e_pf *pf = vsi->back;\n+\tu16 intrl_reg;\n \tint i;\n \n \tif (ec->tx_max_coalesced_frames_irq || ec->rx_max_coalesced_frames_irq)\n@@ -2127,8 +2128,9 @@ static int __i40e_set_coalesce(struct net_device *netdev,\n \t\treturn -EINVAL;\n \t}\n \n-\tif (ec->rx_coalesce_usecs_high >= INTRL_REG_TO_USEC(I40E_MAX_INTRL)) {\n-\t\tnetif_info(pf, drv, netdev, \"Invalid value, rx-usecs-high range is 0-235\\n\");\n+\tif (ec->rx_coalesce_usecs_high > INTRL_REG_TO_USEC(I40E_MAX_INTRL)) {\n+\t\tnetif_info(pf, drv, netdev, \"Invalid value, rx-usecs-high range is 0-%lu\\n\",\n+\t\t\t INTRL_REG_TO_USEC(I40E_MAX_INTRL));\n \t\treturn -EINVAL;\n \t}\n \n@@ -2141,7 +2143,12 @@ static int __i40e_set_coalesce(struct net_device *netdev,\n \t\t\treturn -EINVAL;\n \t}\n \n-\tvsi->int_rate_limit = ec->rx_coalesce_usecs_high;\n+\tintrl_reg = i40e_intrl_usec_to_reg(ec->rx_coalesce_usecs_high);\n+\tvsi->int_rate_limit = INTRL_REG_TO_USEC(intrl_reg);\n+\tif (vsi->int_rate_limit != ec->rx_coalesce_usecs_high) {\n+\t\tnetif_info(pf, drv, netdev, \"Interrupt rate limit rounded down to %d\\n\",\n+\t\t\t vsi->int_rate_limit);\n+\t}\n \n \tif (ec->tx_coalesce_usecs == 0) {\n \t\tif (ec->use_adaptive_tx_coalesce)\n", "prefixes": [ "next", "S55", "06/14" ] }