Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/700124/?format=api
{ "id": 700124, "url": "http://patchwork.ozlabs.org/api/patches/700124/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1479983568-4383-1-git-send-email-matwey@sai.msu.ru/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1479983568-4383-1-git-send-email-matwey@sai.msu.ru>", "list_archive_url": null, "date": "2016-11-24T10:32:48", "name": "igb: Explicitly select page 0 at initialization", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "48fc86c18f863382dd2b901ef66aeeb5175aed7f", "submitter": { "id": 64708, "url": "http://patchwork.ozlabs.org/api/people/64708/?format=api", "name": "Matwey V. Kornilov", "email": "matwey@sai.msu.ru" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1479983568-4383-1-git-send-email-matwey@sai.msu.ru/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/700124/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/700124/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tSGxg4J81z9vDl\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Nov 2016 06:31:03 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E1C552F54C;\n\tMon, 28 Nov 2016 19:31:01 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id t-Zgzq8Qf5kN; Mon, 28 Nov 2016 19:30:59 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 890F7232AA;\n\tMon, 28 Nov 2016 19:30:59 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 05F7D1BFB06\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 24 Nov 2016 10:33:11 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id EDB8C23183\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 24 Nov 2016 10:33:10 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id QcA9plBNze+Y for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 24 Nov 2016 10:33:09 +0000 (UTC)", "from mail-lf0-f67.google.com (mail-lf0-f67.google.com\n\t[209.85.215.67])\n\tby silver.osuosl.org (Postfix) with ESMTPS id E167223073\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 24 Nov 2016 10:33:08 +0000 (UTC)", "by mail-lf0-f67.google.com with SMTP id p100so1674156lfg.2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 24 Nov 2016 02:33:08 -0800 (PST)", "from oak.local ([92.243.181.209]) by smtp.gmail.com with ESMTPSA id\n\tu74sm8120597lfi.9.2016.11.24.02.33.05\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 24 Nov 2016 02:33:05 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XbwmOaXY\"; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=sender:from:to:cc:subject:date:message-id;\n\tbh=bJjLz3Sw8F9Vcx0jj9H/LayxdHoQYaAXP+yRcsG3Ro4=;\n\tb=XbwmOaXYtdb6rngfmC8heSRFJjMM4+JzpZh61AKz2fKrxxPdT/+OijlgYIOZIFGo/e\n\tqc1iED62dMOB444qAwfMyQd1SuB2N+IoZ8p268RxSjLy/mUwINSuDaxsoWeL94taMTD3\n\tWhqBVRYGZHaX+HCGT8oZLrq6rKxC7N00HIrnzaBCxxySJEhMKAAldGXH4wCPjprbXoCR\n\tH/hCitTI4BOPvtmaWlhCdSNbpqVjon+/r5s72Iux5bKxeJu334a1ro9kvazPA7xWKPwe\n\taHzTh1CDRBO+a0rJYc6Uh4YE2hrt1IdC3aLtf7fcYhrl4sdTdwjA5UPtpN9948jrIPWB\n\tVJ8A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id;\n\tbh=bJjLz3Sw8F9Vcx0jj9H/LayxdHoQYaAXP+yRcsG3Ro4=;\n\tb=ba2mgLtNNKBjw+duynqGWfbGzdfzLCRYwOFA4zxeWxdaOoETd0W2/wKjg8Dv2HUUGc\n\toK72peUtkWv+bxaKhDKp5E0/lOos1e9UCqU13fqt84KPBoHBJ9m3Qfa8VWv1K65bkEzm\n\t7l3DSAiZqygyjNNOfYD0DS1SXcQo3RCu/+ro3U0cmBzq7tTjwxdwwtNrE8L4uB7fQUpY\n\t/nF5H5Hx6t23azjc0HBglBn+AKY9GsTYXr9xhRl1RFTG7Tjz57MT/YjwhtQfEPOrZtVf\n\tKX9EY0GW12g+eYXC1cv9xt7Ivs70OOmmEwgKo2v07wMVLNn/3Jd/JmPT7g7nml7sldj6\n\t2JtA==", "X-Gm-Message-State": "AKaTC022KLGan1vlR0yXZV5Tj3jgJmWFegrr1WzouSmdeRX4uGizQDkPKPeu6UMfql0KhA==", "X-Received": "by 10.25.199.145 with SMTP id x139mr588256lff.142.1479983586715; \n\tThu, 24 Nov 2016 02:33:06 -0800 (PST)", "From": "\"Matwey V. Kornilov\" <matwey@sai.msu.ru>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Thu, 24 Nov 2016 13:32:48 +0300", "Message-Id": "<1479983568-4383-1-git-send-email-matwey@sai.msu.ru>", "X-Mailer": "git-send-email 2.1.4", "X-Mailman-Approved-At": "Mon, 28 Nov 2016 19:30:58 +0000", "Cc": "\"Matwey V. Kornilov\" <matwey@sai.msu.ru>, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, stable@vger.kernel.org, jcheung@suse.com,\n\tmatwey.kornilov@gmail.com, intel-wired-lan@lists.osuosl.org,\n\tdchang@suse.com", "Subject": "[Intel-wired-lan] [PATCH] igb: Explicitly select page 0 at\n\tinitialization", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The functions igb_read_phy_reg_gs40g/igb_write_phy_reg_gs40g (which were\nremoved in 2a3cdea) explicitly selected the required page at every phy_reg\naccess. Currently, igb_get_phy_id_82575 relays on the fact that page 0 is\nalready selected. The assumption is not fulfilled for my Lex 3I380CW\nmotherboard with integrated dual i211 based gigabit ethernet. This leads to igb\ninitialization failure and network interfaces are not working:\n\n igb: Intel(R) Gigabit Ethernet Network Driver - version 5.4.0-k\n igb: Copyright (c) 2007-2014 Intel Corporation.\n igb: probe of 0000:01:00.0 failed with error -2\n igb: probe of 0000:02:00.0 failed with error -2\n\nIn order to fix it, we explicitly select page 0 before first access to phy\nregisters.\n\nSee also: https://bugzilla.suse.com/show_bug.cgi?id=1009911\nSee also: http://www.lex.com.tw/products/pdf/3I380A&3I380CW.pdf\n\nFixes: 2a3cdea (\"igb: Remove GS40G specific defines/functions\")\nCc: <stable@vger.kernel.org> # 4.5+\nSigned-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>\n---\n drivers/net/ethernet/intel/igb/e1000_82575.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c b/drivers/net/ethernet/intel/igb/e1000_82575.c\nindex a61447f..1264a36 100644\n--- a/drivers/net/ethernet/intel/igb/e1000_82575.c\n+++ b/drivers/net/ethernet/intel/igb/e1000_82575.c\n@@ -246,6 +246,7 @@ static s32 igb_init_phy_params_82575(struct e1000_hw *hw)\n \t\t\tE1000_STATUS_FUNC_SHIFT;\n \n \t/* Set phy->phy_addr and phy->id. */\n+\tigb_write_phy_reg_82580(hw, I347AT4_PAGE_SELECT, 0);\n \tret_val = igb_get_phy_id_82575(hw);\n \tif (ret_val)\n \t\treturn ret_val;\n", "prefixes": [] }