Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/697454/?format=api
{ "id": 697454, "url": "http://patchwork.ozlabs.org/api/patches/697454/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/147977208380.28902.17303722736724936179.stgit@mdrustad-wks.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<147977208380.28902.17303722736724936179.stgit@mdrustad-wks.jf.intel.com>", "list_archive_url": null, "date": "2016-11-21T23:48:03", "name": "[2/4] ixgbe: Remove unused firmware version functions and method", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ce80249e923840cd43281fb5b92335896f2c08c9", "submitter": { "id": 13252, "url": "http://patchwork.ozlabs.org/api/people/13252/?format=api", "name": "Rustad, Mark D", "email": "mark.d.rustad@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/147977208380.28902.17303722736724936179.stgit@mdrustad-wks.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/697454/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/697454/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tN4zd2fFmz9svs\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 22 Nov 2016 10:48:13 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E1E3C24463;\n\tMon, 21 Nov 2016 23:48:11 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kgzSN3waHQTb; Mon, 21 Nov 2016 23:48:09 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id CB099244C5;\n\tMon, 21 Nov 2016 23:48:09 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2BEAB1C073B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 21 Nov 2016 23:48:07 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D225D244C5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 21 Nov 2016 23:48:07 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0600xzKQGe6u for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 21 Nov 2016 23:48:06 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 7887E24463\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 21 Nov 2016 23:48:04 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga103.fm.intel.com with ESMTP; 21 Nov 2016 15:48:04 -0800", "from mdrustad-wks.jf.intel.com ([134.134.3.111])\n\tby orsmga001.jf.intel.com with ESMTP; 21 Nov 2016 15:48:03 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.31,677,1473145200\"; d=\"scan'208\";\n\ta=\"1062549626\"", "From": "Mark D Rustad <mark.d.rustad@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 21 Nov 2016 15:48:03 -0800", "Message-ID": "<147977208380.28902.17303722736724936179.stgit@mdrustad-wks.jf.intel.com>", "In-Reply-To": "<147977200790.28902.977631990204721234.stgit@mdrustad-wks.jf.intel.com>", "References": "<147977200790.28902.977631990204721234.stgit@mdrustad-wks.jf.intel.com>", "User-Agent": "StGit/unknown-version", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 2/4] ixgbe: Remove unused firmware version\n\tfunctions and method", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The firmware version method and functions are not used anywhere, so\nremove them all.\n\nSigned-off-by: Mark Rustad <mark.d.rustad@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c | 2 -\n drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 2 -\n drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 34 ------------------------\n drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h | 4 ---\n drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 1 -\n drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c | 1 -\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 3 +-\n 7 files changed, 1 insertion(+), 46 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c\nindex 805ab319e578..523f9d05a810 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c\n@@ -139,8 +139,6 @@ static s32 ixgbe_init_phy_ops_82598(struct ixgbe_hw *hw)\n \tcase ixgbe_phy_tn:\n \t\tphy->ops.setup_link = &ixgbe_setup_phy_link_tnx;\n \t\tphy->ops.check_link = &ixgbe_check_phy_link_tnx;\n-\t\tphy->ops.get_firmware_version =\n-\t\t\t &ixgbe_get_phy_firmware_version_tnx;\n \t\tbreak;\n \tcase ixgbe_phy_nl:\n \t\tphy->ops.reset = &ixgbe_reset_phy_nl;\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c\nindex e00aaeb91827..30535e6b68f0 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c\n@@ -331,8 +331,6 @@ static s32 ixgbe_init_phy_ops_82599(struct ixgbe_hw *hw)\n \tcase ixgbe_phy_tn:\n \t\tphy->ops.check_link = &ixgbe_check_phy_link_tnx;\n \t\tphy->ops.setup_link = &ixgbe_setup_phy_link_tnx;\n-\t\tphy->ops.get_firmware_version =\n-\t\t\t &ixgbe_get_phy_firmware_version_tnx;\n \t\tbreak;\n \tdefault:\n \t\tbreak;\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\nindex 4aa679359aa8..989a3b19d209 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n@@ -978,40 +978,6 @@ s32 ixgbe_setup_phy_link_tnx(struct ixgbe_hw *hw)\n }\n \n /**\n- * ixgbe_get_phy_firmware_version_tnx - Gets the PHY Firmware Version\n- * @hw: pointer to hardware structure\n- * @firmware_version: pointer to the PHY Firmware Version\n- **/\n-s32 ixgbe_get_phy_firmware_version_tnx(struct ixgbe_hw *hw,\n-\t\t\t\t u16 *firmware_version)\n-{\n-\ts32 status;\n-\n-\tstatus = hw->phy.ops.read_reg(hw, TNX_FW_REV,\n-\t\t\t\t MDIO_MMD_VEND1,\n-\t\t\t\t firmware_version);\n-\n-\treturn status;\n-}\n-\n-/**\n- * ixgbe_get_phy_firmware_version_generic - Gets the PHY Firmware Version\n- * @hw: pointer to hardware structure\n- * @firmware_version: pointer to the PHY Firmware Version\n- **/\n-s32 ixgbe_get_phy_firmware_version_generic(struct ixgbe_hw *hw,\n-\t\t\t\t\t u16 *firmware_version)\n-{\n-\ts32 status;\n-\n-\tstatus = hw->phy.ops.read_reg(hw, AQ_FW_REV,\n-\t\t\t\t MDIO_MMD_VEND1,\n-\t\t\t\t firmware_version);\n-\n-\treturn status;\n-}\n-\n-/**\n * ixgbe_reset_phy_nl - Performs a PHY reset\n * @hw: pointer to hardware structure\n **/\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h\nindex ecf05f838fc5..5aa2c3cf7aec 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h\n@@ -168,10 +168,6 @@ s32 ixgbe_check_phy_link_tnx(struct ixgbe_hw *hw,\n \t\t\t ixgbe_link_speed *speed,\n \t\t\t bool *link_up);\n s32 ixgbe_setup_phy_link_tnx(struct ixgbe_hw *hw);\n-s32 ixgbe_get_phy_firmware_version_tnx(struct ixgbe_hw *hw,\n-\t\t\t\t u16 *firmware_version);\n-s32 ixgbe_get_phy_firmware_version_generic(struct ixgbe_hw *hw,\n-\t\t\t\t\t u16 *firmware_version);\n \n s32 ixgbe_reset_phy_nl(struct ixgbe_hw *hw);\n s32 ixgbe_set_copper_phy_power(struct ixgbe_hw *hw, bool on);\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\nindex bfa5d190efe7..2b590fcb82b5 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\n@@ -3404,7 +3404,6 @@ struct ixgbe_phy_operations {\n \ts32 (*setup_internal_link)(struct ixgbe_hw *);\n \ts32 (*setup_link_speed)(struct ixgbe_hw *, ixgbe_link_speed, bool);\n \ts32 (*check_link)(struct ixgbe_hw *, ixgbe_link_speed *, bool *);\n-\ts32 (*get_firmware_version)(struct ixgbe_hw *, u16 *);\n \ts32 (*read_i2c_byte)(struct ixgbe_hw *, u8, u8, u8 *);\n \ts32 (*write_i2c_byte)(struct ixgbe_hw *, u8, u8, u8);\n \ts32 (*read_i2c_sff8472)(struct ixgbe_hw *, u8 , u8 *);\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c\nindex e2ff823ee202..72049fa23616 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c\n@@ -913,7 +913,6 @@ static const struct ixgbe_phy_operations phy_ops_X540 = {\n \t.write_i2c_eeprom = &ixgbe_write_i2c_eeprom_generic,\n \t.check_overtemp = &ixgbe_tn_check_overtemp,\n \t.set_phy_power = &ixgbe_set_copper_phy_power,\n-\t.get_firmware_version = &ixgbe_get_phy_firmware_version_generic,\n };\n \n static const u32 ixgbe_mvals_X540[IXGBE_MVALS_IDX_LIMIT] = {\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex 16e1aaf74a63..e58bd77d9197 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -3382,8 +3382,7 @@ static const struct ixgbe_eeprom_operations eeprom_ops_X550EM_x = {\n \t.write_i2c_eeprom\t= &ixgbe_write_i2c_eeprom_generic, \\\n \t.setup_link\t\t= &ixgbe_setup_phy_link_generic, \\\n \t.set_phy_power\t\t= NULL, \\\n-\t.check_overtemp\t\t= &ixgbe_tn_check_overtemp, \\\n-\t.get_firmware_version\t= &ixgbe_get_phy_firmware_version_generic,\n+\t.check_overtemp\t\t= &ixgbe_tn_check_overtemp,\n \n static const struct ixgbe_phy_operations phy_ops_X550 = {\n \tX550_COMMON_PHY\n", "prefixes": [ "2/4" ] }