Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/697156/?format=api
{ "id": 697156, "url": "http://patchwork.ozlabs.org/api/patches/697156/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/0033F4D0CBA60E4088C47C946608755C02C8B736@BPXM22GP.gisp.nec.co.jp/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<0033F4D0CBA60E4088C47C946608755C02C8B736@BPXM22GP.gisp.nec.co.jp>", "list_archive_url": null, "date": "2016-11-21T06:48:45", "name": "ixgbe: Fix incorrect bitwise operations of PTP Rx timestamp flags", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "76dede773ed82336f88dcf4dad5c004c996c3cb5", "submitter": { "id": 70431, "url": "http://patchwork.ozlabs.org/api/people/70431/?format=api", "name": "Yusuke Suzuki", "email": "yus-suzuki@uf.jp.nec.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/0033F4D0CBA60E4088C47C946608755C02C8B736@BPXM22GP.gisp.nec.co.jp/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/697156/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/697156/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tMfcc5cg6z9t2N\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 21 Nov 2016 18:00:15 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DC8DA86735;\n\tMon, 21 Nov 2016 07:00:12 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id strfeoSuzsWj; Mon, 21 Nov 2016 07:00:11 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id ABB65855E9;\n\tMon, 21 Nov 2016 07:00:11 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 5CA631D112F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 21 Nov 2016 07:00:10 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5689986C06\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 21 Nov 2016 07:00:10 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hweW4SFzOfcu for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 21 Nov 2016 07:00:08 +0000 (UTC)", "from tyo200.gate.nec.co.jp (TYO200.gate.nec.co.jp [210.143.35.50])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 57E8986ACB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 21 Nov 2016 07:00:08 +0000 (UTC)", "from tyo202.gate.nec.co.jp ([10.7.69.202])\n\tby tyo200.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id uAL6r00q001680\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 21 Nov 2016 15:53:00 +0900 (JST)", "from mailgate3.nec.co.jp ([10.7.69.193])\n\tby tyo202.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id uAL6n4rk021832\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 21 Nov 2016 15:49:05 +0900 (JST)", "from mailsv4.nec.co.jp (imss63.nec.co.jp [10.7.69.158]) by\n\tmailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP\n\tid uAL6n4U17389 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 21 Nov 2016 15:49:04 +0900 (JST)", "from mail03.kamome.nec.co.jp (mail03.kamome.nec.co.jp [10.25.43.7])\n\tby mailsv4.nec.co.jp (8.13.8/8.13.4) with ESMTP id uAL6mmcO026156\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 21 Nov 2016 15:49:04 +0900 (JST)", "from bpxc99gp.gisp.nec.co.jp ([10.38.151.151] [10.38.151.151]) by\n\tmail02.kamome.nec.co.jp with ESMTP id BT-MMP-4485522;\n\tMon, 21 Nov 2016 15:48:47 +0900", "from BPXM22GP.gisp.nec.co.jp ([10.38.151.214]) by\n\tBPXC23GP.gisp.nec.co.jp ([10.38.151.151]) with mapi id 14.03.0224.002;\n\tMon, 21 Nov 2016 15:48:46 +0900" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:11:01 by SQLgrey-1.7.6", "From": "Yusuke Suzuki <yus-suzuki@uf.jp.nec.com>", "To": "\"intel-wired-lan@lists.osuosl.org\" <intel-wired-lan@lists.osuosl.org>", "Thread-Topic": "[PATCH] ixgbe: Fix incorrect bitwise operations of PTP Rx\n\ttimestamp flags", "Thread-Index": "AdJDt/C2+K4vQoDKTbC7gwFPXl3XDA==", "Date": "Mon, 21 Nov 2016 06:48:45 +0000", "Message-ID": "<0033F4D0CBA60E4088C47C946608755C02C8B736@BPXM22GP.gisp.nec.co.jp>", "Accept-Language": "ja-JP, en-US", "Content-Language": "ja-JP", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.68.80.138]", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: Fix incorrect bitwise operations\n\tof PTP Rx timestamp flags", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Yusuke Suzuki <yus-suzuki@uf.jp.nec.com>\n\nRx timestamp does not work on 82599 and X540 because bitwise operation\nof RX_HWTSTAMP flags is incorrect and ixgbe_ptp_rx_hwtstamp() is never\ncalled. This patch fixes it to enable Rx timestamp on 82599 and X540.\n\nWithout this fix:\n# ptp4l -Hsmq -i ens27f0\nptp4l[278.730]: selected /dev/ptp8 as PTP clock\nptp4l[278.733]: port 1: INITIALIZING to LISTENING on INITIALIZE\nptp4l[278.733]: port 0: INITIALIZING to LISTENING on INITIALIZE\nptp4l[278.834]: port 1: received SYNC without timestamp\nptp4l[278.835]: port 1: new foreign master 1c3947.fffe.60f9cc-1\nptp4l[279.834]: port 1: received SYNC without timestamp\nptp4l[280.834]: port 1: received SYNC without timestamp\nptp4l[281.834]: port 1: received SYNC without timestamp\nptp4l[282.834]: port 1: received SYNC without timestamp\nptp4l[282.835]: selected best master clock 1c3947.fffe.60f9cc\nptp4l[282.835]: port 1: LISTENING to UNCALIBRATED on RS_SLAVE\nptp4l[283.834]: port 1: received SYNC without timestamp\n\nWith this fix:\n# ptp4l -Hsmq -i ens27f0\nptp4l[239.154]: selected /dev/ptp8 as PTP clock\nptp4l[239.157]: port 1: INITIALIZING to LISTENING on INITIALIZE\nptp4l[239.157]: port 0: INITIALIZING to LISTENING on INITIALIZE\nptp4l[240.989]: port 1: new foreign master 1c3947.fffe.60f9cc-1\nptp4l[244.989]: selected best master clock 1c3947.fffe.60f9cc\nptp4l[244.989]: port 1: LISTENING to UNCALIBRATED on RS_SLAVE\nptp4l[246.977]: master offset -899583339542096 s0 freq +0 path delay 16222\nptp4l[247.977]: master offset -899583339617265 s1 freq -75169 path delay 16177\nptp4l[248.977]: master offset -130 s2 freq -75299 path delay 16177\nptp4l[248.977]: port 1: UNCALIBRATED to SLAVE on MASTER_CLOCK_SELECTED\nptp4l[249.977]: master offset -9 s2 freq -75217 path delay 16177\nptp4l[250.977]: master offset 88 s2 freq -75123 path delay 16132\n\nFixes: a9763f3cb54c (\"ixgbe: Update PTP to support X550EM_x devices\")\nSigned-off-by: Yusuke Suzuki <yus-suzuki@uf.jp.nec.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c\nindex a922776..5599907 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c\n@@ -858,14 +858,14 @@ static int ixgbe_ptp_set_timestamp_mode(struct ixgbe_adapter *adapter,\n \tcase HWTSTAMP_FILTER_PTP_V1_L4_SYNC:\n \t\ttsync_rx_ctl |= IXGBE_TSYNCRXCTL_TYPE_L4_V1;\n \t\ttsync_rx_mtrl |= IXGBE_RXMTRL_V1_SYNC_MSG;\n-\t\tadapter->flags &= ~(IXGBE_FLAG_RX_HWTSTAMP_ENABLED |\n-\t\t\t\t IXGBE_FLAG_RX_HWTSTAMP_IN_REGISTER);\n+\t\tadapter->flags |= (IXGBE_FLAG_RX_HWTSTAMP_ENABLED |\n+\t\t\t\t IXGBE_FLAG_RX_HWTSTAMP_IN_REGISTER);\n \t\tbreak;\n \tcase HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ:\n \t\ttsync_rx_ctl |= IXGBE_TSYNCRXCTL_TYPE_L4_V1;\n \t\ttsync_rx_mtrl |= IXGBE_RXMTRL_V1_DELAY_REQ_MSG;\n-\t\tadapter->flags &= ~(IXGBE_FLAG_RX_HWTSTAMP_ENABLED |\n-\t\t\t\t IXGBE_FLAG_RX_HWTSTAMP_IN_REGISTER);\n+\t\tadapter->flags |= (IXGBE_FLAG_RX_HWTSTAMP_ENABLED |\n+\t\t\t\t IXGBE_FLAG_RX_HWTSTAMP_IN_REGISTER);\n \t\tbreak;\n \tcase HWTSTAMP_FILTER_PTP_V2_EVENT:\n \tcase HWTSTAMP_FILTER_PTP_V2_L2_EVENT:\n@@ -879,8 +879,8 @@ static int ixgbe_ptp_set_timestamp_mode(struct ixgbe_adapter *adapter,\n \t\ttsync_rx_ctl |= IXGBE_TSYNCRXCTL_TYPE_EVENT_V2;\n \t\tis_l2 = true;\n \t\tconfig->rx_filter = HWTSTAMP_FILTER_PTP_V2_EVENT;\n-\t\tadapter->flags &= ~(IXGBE_FLAG_RX_HWTSTAMP_ENABLED |\n-\t\t\t\t IXGBE_FLAG_RX_HWTSTAMP_IN_REGISTER);\n+\t\tadapter->flags |= (IXGBE_FLAG_RX_HWTSTAMP_ENABLED |\n+\t\t\t\t IXGBE_FLAG_RX_HWTSTAMP_IN_REGISTER);\n \t\tbreak;\n \tcase HWTSTAMP_FILTER_PTP_V1_L4_EVENT:\n \tcase HWTSTAMP_FILTER_ALL:\n", "prefixes": [] }