Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/696959/?format=api
{ "id": 696959, "url": "http://patchwork.ozlabs.org/api/patches/696959/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1479592438-17078-1-git-send-email-tushar.n.dave@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1479592438-17078-1-git-send-email-tushar.n.dave@oracle.com>", "list_archive_url": null, "date": "2016-11-19T21:53:58", "name": "i40e: remove unnecessary __packed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "981a2ffdf5a08eea2416ddd92ece543a56006953", "submitter": { "id": 68023, "url": "http://patchwork.ozlabs.org/api/people/68023/?format=api", "name": "Tushar Dave", "email": "tushar.n.dave@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1479592438-17078-1-git-send-email-tushar.n.dave@oracle.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/696959/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/696959/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tLpbT6B7jz9snm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 20 Nov 2016 08:56:21 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0F8EE87FE5;\n\tSat, 19 Nov 2016 21:56:19 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OPVKKfhlJKko; Sat, 19 Nov 2016 21:56:17 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6206487E6C;\n\tSat, 19 Nov 2016 21:56:17 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id BC0EB1C00F2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 19 Nov 2016 21:56:16 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 929FC2A1CE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 19 Nov 2016 21:56:16 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Za9fzv4mNPqy for <intel-wired-lan@lists.osuosl.org>;\n\tSat, 19 Nov 2016 21:56:15 +0000 (UTC)", "from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69])\n\tby silver.osuosl.org (Postfix) with ESMTPS id B72852A193\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 19 Nov 2016 21:56:15 +0000 (UTC)", "from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2)\n\twith ESMTP id uAJLuDQm010820\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Sat, 19 Nov 2016 21:56:13 GMT", "from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235])\n\tby aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tuAJLuC2h015554\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);\n\tSat, 19 Nov 2016 21:56:13 GMT", "from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16])\n\tby aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id\n\tuAJLuAWW023681; Sat, 19 Nov 2016 21:56:11 GMT", "from tndave-linux.us.oracle.com (/10.159.150.163)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Sat, 19 Nov 2016 13:56:10 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Tushar Dave <tushar.n.dave@oracle.com>", "To": "jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org,\n\tnetdev@vger.kernel.org", "Date": "Sat, 19 Nov 2016 13:53:58 -0800", "Message-Id": "<1479592438-17078-1-git-send-email-tushar.n.dave@oracle.com>", "X-Mailer": "git-send-email 1.9.1", "X-Source-IP": "aserv0022.oracle.com [141.146.126.234]", "Subject": "[Intel-wired-lan] [PATCH] i40e: remove unnecessary __packed", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "'struct i40e_dma_mem' defined with 'packed' directive causing kernel\nunaligned errors on sparc.\n\ne.g.\ni40e: Intel(R) Ethernet Connection XL710 Network Driver - version\n1.6.16-k\ni40e: Copyright (c) 2013 - 2014 Intel Corporation.\nKernel unaligned access at TPC[44894c] dma_4v_alloc_coherent+0x1ac/0x300\nKernel unaligned access at TPC[44894c] dma_4v_alloc_coherent+0x1ac/0x300\nKernel unaligned access at TPC[44894c] dma_4v_alloc_coherent+0x1ac/0x300\nKernel unaligned access at TPC[44894c] dma_4v_alloc_coherent+0x1ac/0x300\nKernel unaligned access at TPC[44894c] dma_4v_alloc_coherent+0x1ac/0x300\ni40e 0000:03:00.0: fw 5.1.40981 api 1.5 nvm 5.04 0x80002548 0.0.0\n\nThis can be fixed with get_unaligned/put_unaligned(). However no\nreference in driver shows that 'struct i40e_dma_mem' directly shoved\ninto NIC hardware. But instead fields of the struct are being read and\nused for hardware. Therefore, __packed is unnecessary for 'struct\ni40e_dma_mem'.\n\nIn addition, although 'struct i40e_virt_mem' doesn't cause any\nunaligned access, keeping it packed is unnecessary as well because\nof aforementioned reason.\n\nThis change make 'struct i40e_dma_mem' and 'struct i40e_virt_mem'\nunpacked.\n\nSigned-off-by: Tushar Dave <tushar.n.dave@oracle.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_osdep.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_osdep.h b/drivers/net/ethernet/intel/i40e/i40e_osdep.h\nindex 5b6feb7..be74bcf 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_osdep.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_osdep.h\n@@ -55,7 +55,7 @@ struct i40e_dma_mem {\n \tvoid *va;\n \tdma_addr_t pa;\n \tu32 size;\n-} __packed;\n+};\n \n #define i40e_allocate_dma_mem(h, m, unused, s, a) \\\n \t\t\ti40e_allocate_dma_mem_d(h, m, s, a)\n@@ -64,7 +64,7 @@ struct i40e_dma_mem {\n struct i40e_virt_mem {\n \tvoid *va;\n \tu32 size;\n-} __packed;\n+};\n \n #define i40e_allocate_virt_mem(h, m, s) i40e_allocate_virt_mem_d(h, m, s)\n #define i40e_free_virt_mem(h, m) i40e_free_virt_mem_d(h, m)\n", "prefixes": [] }