Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/695308/?format=api
{ "id": 695308, "url": "http://patchwork.ozlabs.org/api/patches/695308/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/882304dc5b8489b3293148ebec7c26b328bd4d88.1479236297.git.jkc@redhat.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<882304dc5b8489b3293148ebec7c26b328bd4d88.1479236297.git.jkc@redhat.com>", "list_archive_url": null, "date": "2016-11-15T19:00:37", "name": "[1/1] ixgbe: test for trust in macvlan adjustments for vf", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6cf8012c818f82cd2d0591f1331a1e341ab3b110", "submitter": { "id": 70396, "url": "http://patchwork.ozlabs.org/api/people/70396/?format=api", "name": "Ken Cox", "email": "jkc@redhat.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/882304dc5b8489b3293148ebec7c26b328bd4d88.1479236297.git.jkc@redhat.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/695308/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/695308/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tJMV53hNgz9sBR\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 16 Nov 2016 09:28:13 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E2424C1C46;\n\tTue, 15 Nov 2016 22:28:11 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id O_OM-BRz0ySB; Tue, 15 Nov 2016 22:28:10 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6507CC1926;\n\tTue, 15 Nov 2016 22:28:10 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 5E7051CF920\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 15 Nov 2016 19:00:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 591A230D54\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 15 Nov 2016 19:00:41 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Itbo1QHTAH8J for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 15 Nov 2016 19:00:39 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby silver.osuosl.org (Postfix) with ESMTPS id A342E2A0E9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 15 Nov 2016 19:00:39 +0000 (UTC)", "from int-mx13.intmail.prod.int.phx2.redhat.com\n\t(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id F1EB48EB53\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 15 Nov 2016 19:00:38 +0000 (UTC)", "from dhcp-10-15-1-72.hsv.redhat.com ([10.15.1.133])\n\tby int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tSMTP id uAFJ0bZk030232; Tue, 15 Nov 2016 14:00:37 -0500", "by dhcp-10-15-1-72.hsv.redhat.com (sSMTP sendmail emulation);\n\tTue, 15 Nov 2016 13:00:37 -0600" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": [ "domain auto-whitelisted by SQLgrey-1.7.6", "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]); Tue, 15 Nov 2016 19:00:39 +0000 (UTC)" ], "From": "\"Ken Cox\" <jkc@redhat.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 15 Nov 2016 13:00:37 -0600", "Message-Id": "<882304dc5b8489b3293148ebec7c26b328bd4d88.1479236297.git.jkc@redhat.com>", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.26", "X-Mailman-Approved-At": "Tue, 15 Nov 2016 22:28:09 +0000", "Subject": "[Intel-wired-lan] [1/1] ixgbe: test for trust in macvlan\n\tadjustments for vf", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "There are two methods for setting mac addresses in a Macvlan, that\ndifferentiate themselves in the function macvlan_set_mac_Address.\nIf the macvlan mode is passthru, then we use the dev_set_mac_address\nmethod, otherwise we use the dev_uc api via macvlan_sync_addresses.\nThe latter method (which would stem from using any non-passthru mode,\nlike bridge, or vepa), calls down into the driver in a path that terminates\nin ixgbevf_set_uc_addr_vf, which sends a IXGBE_VF_SET_MACVLAN message,\nwhich causes the pf to spawn the noted error message. This occurs because\nit appears that the guest is trying to delete the mac address of the macvlan\nbefore adding another.\n\nThe other path in macvlan_set_mac_address uses dev_set_mac_address, which\ncalls into ixgbevf_set_mac which uses the IXGBE_VF_SET_MAC_ADDR to the\npf to set the macvlan mac address.\n\nThe discrepancy here is in the handlers. The handler function for\nIXGBE_VF_SET_MAC_ADDR (ixgbe_set_vf_mac_addr) has a check for\nthe vfinfo[].trusted bit to allow the operation if the vf is trusted.\nIn comparison, the IXGBE_VF_SET_MACVLAN message handler\n(ixgbe_set_vf_macvlan_msg) has no such check of the trusted bit.\n\nSigned-off-by: Ken Cox <jkc@redhat.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\nindex 42138be..9021c06 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\n@@ -934,7 +934,8 @@ static int ixgbe_set_vf_macvlan_msg(struct ixgbe_adapter *adapter,\n \t\t IXGBE_VT_MSGINFO_SHIFT;\n \tint err;\n \n-\tif (adapter->vfinfo[vf].pf_set_mac && index > 0) {\n+\tif (adapter->vfinfo[vf].pf_set_mac && !adapter->vfinfo[vf].trusted &&\n+\t index > 0) {\n \t\te_warn(drv,\n \t\t \"VF %d requested MACVLAN filter but is administratively denied\\n\",\n \t\t vf);\n", "prefixes": [ "1/1" ] }