Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/693850/?format=api
{ "id": 693850, "url": "http://patchwork.ozlabs.org/api/patches/693850/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20161111181251.17498.91161.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20161111181251.17498.91161.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2016-11-11T18:12:51", "name": "[v4] ixgbevf: handle race between close and suspend on shutdown", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d55f772e7abb698fecdcf61cd5974da88a6536d9", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20161111181251.17498.91161.stgit@localhost6.localdomain6/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/693850/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/693850/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tFp8L0RJ9z9t0J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 12 Nov 2016 05:18:58 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4F431960A7;\n\tFri, 11 Nov 2016 18:18:56 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ULUIeo2MJKuT; Fri, 11 Nov 2016 18:18:54 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9319C95A9A;\n\tFri, 11 Nov 2016 18:18:54 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1BEF51C273F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Nov 2016 18:18:53 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 10A58C2C66\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Nov 2016 18:18:53 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2zKWwfdGzMsq for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Nov 2016 18:18:52 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 59FD7C2C5F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Nov 2016 18:18:52 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP; 11 Nov 2016 10:18:51 -0800", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.3.186])\n\tby orsmga003.jf.intel.com with ESMTP; 11 Nov 2016 10:18:51 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,474,1473145200\"; d=\"scan'208\";a=\"900450083\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 11 Nov 2016 10:12:51 -0800", "Message-ID": "<20161111181251.17498.91161.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH v4] ixgbevf: handle race between close and\n\tsuspend on shutdown", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "When an interface is part of a namespace it is possible that\nixgbevf_close() may be called while ixgbevf_suspend() is running\nwhich ends up in a double free WARN and/or a BUG in free_msi_irqs()\n\nTo handle this situation we extend the rtnl_lock() to protect the\ncall to netif_device_detach() and check for !netif_device_present()\nto avoid entering close while in suspend.\n\nAlso added rtnl locks to ixgbevf_queue_reset_subtask().\n\n-v2 handle the race with netif_device_detach/present() and rtnl\nlocks as suggested by Alex Duyck\n\n-v3 add rtnl locks and check in ixgbevf_remove()\n\n-v4 revert the ixgbevf_remove() changes from v3, I will submit a\nseparate patch to deal with the PCIe AER issue on failed recovery\n\nCC: Alexander Duyck <alexander.h.duyck@intel.com>\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex d316f50..2cc3d90 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -3242,6 +3242,9 @@ int ixgbevf_close(struct net_device *netdev)\n {\n \tstruct ixgbevf_adapter *adapter = netdev_priv(netdev);\n \n+\tif (!netif_device_present(netdev))\n+\t\treturn 0;\n+\n \tixgbevf_down(adapter);\n \tixgbevf_free_irq(adapter);\n \n@@ -3268,6 +3271,8 @@ static void ixgbevf_queue_reset_subtask(struct ixgbevf_adapter *adapter)\n \t * match packet buffer alignment. Unfortunately, the\n \t * hardware is not flexible enough to do this dynamically.\n \t */\n+\trtnl_lock();\n+\n \tif (netif_running(dev))\n \t\tixgbevf_close(dev);\n \n@@ -3276,6 +3281,8 @@ static void ixgbevf_queue_reset_subtask(struct ixgbevf_adapter *adapter)\n \n \tif (netif_running(dev))\n \t\tixgbevf_open(dev);\n+\n+\trtnl_unlock();\n }\n \n static void ixgbevf_tx_ctxtdesc(struct ixgbevf_ring *tx_ring,\n@@ -3792,17 +3799,17 @@ static int ixgbevf_suspend(struct pci_dev *pdev, pm_message_t state)\n \tint retval = 0;\n #endif\n \n+\trtnl_lock();\n \tnetif_device_detach(netdev);\n \n \tif (netif_running(netdev)) {\n-\t\trtnl_lock();\n \t\tixgbevf_down(adapter);\n \t\tixgbevf_free_irq(adapter);\n \t\tixgbevf_free_all_tx_resources(adapter);\n \t\tixgbevf_free_all_rx_resources(adapter);\n \t\tixgbevf_clear_interrupt_scheme(adapter);\n-\t\trtnl_unlock();\n \t}\n+\trtnl_unlock();\n \n #ifdef CONFIG_PM\n \tretval = pci_save_state(pdev);\n", "prefixes": [ "v4" ] }