Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/693456/?format=api
{ "id": 693456, "url": "http://patchwork.ozlabs.org/api/patches/693456/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1478803603-30306-1-git-send-email-gpiccoli@linux.vnet.ibm.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1478803603-30306-1-git-send-email-gpiccoli@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2016-11-10T18:46:43", "name": "[net,v2] igb: re-assign hw address pointer on reset after PCI error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "edc80117a7192336a69bca8cdd4756c7af3c50f1", "submitter": { "id": 67066, "url": "http://patchwork.ozlabs.org/api/people/67066/?format=api", "name": "Guilherme G. Piccoli", "email": "gpiccoli@linux.vnet.ibm.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1478803603-30306-1-git-send-email-gpiccoli@linux.vnet.ibm.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/693456/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/693456/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tFBq16Z3Hz9t0v\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 11 Nov 2016 05:46:53 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 38C218B1E4;\n\tThu, 10 Nov 2016 18:46:52 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5GC8xDxE1Qpr; Thu, 10 Nov 2016 18:46:50 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C51C28ADCA;\n\tThu, 10 Nov 2016 18:46:50 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id EBB781C2233\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Nov 2016 18:46:49 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E1CAA8ADCA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Nov 2016 18:46:49 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id oBbjpfBwtyUK for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Nov 2016 18:46:49 +0000 (UTC)", "from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 554228A7FE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Nov 2016 18:46:49 +0000 (UTC)", "from pps.filterd (m0098416.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id\n\tuAAIdJiI047870 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Nov 2016 13:46:48 -0500", "from e24smtp02.br.ibm.com (e24smtp02.br.ibm.com [32.104.18.86])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 26md6h6sqb-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Nov 2016 13:46:48 -0500", "from localhost\n\tby e24smtp02.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <intel-wired-lan@lists.osuosl.org> from\n\t<gpiccoli@linux.vnet.ibm.com>; Thu, 10 Nov 2016 16:46:46 -0200", "from d24dlp02.br.ibm.com (9.18.248.206)\n\tby e24smtp02.br.ibm.com (10.172.0.142) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 10 Nov 2016 16:46:44 -0200", "from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16])\n\tby d24dlp02.br.ibm.com (Postfix) with ESMTP id 469FB1DC006E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Nov 2016 13:46:44 -0500 (EST)", "from d24av03.br.ibm.com (d24av03.br.ibm.com [9.8.31.95])\n\tby d24relay01.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tuAAIkinG4595832 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Nov 2016 16:46:44 -0200", "from d24av03.br.ibm.com (localhost [127.0.0.1])\n\tby d24av03.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tuAAIkhfA007109 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Nov 2016 16:46:43 -0200", "from localhost (HarryBosch.br.ibm.com [9.18.235.153])\n\tby d24av03.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tuAAIkhlc007105; Thu, 10 Nov 2016 16:46:43 -0200" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "\"Guilherme G. Piccoli\" <gpiccoli@linux.vnet.ibm.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 10 Nov 2016 16:46:43 -0200", "X-Mailer": "git-send-email 2.1.0", "X-TM-AS-MML": "disable", "X-Content-Scanned": "Fidelis XPS MAILER", "x-cbid": "16111018-0020-0000-0000-000002631066", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "16111018-0021-0000-0000-000030772E55", "Message-Id": "<1478803603-30306-1-git-send-email-gpiccoli@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2016-11-10_07:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000\n\tdefinitions=main-1611100320", "Cc": "netdev@vger.kernel.org, gpiccoli@linux.vnet.ibm.com", "Subject": "[Intel-wired-lan] [PATCH net v2] igb: re-assign hw address pointer\n\ton reset after PCI error", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Whenever the igb driver detects the result of a read operation returns\na value composed only by F's (like 0xFFFFFFFF), it will detach the\nnet_device, clear the hw_addr pointer and warn to the user that adapter's\nlink is lost - those steps happen on igb_rd32().\n\nIn case a PCI error happens on Power architecture, there's a recovery\nmechanism called EEH, that will reset the PCI slot and call driver's\nhandlers to reset the adapter and network functionality as well.\n\nWe observed that once hw_addr is NULL after the error is detected on\nigb_rd32(), it's never assigned back, so in the process of resetting\nthe network functionality we got a NULL pointer dereference in both\nigb_configure_tx_ring() and igb_configure_rx_ring(). In order to avoid\nsuch bug, this patch re-assigns the hw_addr value in the slot_reset\nhandler.\n\nReported-by: Anthony H. Thai <ahthai@us.ibm.com>\nReported-by: Harsha Thyagaraja <hathyaga@in.ibm.com>\nSigned-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex edc9a6a..136ee9e 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -7878,6 +7878,11 @@ static pci_ers_result_t igb_io_slot_reset(struct pci_dev *pdev)\n \t\tpci_enable_wake(pdev, PCI_D3hot, 0);\n \t\tpci_enable_wake(pdev, PCI_D3cold, 0);\n \n+\t\t/* In case of PCI error, adapter lose its HW address\n+\t\t * so we should re-assign it here.\n+\t\t */\n+\t\thw->hw_addr = adapter->io_addr;\n+\n \t\tigb_reset(adapter);\n \t\twr32(E1000_WUS, ~0);\n \t\tresult = PCI_ERS_RESULT_RECOVERED;\n", "prefixes": [ "net", "v2" ] }