Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/693430/?format=api
{ "id": 693430, "url": "http://patchwork.ozlabs.org/api/patches/693430/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1478800649-22831-1-git-send-email-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1478800649-22831-1-git-send-email-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2016-11-10T17:57:29", "name": "[v2] ixgbe: Reduce I2C retry count on X550 devices", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e69df0d91fbad6c5e009a4f0a7ebfa9872c4298e", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1478800649-22831-1-git-send-email-anthony.l.nguyen@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/693430/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/693430/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tFB3R6Lxhz9t2N\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 11 Nov 2016 05:12:35 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1518E32CE7;\n\tThu, 10 Nov 2016 18:12:33 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ghHffnJNF15S; Thu, 10 Nov 2016 18:12:32 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id EBF04328D4;\n\tThu, 10 Nov 2016 18:12:31 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 969D31C2233\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Nov 2016 18:12:30 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8FB42328D4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Nov 2016 18:12:30 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id NG3HoIMSbzEZ for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Nov 2016 18:12:29 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby silver.osuosl.org (Postfix) with ESMTPS id C0BC730D93\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Nov 2016 18:12:29 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga103.jf.intel.com with ESMTP; 10 Nov 2016 10:12:18 -0800", "from unknown (HELO anguy11-desk2.localdomain.com) ([10.166.12.51])\n\tby FMSMGA003.fm.intel.com with ESMTP; 10 Nov 2016 10:12:18 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,619,1473145200\"; d=\"scan'208\";a=\"784976585\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 10 Nov 2016 09:57:29 -0800", "Message-Id": "<1478800649-22831-1-git-send-email-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.4.0", "Subject": "[Intel-wired-lan] [PATCH v2] ixgbe: Reduce I2C retry count on X550\n\tdevices", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "A retry count of 10 is likely to run into problems on X550 devices that\nhave to detect and reset unresponsive CS4227 devices. So, reduce the I2C\nretry count to 3 for X550 and above. This should avoid any possible\nregressions in existing devices.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n\nv2 -\n Removed mac check in ixgbe_read_i2c_combined_generic_int(); set initial\n max_retry value to 3 instead.\n\n drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\nindex 4aa6793..e0fc147 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n@@ -113,7 +113,7 @@ s32 ixgbe_read_i2c_combined_generic_int(struct ixgbe_hw *hw, u8 addr,\n \t\t\t\t\tu16 reg, u16 *val, bool lock)\n {\n \tu32 swfw_mask = hw->phy.phy_semaphore_mask;\n-\tint max_retry = 10;\n+\tint max_retry = 3;\n \tint retry = 0;\n \tu8 csum_byte;\n \tu8 high_bits;\n@@ -1756,6 +1756,8 @@ static s32 ixgbe_read_i2c_byte_generic_int(struct ixgbe_hw *hw, u8 byte_offset,\n \tu32 swfw_mask = hw->phy.phy_semaphore_mask;\n \tbool nack = true;\n \n+\tif (hw->mac.type >= ixgbe_mac_X550)\n+\t\tmax_retry = 3;\n \tif (ixgbe_is_sfp_probe(hw, byte_offset, dev_addr))\n \t\tmax_retry = IXGBE_SFP_DETECT_RETRIES;\n \n", "prefixes": [ "v2" ] }